Bug 200663

I forgot to say, that there was already a problem with the i2c gpio's on cannon-lake that was fixed here: https://bugzilla.kernel.org/show_bug.cgi?id=199911#c68

Created attachment 277565 [details]
last entries before the Touchpad stops working from Asus GL703GE

recorded with hid-recorder, the hid-recorder does not record anything until I make a rmmod && modprobe hid-multitouch, also restarting the hid-recorder does not help, so it seems to loose connection

Anther bit of info:

i can now REPRODUCE THE FREEZE: if you put 5 fingers on the touchpad at once then in freezes always.

You are forget it!

When system is booting, touchpad elan1200 is work perfectly. But in log i can see warnings "Incomplete report 16/2^16".

Via 2 minutes active using touchpad, touchpad lost connections and absolutely not work.

I can monitoring it by xinput --list.

Please solve it!

Btw, i see if i using nouveau touchpad absolutely not work. I poweroff all nouveau modules.
And using intel graphics.

But its not solve crash work of touchpad.

I think problem in ACPI, and IRQ, and in gpio control.. 
Yeah.. please, fix it.. very more peoples say thanks.

My hardware:
Asus strix GL703VD.
Touchpad HID over I2C.
Kernel 4.18.5.
Btw, in kerbel 3.10 touchpad work stable and perfectly, but have very low resolution..
I test it in CENTOS live sd. In centos kernel is 3.10.

My new system is Gentoo, kernel is 4.18.5 from Vanilla-Sources(kernel.org).
Because i can not get work touchpad in Gentoo-Sources (with patches by gentoo team).

So.. please solve lost connections and inconplete report..

Thanks.

(In reply to Search_Terminal from comment #4)
> You are forget it!
> 
> When system is booting, touchpad elan1200 is work perfectly. But in log i
> can see warnings "Incomplete report 16/2^16".
> 
> Via 2 minutes active using touchpad, touchpad lost connections and
> absolutely not work.
> 
> I can monitoring it by xinput --list.
> 
> Please solve it!
> 
> Btw, i see if i using nouveau touchpad absolutely not work. I poweroff all
> nouveau modules.
> And using intel graphics.
> 
> But its not solve crash work of touchpad.
> 
> I think problem in ACPI, and IRQ, and in gpio control.. 
> Yeah.. please, fix it.. very more peoples say thanks.
> 
> My hardware:
> Asus strix GL703VD.
> Touchpad HID over I2C.
> Kernel 4.18.5.
> Btw, in kerbel 3.10 touchpad work stable and perfectly, but have very low
> resolution..
> I test it in CENTOS live sd. In centos kernel is 3.10.
> 
> My new system is Gentoo, kernel is 4.18.5 from Vanilla-Sources(kernel.org).
> Because i can not get work touchpad in Gentoo-Sources (with patches by
> gentoo team).
> 
> So.. please solve lost connections and inconplete report..
> 
> Thanks.

Hello Search_Terminal

this is not the Bugreport for non-working touchpad this is the bugreport if the touchpad already works but disconnects and fires multiple clicks, to get it running use this thread: https://bugzilla.kernel.org/show_bug.cgi?id=199911.

if you have the same hardware like i have in my GL793GE then you must apply this two patches to get it working: https://bugzilla.kernel.org/show_bug.cgi?id=199911#c68

And otherwise kindly ask Andy Shevchenko in the other thread, he helped me fixing the GPIO stuff

with kind regards
Marc

Can you test ig bug #200899 has a solution for your case?

Created attachment 278295 [details]
attachment-1818-0.html

вт, 4 сент. 2018 г., 22:38 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #6 from Andy Shevchenko (andy.shevchenko@gmail.com) ---
> Can you test ig bug #200899 has a solution for your case?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.



Please, tell me, how i can test it?

Please, you should to know. My work notebook(laptop) needed for me work and
important.
I can test driver only insmod method, okay? Because for me critical
important have a work laptop.

Please, write for me instructions how to test.


Hmm..

Please, tell developers (cc) about beta-test of driver "for vivien" with my
patch (comment //no_empty_report).
Its solve errors in log of kernel and solve problem of log 2Gb per 3day,
and improve work touchpad.

Please, see last my comments on bugzilla.
Its important, because Asus GL703 will be popular model of hight perf
laptops.

If tests will be good, need to add this code to vanilla-sources of kernel
linux. Its solve problem with elan1200.

hello @andy shevchenko

i tested with kernel 4.19-rc2 and there is again this GPIO Problem

[   13.957960] cannonlake-pinctrl INT3450:00: pin 225 cannot be used as IRQ
[   13.957962] genirq: Setting trigger mode 8 for irq 138 failed (intel_gpio_irq_type+0x0/0x140)
[   13.957993] i2c_hid i2c-ELAN1200:00: Could not register for ELAN1200:00 interrupt, irq = 138, ret = -1
[   13.958016] i2c_hid: probe of i2c-ELAN1200:00 failed with error -1


and i can not apply the patch you wrote for kernel 4.18-rc6, so i can not test with kernel >= 4.19-rc1

will this patch you wrote for me end up in mainline or not?

and i could try to test the patch from #200899 with 4.18-rc6 where your patch fixed the gpio stuff...

with kind regards
Marc

Created attachment 278319 [details]
attachment-22891-0.html

I absolutely not patch kernel.. i build 4.18.5.. after it i get from github
driver "i2c hid for vivien", improve error, build, and use insmod. Only it.

Before use Benjamin's version driver my processor have 1-2% load for irq.
Its craizy..
Benjamin's version work perfect but i test only yesterday and fast..
I today no have power continue tests..

ср, 5 сент. 2018 г., 22:50 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #8 from Marc Landolt (2009@marclandolt.ch) ---
> hello @andy shevchenko
>
> i tested with kernel 4.19-rc2 and there is again this GPIO Problem
>
> [   13.957960] cannonlake-pinctrl INT3450:00: pin 225 cannot be used as IRQ
> [   13.957962] genirq: Setting trigger mode 8 for irq 138 failed
> (intel_gpio_irq_type+0x0/0x140)
> [   13.957993] i2c_hid i2c-ELAN1200:00: Could not register for ELAN1200:00
> interrupt, irq = 138, ret = -1
> [   13.958016] i2c_hid: probe of i2c-ELAN1200:00 failed with error -1
>
>
> and i can not apply the patch you wrote for kernel 4.18-rc6, so i can not
> test
> with kernel >= 4.19-rc1
>
> will this patch you wrote for me end up in mainline or not?
>
> and i could try to test the patch from #200899 with 4.18-rc6 where your
> patch
> fixed the gpio stuff...
>
> with kind regards
> Marc
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Created attachment 278321 [details]
attachment-23475-0.html

You can not use my patch because i wrote not patch.. i wrote example of
code, and told about error, need just comment one line..
Because without it modules not compile..
Coming soon i has been create github overlay for all (for use benjamin's
version driver).

ср, 5 сент. 2018 г., 22:50 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #8 from Marc Landolt (2009@marclandolt.ch) ---
> hello @andy shevchenko
>
> i tested with kernel 4.19-rc2 and there is again this GPIO Problem
>
> [   13.957960] cannonlake-pinctrl INT3450:00: pin 225 cannot be used as IRQ
> [   13.957962] genirq: Setting trigger mode 8 for irq 138 failed
> (intel_gpio_irq_type+0x0/0x140)
> [   13.957993] i2c_hid i2c-ELAN1200:00: Could not register for ELAN1200:00
> interrupt, irq = 138, ret = -1
> [   13.958016] i2c_hid: probe of i2c-ELAN1200:00 failed with error -1
>
>
> and i can not apply the patch you wrote for kernel 4.18-rc6, so i can not
> test
> with kernel >= 4.19-rc1
>
> will this patch you wrote for me end up in mainline or not?
>
> and i could try to test the patch from #200899 with 4.18-rc6 where your
> patch
> fixed the gpio stuff...
>
> with kind regards
> Marc
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

no i mean the patch andy shevchenko wrote here for me:

https://bugzilla.kernel.org/show_bug.cgi?id=199911#c68

this patch helped that touchpad at least works but with disconnects and multiple clicks when you make a single click

but after that patch the disconnection problem was still there, it just solved the gpio problem...

with kind regards
Marc Landolt

Created attachment 278329 [details]
attachment-3227-0.html

Hmm.. its good, if you solve not correct clicking..
(i only one not understand.. why need 140Mhz freq for toucpad under i2c by
microsoft spec..? )
So.. you have disconnect problem.. its not good.. how are you solve it?
Re-load module?

Can you test centos 3.10 kernel, maybe if your touchpad work well, maybe
developers can to imporove driver by old code.?

Sometimes my touchpad bad recognition events. After click it use sometimes
click left when need to use just right click..

Yeah..
I hope this problems will be solve step by step..
What the your laptop model?

ср, 5 сент. 2018 г., 23:08 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #11 from Marc Landolt (2009@marclandolt.ch) ---
> no i mean the patch andy shevchenko wrote here for me:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=199911#c68
>
> this patch helped that touchpad at least works but with disconnects and
> multiple clicks when you make a single click
>
> but after that patch the disconnection problem was still there, it just
> solved
> the gpio problem...
>
> with kind regards
> Marc Landolt
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

@Search Terminal

Asus GL703GE

Created attachment 278339 [details]
attachment-23319-0.html

Hmmm.. I guess we have absolutely analogy hardware?
Hmm..

чт, 6 сент. 2018 г., 0:01 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #13 from Marc Landolt (2009@marclandolt.ch) ---
> @Search Terminal
>
> Asus GL703GE
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Created attachment 278341 [details]
attachment-23775-0.html

Ouw.. your hardware greater than me  ahah.
Btw, when you test linux, did you see "processor lock, get stuck" on
various distributives of Gnu/Linux?

чт, 6 сент. 2018 г., 1:28 Armv7hf <armv7hf@gmail.com>:

> Hmmm.. I guess we have absolutely analogy hardware?
> Hmm..
>
> чт, 6 сент. 2018 г., 0:01 <bugzilla-daemon@bugzilla.kernel.org>:
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>>
>> --- Comment #13 from Marc Landolt (2009@marclandolt.ch) ---
>> @Search Terminal
>>
>> Asus GL703GE
>>
>> --
>> You are receiving this mail because:
>> You are on the CC list for the bug.
>
>

I tested now Kernel 4.19-rc2

+the problem with the multiple clicks seems to be solved
+two finger scroll works
+right click with 2 Fingers and Pressing on the touchpad that is also a button works also

-it still disconnects if you put 5 fingers on the Touchpad and then you must do a sudo rmmod  hid-multitouch && sudo modprobe hid-multitouch that the touchpad works again

For the ASUS GL703GE Model it seems that you need to manually add the lines 1016, 1021 and 1022 from https://bugzilla.kernel.org/attachment.cgi?id=277507&action=diff to /drivers/pinctrl/intel/pinctrl-intel.c from kernel 4.19-rc2

( This is already reported to the Bug https://bugzilla.kernel.org/show_bug.cgi?id=199911#c102 )

with kind regards
Marc Landolt

Hello Search_Terminal

you sent me this private Mail:

> Can you test this driver??
> https://github.com/EthicalEarth/i2c_hid_driver_elan1200
> Just 
> git clone https://github.com/EthicalEarth/i2c_hid_driver_elan1200
> make
> rmmod i2c_hid
> insmod ./i2c_hid.ko
> -----------------------------------
> This no need install and replace for test.
> Just use insmod. 
> Can you tell me how its work on your PC?
> -----------------------------------

i can not test it i already use kernel 4.19-rc2, and i dont think that the problem is i2c, the touchpad is working so the i2c is working correctly with the current kernel 4.19-rc2 and the modification described here: https://bugzilla.kernel.org/show_bug.cgi?id=199911#c102

the only problem i have is that it looses connection if i put 5 fingers on the touchpad, everything else is fine... and the "140Mhz freq for toucpad" is as far as i know depending on the i2c bus speed, you need at least the doubled speed of the bus clock that you can interpret the signals correctly as far as i understood.

With kind Regards
Marc Landolt

Created attachment 278353 [details]
attachment-26883-0.html

Okay, did you have in dmesg "incomplete report"?
Why you can not test it in your machine?(
I understand, you patched new kernel and work all good.. but can you just
load module or compile?
Or this not work on 4.19 kernel?(

чт, 6 сент. 2018 г., 23:25 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #17 from Marc Landolt (2009@marclandolt.ch) ---
> Hello Search_Terminal
>
> you sent me this private Mail:
>
> > Can you test this driver??
> > https://github.com/EthicalEarth/i2c_hid_driver_elan1200
> > Just
> > git clone https://github.com/EthicalEarth/i2c_hid_driver_elan1200
> > make
> > rmmod i2c_hid
> > insmod ./i2c_hid.ko
> > -----------------------------------
> > This no need install and replace for test.
> > Just use insmod.
> > Can you tell me how its work on your PC?
> > -----------------------------------
>
> i can not test it i already use kernel 4.19-rc2, and i dont think that the
> problem is i2c, the touchpad is working so the i2c is working correctly
> with
> the current kernel 4.19-rc2 and the modification described here:
> https://bugzilla.kernel.org/show_bug.cgi?id=199911#c102
>
> the only problem i have is that it looses connection if i put 5 fingers on
> the
> touchpad, everything else is fine... and the "140Mhz freq for toucpad" is
> as
> far as i know depending on the i2c bus speed, you need at least the doubled
> speed of the bus clock that you can interpret the signals correctly as far
> as i
> understood.
>
> With kind Regards
> Marc Landolt
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

hello Search_terminal

my problem is, if i put 5 fingers on the touchpad i the touchpad looses connection and i must run rmmod hid-multitouch and modprobe hid-multitouch that it works again, so in my opinion the problem is not in i2c-hid because i dont need to reload the i2c-hid...

but i had a look at dmesg, and it also says i2c_hid i2c-ELAN1200:00: ic2_hid_get_input: incomplete report (16/65535). The Laptop runs now since 24h and it occured 696 times since yesterday.

may i ask where you got this files from, have you made this patch or who wrote this? I diff-ed with mainline kernel i2c_hid.c and there are a lot of changes and I would like to stick to the mainline kernel, because if the problem does not get fixed in mainline i (and all other people that has a ASUS GL703GE) have to patch it each time when i setup a new linux on this machine.

With kind regards
Marc Landolt

Created attachment 278355 [details]
attachment-4769-0.html

Its not secret. Autor of this driver (original
https://github.com/bentiss/hid-multitouch/tree/for-vivien) is Benjamin
Tissoires.
Its his variant of driver i2c_hid for more specific hid via i2c technology.

When Benjamin tell about it, i download and try to test. His driiver not
complile because i2c-hid.c have one non correct line. I just see gcc
message and fix.
After it, i try to use.
And work has been mire better. Because its improve error "incomplete
report".
I think this error have negative effect to work of touchpad because needed
addiitioonal time for send in  log more more errors.

Ifter usinng Beennjamin driver (module  i2c_hid my touchpad feels more
well).

I am just load on github my fixed vaiant for personal use..
Maybe in future Benjanin can too close repositoory, but my copy will be in
network.

I want have more info about work and   test of this driver on similiar asus
laptop, maybe  this driver will be work perfect on your pc(i want have
solution not only for me, but for all with this problem, its can to help
more peoples , if its will be help more peoples its can will be reason for
apply this driver to mainlain kernel, i just guess...)
So, please, if you can, test only module i2c_hid and tell me, if its solve
incomplete report error.
Maybe our touchpad will be work well.
Tell me your experience. Just use insmod.
Its not will be change your system.
But you can tell me how its work on your hardware.

Sorry, i know english very bad, its not my root lang, i write it by my self.
I hope you can to understand me..

Hm.. i wil be happy if this driver will be work fine on two Asus laptops
Gl's series.

Best regars, thanks for you attention, Andrey Ivanov aka Search_Terminal.
_________
https://github.com/EthicalEarth/i2c_hid_driver_elan1200

пт, 7 сент. 2018 г., 0:04 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #19 from Marc Landolt (2009@marclandolt.ch) ---
> hello Search_terminal
>
> my problem is, if i put 5 fingers on the touchpad i the touchpad looses
> connection and i must run rmmod hid-multitouch and modprobe hid-multitouch
> that
> it works again, so in my opinion the problem is not in i2c-hid because i
> dont
> need to reload the i2c-hid...
>
> but i had a look at dmesg, and it also says i2c_hid i2c-ELAN1200:00:
> ic2_hid_get_input: incomplete report (16/65535). The Laptop runs now since
> 24h
> and it occured 696 times since yesterday.
>
> may i ask where you got this files from, have you made this patch or who
> wrote
> this? I diff-ed with mainline kernel i2c_hid.c and there are a lot of
> changes
> and I would like to stick to the mainline kernel, because if the problem
> does
> not get fixed in mainline i (and all other people that has a ASUS GL703GE)
> have
> to patch it each time when i setup a new linux on this machine.
>
> With kind regards
> Marc Landolt
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Created attachment 278357 [details]
Benjamin Tissores / ??? patch (make output)

Hello Search_Terminal

i can not even build it with kernel 4.19-rc2: https://bugzilla.kernel.org/attachment.cgi?id=278357

With kind regards
Marc Landolt

Created attachment 278359 [details]
attachment-10237-0.html

Ohh i think this driver only for 4.15.x to my 4.18.. i guess..
its not compile on your system((

пт, 7 сент. 2018 г., 0:47 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #22 from Marc Landolt (2009@marclandolt.ch) ---
> Hello Search_Terminal
>
> i can not even build it with kernel 4.19-rc2:
> https://bugzilla.kernel.org/attachment.cgi?id=278357
>
> With kind regards
> Marc Landolt
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Hello Search Terminal

I booted with Kernel 4.18-rc6 and could build it, i insmod-ed it but the problem with the freeze when you put 5 fingers on the touchpad persists, so it's not the solution for this problem

Why don't we loop Benjamin in?

Benjamin, it looks like hid-multitouch is unhappy with this device when one places 5 fingers on the surface and stops reporting any data?

Created attachment 278369 [details]
attachment-27498-0.html

Hmm.. Benjamin  write good driver witout "incomplete report error" and..
its solve big log of kernel and disconnect because log is not fast. I think
it.

But in native i2c_hid driver, in Benjamin driver we have error disconnect
when 5 fingers touches.

I last time ask myself, when needed 5 fingers touches in laptop???

Hmm.


So.. disconnect with 5 fing. touches  not solve in all sources of kernel.

After disconnect in native driver elan1200, i have irq load 1%of core..
But touchpad not work..
Its mean touchpad work, but irq bad processing.. i think so.

What is next? Maybe need to debug driver multitouch and i2c hid?

What say Linus? I know, Linux not like patches, but driver work bad. Its
need to improve..

сб, 8 сент. 2018 г., 0:08 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> Dmitry Torokhov (dmitry.torokhov@gmail.com) changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |
> benjamin.tissoires@gmail.co
>                    |                            |m,
>                    |                            |dmitry.torokhov@gmail.com
>
> --- Comment #25 from Dmitry Torokhov (dmitry.torokhov@gmail.com) ---
> Why don't we loop Benjamin in?
>
> Benjamin, it looks like hid-multitouch is unhappy with this device when one
> places 5 fingers on the surface and stops reporting any data?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Hello Search_termainal

it sometimes happens that you touch the touchpad with your palm, and then it disonnects because the touchpad seems to identify the palm with more then 2 fingers. then it disconnects, so it would be really nice if this would be solved...

Created attachment 278371 [details]
attachment-30864-0.html

Yes yes yes. Go go go. Just i am not good programmer ((( i only little know
about c/pascal(((
Its reason why i write here, try to write Linus about this problems.. and
benjamin.. Vivien is silent..


сб, 8 сент. 2018 г., 0:21 <bugzilla-daemon@bugzilla.kernel.org>:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> --- Comment #27 from Marc Landolt (2009@marclandolt.ch) ---
> Hello Search_termainal
>
> it sometimes happens that you touch the touchpad with your palm, and then
> it
> disonnects because the touchpad seems to identify the palm with more then 2
> fingers. then it disconnects, so it would be really nice if this would be
> solved...
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

Can we take a step back and provide me the following information (a simple yes/no answer should be good enough).

@Marc:
- plain v4.19-rc2 solves most of the issues but the 5 touches that disconnects
- I am not sure I followed if you still need to patch pinctrl-intel.c to have the proper IRQ mapped
- I am surprised you do not need https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/drivers/hid/hid-multitouch.c?h=for-next&id=ec6adef5fbc3f140c70e7499fdad818acb3a46c6 to fix the click issues (this should go in the next PR sent to Linus)
- is the output of /proc/interrupts showing an abnormal usage for the touchpad (interrupts are firing even if no one is touching the touchpad, or it starts storming after the 5 finger touches)?
- if I read correctly, when the touchpad disconnects, hid-recorder doesn't send any more events
- after the touchpad disconnection, are the IRQ still growing? (in /proc/interrupts)

@Andrey
- do you have any more changes in your i2c-hid+hid-multitouch driver than the ones that are on my repo?


Marc, I have a feeling that the `#if` section you commented out is responsible for the disconnect. My theory is that you are still not mapped to the correct GPIO as IRQ, and when you put 5 fingers, the firmware expects you to poll the data, but not too fast or not too slow, and if you have a wrong mapped IRQ, there is a chance the polling simply breaks the I2C chip.

Andrey, the only 'valuable' change I had in my 'for-vivien' branch compared to upstream was https://github.com/bentiss/hid-multitouch/commit/878681f70d6f7deca5aa455619fb404a65495adc This added a magic sequence found by reverse engineering, so it might or not help. It is still a mystery about what this is however. The rest of the driver should be upstream. (Note: next time clone my repo to keep the history, it will solve the issue of not knowing what is in your repo).

В письме от понедельник, 10 сентября 2018 г. 12:06:13 +03 пользователь 
bugzilla-daemon@bugzilla.kernel.org написал:
> https://bugzilla.kernel.org/show_bug.cgi?id=200663
> 
> --- Comment #29 from Benjamin Tissoires (benjamin.tissoires@gmail.com) ---
> Can we take a step back and provide me the following information (a simple
> yes/no answer should be good enough).
> 
> @Marc:
> - plain v4.19-rc2 solves most of the issues but the 5 touches that
> disconnects - I am not sure I followed if you still need to patch
> pinctrl-intel.c to have the proper IRQ mapped
> - I am surprised you do not need
> https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/drivers
> /hid/hid-multitouch.c?h=for-next&id=ec6adef5fbc3f140c70e7499fdad818acb3a46c6
> to fix the click issues (this should go in the next PR sent to Linus) - is
> the output of /proc/interrupts showing an abnormal usage for the touchpad
> (interrupts are firing even if no one is touching the touchpad, or it
> starts storming after the 5 finger touches)?
> - if I read correctly, when the touchpad disconnects, hid-recorder doesn't
> send any more events
> - after the touchpad disconnection, are the IRQ still growing? (in
> /proc/interrupts)
> 
> @Andrey
> - do you have any more changes in your i2c-hid+hid-multitouch driver than
> the ones that are on my repo?
> 
> 
> Marc, I have a feeling that the `#if` section you commented out is
> responsible for the disconnect. My theory is that you are still not mapped
> to the correct GPIO as IRQ, and when you put 5 fingers, the firmware
> expects you to poll the data, but not too fast or not too slow, and if you
> have a wrong mapped IRQ, there is a chance the polling simply breaks the
> I2C chip.
> 
> Andrey, the only 'valuable' change I had in my 'for-vivien' branch compared
> to upstream was
> https://github.com/bentiss/hid-multitouch/commit/878681f70d6f7deca5aa455619f
> b404a65495adc This added a magic sequence found by reverse engineering, so
> it might or not help. It is still a mystery about what this is however. The
> rest of the driver should be upstream. (Note: next time clone my repo to
> keep the history, it will solve the issue of not knowing what is in your
> repo).
-------------------------------------------------------------------------------------------------------------------------------

Hello Benjamin. I will be try to answer.

> - do you have any more changes in your i2c-hid+hid-multitouch driver than
> the ones that are on my repo?

YES. 

Driver from you repo not compile under kernel v.4.18.5.

REASON:
git clone https://github.com/bentiss/hid-multitouch/ or zip archive from  
webpage.
make
gcc say error:
 CC [M]  /home/andrey/hid-multitouch-for-vivien/hid-multitouch.o
/home/andrey/hid-multitouch-for-vivien/hid-multitouch.c: in function  
«mt_probe»:
/home/andrey/hid-multitouch-for-vivien/hid-multitouch.c:1534:18: error: 
«HID_QUIRK_NO_EMPTY_INPUT» undeclared (first use in this function); did you 
mean «HID_QUIRK_MULTI_INPUT»?
  hdev->quirks |= HID_QUIRK_NO_EMPTY_INPUT;
                  ^~~~~~~~~~~~~~~~~~~~~~~~
                  HID_QUIRK_MULTI_INPUT
-----
Modules not compiled.
Solution:
open hid-multitouch.c
see 1533 line and 1534:
	hdev->quirks |= HID_QUIRK_MULTI_INPUT;
	hdev->quirks |= HID_QUIRK_NO_EMPTY_INPUT;
----
Change: 
	hdev->quirks |= HID_QUIRK_MULTI_INPUT;
	//hdev->quirks |= HID_QUIRK_NO_EMPTY_INPUT;
save file.

try to compile;
make.
succeseful and work.

The next problem is that this driver could not be compiled under 4.19rc2 even 
with my fix. Mark tried to do this without success.
-------------------------------------------------------------------------------------------------------------------------------
> Andrey, the only 'valuable' change I had in my 'for-vivien' branch compared
> to upstream was
> https://github.com/bentiss/hid-multitouch/commit/878681f70d6f7deca5aa455619f
> b404a65495adc This added a magic sequence found by reverse engineering, so
> it might or not help. It is still a mystery about what this is however. The
> rest of the driver should be upstream. (Note: next time clone my repo to
> keep the history, it will solve the issue of not knowing what is in your
> repo).

Your magical sequence solve error "incomplete report".
for a couple of days I have a huge number of log files with the size of a 
couple of gigabytes due to a mistake in mainline.
Your driver solve it.
-------------------------------------------------------------------------------------------------------------------------------
> Marc, I have a feeling that the `#if` section you commented out is
> responsible for the disconnect. My theory is that you are still not mapped
> to the correct GPIO as IRQ, and when you put 5 fingers, the firmware
> expects you to poll the data, but not too fast or not too slow, and if you
> have a wrong mapped IRQ, there is a chance the polling simply breaks the
> I2C chip.

Can i ask you.. bad IRQ can to broke touchpad i2c chip?

(In reply to Benjamin Tissoires from comment #29)
> Can we take a step back and provide me the following information (a simple
> yes/no answer should be good enough).
> 
> @Marc:

> - plain v4.19-rc2 solves most of the issues but the 5 touches that
> disconnects

no plain v4.19-rc2 does not work, i need to add line 1016, 1021 and 1022 from https://bugzilla.kernel.org/attachment.cgi?id=277507&action=diff otherwise the touchpad does not work

> - I am not sure I followed if you still need to patch pinctrl-intel.c to
> have the proper IRQ mapped

yes, as described above

> - I am surprised you do not need
> https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/drivers/
> hid/hid-multitouch.c?h=for-next&id=ec6adef5fbc3f140c70e7499fdad818acb3a46c6
> to fix the click issues (this should go in the next PR sent to Linus)

multiple clicking issue did not happend again since i use patched 4.19-rc2

> - is the output of /proc/interrupts showing an abnormal usage for the
> touchpad (interrupts are firing even if no one is touching the touchpad, or
> it starts storming after the 5 finger touches)?

i will add before.txt and after.txt, if I put 5 fingers or my palm on the touchpad the number of interrupts does not change (hopefully i looked at the right irq: >   16:    1058607          0          0       4207          0          0    2480853          0          0          0          0          0  IR-IO-APIC   16-fasteoi   idma64.0, i2c_designware.0

> - if I read correctly, when the touchpad disconnects, hid-recorder doesn't
> send any more events

yes, i need to restart hid-multitouch that it records anything again

> - after the touchpad disconnection, are the IRQ still growing? (in
> /proc/interrupts)

im not sure, but if its the 16: ... designware.0 then id does not change at all (before.txt / after.txt / later.txt, dmesg.txt)

Thank you for helping :)

With kind regards
Marc Landolt

> 
> @Andrey
> - do you have any more changes in your i2c-hid+hid-multitouch driver than
> the ones that are on my repo?
> 
> 
> Marc, I have a feeling that the `#if` section you commented out is
> responsible for the disconnect. My theory is that you are still not mapped
> to the correct GPIO as IRQ, and when you put 5 fingers, the firmware expects
> you to poll the data, but not too fast or not too slow, and if you have a
> wrong mapped IRQ, there is a chance the polling simply breaks the I2C chip.
> 
> Andrey, the only 'valuable' change I had in my 'for-vivien' branch compared
> to upstream was
> https://github.com/bentiss/hid-multitouch/commit/
> 878681f70d6f7deca5aa455619fb404a65495adc This added a magic sequence found
> by reverse engineering, so it might or not help. It is still a mystery about
> what this is however. The rest of the driver should be upstream. (Note: next
> time clone my repo to keep the history, it will solve the issue of not
> knowing what is in your repo).

Created attachment 278405 [details]
before freeze

Created attachment 278407 [details]
after freeze

Created attachment 278409 [details]
5 minutes later

Created attachment 278411 [details]
dmesg

that were the logs from kernel 4.18-rc6 with the patch from https://bugzilla.kernel.org/show_bug.cgi?id=199911#c68

i will now reboot and put the same files with kernel 4.19-rc2

Created attachment 278413 [details]
before freeze 4.19-rc2

Created attachment 278415 [details]
after freeze 4.19-rc2

Created attachment 278417 [details]
5 minutes later 4.19-rc2

Created attachment 278419 [details]
dmesg 4.19-rc2

@Benjamin Tissoires

please tell me if you need more things, or if you like you can write me on skype (marc.landolt.aarau) if you would like to access the device eg. with teamviewer and do your own tests, the machine is not in use yet, so you could do anything you would like to :)

@Benjamin Tissoires
I test latest kernel 4.19_rc3 in gentoo (git-sources), my laptop not fully boot because i915 not correctly loading(fbcon not found but fbcon include in kernel).. 
But i test touchpad in console with GPM (General Puporse Mouse) in console. Disconnect when i touch 5 fingers.
i try to solve buut my laptop fully but i think i will be back to 4.18.5... hmm.. maybe need to waiting stable release of 4.19..
Because X not start( i ca not see sddm login screen)

@Benjamin Tissoires
I create new test, rebuild kernel but intel 915 not work( hmm. 
In 4.19.rc3 not solved incomplete report error..

Here is any news about this bug?
This bug appear usually so right now, I just come back to windows and use virtual machime for a stable. Hope some good ideas come to you guy and can fix it faster.
Thanks

(In reply to Hieu Cao from comment #44)
> Here is any news about this bug?
> This bug appear usually so right now, I just come back to windows and use
> virtual machime for a stable. Hope some good ideas come to you guy and can
> fix it faster.
> Thanks

Build new kernel 4.19.0.

Touchpad elan1200 not added when loading modules. 4.19.0 not support my touchpad.

(In reply to Andrey Ivanov from comment #45)
> (In reply to Hieu Cao from comment #44)
> > Here is any news about this bug?
> > This bug appear usually so right now, I just come back to windows and use
> > virtual machime for a stable. Hope some good ideas come to you guy and can
> > fix it faster.
> > Thanks
> 
> Build new kernel 4.19.0.
> 
> Touchpad elan1200 not added when loading modules. 4.19.0 not support my
> touchpad.

you still need to add the 3 lines described in comment 16 for kernel 4.19: https://bugzilla.kernel.org/show_bug.cgi?id=200663#c16

with kind regards
marc

(In reply to Hieu Cao from comment #44)
> Here is any news about this bug?
> This bug appear usually so right now, I just come back to windows and use
> virtual machime for a stable. Hope some good ideas come to you guy and can
> fix it faster.
> Thanks

Hardware Asus GL703VD

(In reply to Hieu Cao from comment #44)
> Here is any news about this bug?
> This bug appear usually so right now, I just come back to windows and use
> virtual machime for a stable. Hope some good ideas come to you guy and can
> fix it faster.
> Thanks

Hardware Asus GL703VD

(In reply to Marc Landolt from comment #46)
> (In reply to Andrey Ivanov from comment #45)
> > (In reply to Hieu Cao from comment #44)
> > > Here is any news about this bug?
> > > This bug appear usually so right now, I just come back to windows and use
> > > virtual machime for a stable. Hope some good ideas come to you guy and
> can
> > > fix it faster.
> > > Thanks
> > 
> > Build new kernel 4.19.0.
> > 
> > Touchpad elan1200 not added when loading modules. 4.19.0 not support my
> > touchpad.
> 
> you still need to add the 3 lines described in comment 16 for kernel 4.19:
> https://bugzilla.kernel.org/show_bug.cgi?id=200663#c16
> 
> with kind regards
> marc

Dear Marc, i little missundderstood how to add(((can you add patch file for me?

You must edit the File manually:

you need line 1016, 1021 and 1022 from

https://bugzilla.kernel.org/attachment.cgi?id=277507&action=diff 

this is an older patch, most of this things are already in the 4.19 Kernal but not line 1016, 1021 and 1022, so you need to add them manually with an editor in file /drivers/pinctrl/intel/pinctrl-intel.c

in the file from kernel 4.19 it are the lines 1000, 1005, 1006

with kind regards
marc

PS: let the community know if it worked since there is nobody with GL703VD, only me with GL703GE...

I test new kernel 4.20.
Touchpad not attached in boot process. And not work after boot. Please help me.

ASUS GL703VD
DMESG:
https://vk.com/doc138079725_485985203
Config of kernel 
https://vk.com/doc138079725_485985613
Touchpad absolutely not work because not added

KERNEL 4.20.
same too in 4.19

New information.

[  140.495942] evbug: Event. Dev: input8, Type: 1, Code: 32, Value: 0
[  140.495944] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  140.895882] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458768
[  140.895887] evbug: Event. Dev: input8, Type: 1, Code: 50, Value: 1
[  140.895890] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  140.987999] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458768
[  140.988004] evbug: Event. Dev: input8, Type: 1, Code: 50, Value: 0
[  140.988007] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.175979] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458760
[  141.175984] evbug: Event. Dev: input8, Type: 1, Code: 18, Value: 1
[  141.175986] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.276073] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458760
[  141.276078] evbug: Event. Dev: input8, Type: 1, Code: 18, Value: 0
[  141.276081] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.399953] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458774
[  141.399958] evbug: Event. Dev: input8, Type: 1, Code: 31, Value: 1
[  141.399960] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.475919] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458774
[  141.475924] evbug: Event. Dev: input8, Type: 1, Code: 31, Value: 0
[  141.475927] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.864070] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458762
[  141.864075] evbug: Event. Dev: input8, Type: 1, Code: 34, Value: 1
[  141.864078] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  141.943939] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458762
[  141.943944] evbug: Event. Dev: input8, Type: 1, Code: 34, Value: 0
[  141.943947] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0
[  142.295866] evbug: Event. Dev: input8, Type: 4, Code: 4, Value: 458792
[  142.295872] evbug: Event. Dev: input8, Type: 1, Code: 28, Value: 1
[  142.295874] evbug: Event. Dev: input8, Type: 0, Code: 0, Value: 0

Touchpad attached for boot process, module in kernel, but errors

 xinput --list
⎡ Virtual core pointer                          id=2    [master pointer  (3)]
⎜   ↳ Virtual core XTEST pointer                id=4    [slave  pointer  (2)]
⎜   ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control  id=13   [slave  pointer  (2)]
⎜   ↳ Logitech USB-PS/2 Optical Mouse           id=19   [slave  pointer  (2)]
⎣ Virtual core keyboard                         id=3    [master keyboard (2)]
    ↳ Virtual core XTEST keyboard               id=5    [slave  keyboard (3)]
    ↳ Power Button                              id=6    [slave  keyboard (3)]
    ↳ Asus Wireless Radio Control               id=7    [slave  keyboard (3)]
    ↳ Video Bus                                 id=8    [slave  keyboard (3)]
    ↳ Video Bus                                 id=9    [slave  keyboard (3)]
    ↳ Power Button                              id=10   [slave  keyboard (3)]
    ↳ Sleep Button                              id=11   [slave  keyboard (3)]
    ↳ USB2.0 HD UVC WebCam: USB2.0 HD           id=12   [slave  keyboard (3)]
    ↳ ITE Tech. Inc. ITE Device(8910) System Control    id=14   [slave  keyboard (3)]
    ↳ ITE Tech. Inc. ITE Device(8910) Keyboard  id=15   [slave  keyboard (3)]
    ↳ Asus WMI hotkeys                          id=16   [slave  keyboard (3)]
    ↳ AT Translated Set 2 keyboard              id=17   [slave  keyboard (3)]
    ↳ ITE Tech. Inc. ITE Device(8910) Consumer Control  id=18   [slave  keyboard (3)]

new info
dmesg.


k
[    4.057776] usb 1-8: new full-speed USB device number 5 using xhci_hcd
[    4.069371] tulip: Linux Tulip driver version 1.1.15-NAPI (Feb 27, 2007)
[    4.081889] ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 5.1.0-k
[    4.081890] ixgbe: Copyright (c) 1999-2016 Intel Corporation.
[    4.084583] ixgb: Intel(R) PRO/10GbE Network Driver - version 1.0.135-k2-NAPI
[    4.084584] ixgb: Copyright (c) 1999-2008 Intel Corporation.
[    4.203034] usb 1-8: New USB device found, idVendor=0b05, idProduct=1869, bcdDevice= 0.03
[    4.203038] usb 1-8: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[    4.203040] usb 1-8: Product: ITE Device(8910)
[    4.203041] usb 1-8: Manufacturer: ITE Tech. Inc.
[    4.207038] input: ITE Tech. Inc. ITE Device(8910) as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input7
[    4.207195] input: ITE Tech. Inc. ITE Device(8910) Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input8
[    4.261571] input: ITE Tech. Inc. ITE Device(8910) as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input9
[    4.261780] input: ITE Tech. Inc. ITE Device(8910) as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input10
[    4.262039] input: ITE Tech. Inc. ITE Device(8910) Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input11
[    4.262243] input: ITE Tech. Inc. ITE Device(8910) System Control as /devices/pci0000:00/0000:00:14.0/usb1/1-8/1-8:1.0/0003:0B05:1869.0002/input/input12
[    4.262586] hid-generic 0003:0B05:1869.0002: input,hiddev0,hidraw1: USB HID v1.10 Keyboard [ITE Tech. Inc. ITE Device(8910)] on usb-0000:00:14.0-8/input0
[    4.306747] EXT2-fs (sda3): error: couldn't mount because of unsupported optional features (2c0)
[    4.311657] EXT4-fs (sda3): mounted filesystem with ordered data mode. Opts: (null)
[    6.097548] udevd[3463]: starting version 3.2.7
[    6.163908] udevd[3464]: starting eudev-3.2.7
[    6.299863] evbug: Connected device: input0 (Sleep Button at PNP0C0E/button/input0)
[    6.299865] evbug: Connected device: input1 (Power Button at PNP0C0C/button/input0)
[    6.301043] evbug: Connected device: input2 (Lid Switch at PNP0C0D/button/input0)
[    6.301046] evbug: Connected device: input3 (Power Button at LNXPWRBN/button/input0)
[    6.301047] evbug: Connected device: input4 (AT Translated Set 2 keyboard at isa0060/serio0/input0)
[    6.301347] input: Asus Wireless Radio Control as /devices/LNXSYSTM:00/LNXSYBUS:00/ATK4002:00/input/input13
[    6.316611] i2c-core: driver [i2c_hid] registered
[    6.320368] i801_smbus 0000:00:1f.4: SPD Write Disable is set
[    6.320404] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt
[    6.320513] i2c-dev: adapter [SMBus I801 adapter at f040] registered as minor 0
[    6.320523] i2c i2c-0: adapter [SMBus I801 adapter at f040] registered
[    6.321443] input: PC Speaker as /devices/platform/pcspkr/input/input14
[    6.321726] r8169 0000:02:00.0 enp2s0: renamed from eth0
[    6.324457] intel-lpss 0000:00:15.0: enabling device (0000 -> 0002)
[    6.326409] cryptd: max_cpu_qlen set to 1000
[    6.326843] mei_me 0000:00:16.0: enabling device (0000 -> 0002)
[    6.340969] idma64 idma64.0: Found Intel integrated DMA 64-bit
[    6.354454] evbug: Connected device: input6 (Logitech USB-PS/2 Optical Mouse at usb-0000:00:14.0-2/input0)
[    6.354457] evbug: Connected device: input7 (ITE Tech. Inc. ITE Device(8910) at usb-0000:00:14.0-8/input0)
[    6.354458] evbug: Connected device: input8 (ITE Tech. Inc. ITE Device(8910) Keyboard at usb-0000:00:14.0-8/input0)
[    6.354460] evbug: Connected device: input9 (ITE Tech. Inc. ITE Device(8910) at usb-0000:00:14.0-8/input0)
[    6.354461] evbug: Connected device: input10 (ITE Tech. Inc. ITE Device(8910) at usb-0000:00:14.0-8/input0)
[    6.354463] evbug: Connected device: input11 (ITE Tech. Inc. ITE Device(8910) Consumer Control at usb-0000:00:14.0-8/input0)
[    6.354464] evbug: Connected device: input12 (ITE Tech. Inc. ITE Device(8910) System Control at usb-0000:00:14.0-8/input0)
[    6.354624] evbug: Connected device: input13 (Asus Wireless Radio Control at asus-wireless/input0)
[    6.354670] evbug: Connected device: input14 (PC Speaker at isa0061/input0)
[    6.361906] i2c_designware i2c_designware.0: ACPI slave is not supported yet
[    6.361920] i2c_designware i2c_designware.0: Standard Mode HCNT:LCNT = 513:599
[    6.361922] i2c_designware i2c_designware.0: Fast Mode HCNT:LCNT = 105:191
[    6.361925] i2c_designware i2c_designware.0: SDA Hold Time TX:RX = 28:1
[    6.361926] i2c_designware i2c_designware.0: Bus speed: Fast Mode
[    6.361937] i2c_designware i2c_designware.0: GPIO lookup for consumer scl
[    6.361938] i2c_designware i2c_designware.0: using ACPI for GPIO lookup
[    6.361941] acpi device:78: GPIO: looking up scl-gpios
[    6.361943] acpi device:78: GPIO: looking up scl-gpio
[    6.361945] i2c_designware i2c_designware.0: using lookup tables for GPIO lookup
[    6.361946] i2c_designware i2c_designware.0: No GPIO consumer scl found
[    6.362742] i2c-dev: adapter [Synopsys DesignWare I2C adapter] registered as minor 1
[    6.362756] i2c i2c-1: adapter [Synopsys DesignWare I2C adapter] registered
[    6.363500] acpi ELAN1200:00: GPIO: looking up 0 in _CRS
[    6.363545] i2c i2c-1: client [ELAN1200:00] registered with bus id i2c-ELAN1200:00
[    6.365131] acpi ELAN1200:00: GPIO: looking up 0 in _CRS
[    6.387985] Error: Driver 'pcspkr' is already registered, aborting...
[    6.387986] media: Linux media interface: v0.10
[    6.388125] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[    6.398488] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[    6.405850] videodev: Linux video capture interface: v2.00
[    6.407975] Bluetooth: Core ver 2.22
[    6.407992] NET: Registered protocol family 31
[    6.407993] Bluetooth: HCI device and connection manager initialized

This is what helps on 

GL703GE and GL503GE:

https://www.youtube.com/watch?v=FVTvc6mxUqc&t=1s

kernel 4.20 not yet tested...

Here is a correct patch for the issue:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/intel/pinctrl-cannonlake.c?h=v4.20&id=e50d95e2ad1266f8d3fcdf0724f03dbdffd400aa

Hello Andy

i will test it as soon as i can and then report if it worked. Will this patch be in the mainline kernel?

with kind regards 
Marc Landolt

(In reply to Andy Shevchenko from comment #58)
> Here is a correct patch for the issue:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/
> drivers/pinctrl/intel/pinctrl-cannonlake.c?h=v4.
> 20&id=e50d95e2ad1266f8d3fcdf0724f03dbdffd400aa

Hello Andy

i now tested kernel 4.20, the touchpad works directly without applying a patch but the disconnection problem persists:

if you put 5 fingers or the palm on the touchpad it disconnects and i need to run sudo rmmod hid_multitouch && sudo modprobe hid_multitouch

so i still think this problem is not solved yet and this issue can not be solved. but its great that it now works without patching the kernel.

With kind regards
Marc Landolt

(In reply to Marc Landolt from comment #60)
> (In reply to Andy Shevchenko from comment #58)
> > Here is a correct patch for the issue:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/
> > drivers/pinctrl/intel/pinctrl-cannonlake.c?h=v4.
> > 20&id=e50d95e2ad1266f8d3fcdf0724f03dbdffd400aa
> 
> Hello Andy
> 
> i now tested kernel 4.20, the touchpad works directly without applying a
> patch but the disconnection problem persists:
> 
> if you put 5 fingers or the palm on the touchpad it disconnects and i need
> to run sudo rmmod hid_multitouch && sudo modprobe hid_multitouch
> 
> so i still think this problem is not solved yet and this issue can not be
> solved. but its great that it now works without patching the kernel.
> 
> With kind regards
> Marc Landolt

Not really. In my system touchpad absolutely "vegetable" - dont work. Same too as in your system - elan1200. Kabylake i7.
Can you publish your config of kernel here in attachment?

Andy, maybe in Mark Landolt system touchpad work without patch but in kabylake processor i7 not work absolutely.

Andy, see also https://bugzilla.kernel.org/show_bug.cgi?id=202145 .
Because Mark say truth, maybe in his laptop touchpad work without patch.
But in GL703VD its not work.

See https://bugzilla.kernel.org/show_bug.cgi?id=202145 and you will be have additional info.

(In reply to Andrey Ivanov from comment #63)
> Andy, see also https://bugzilla.kernel.org/show_bug.cgi?id=202145 .
> Because Mark say truth, maybe in his laptop touchpad work without patch.
> But in GL703VD its not work.

Yes, it might be another issue and this bug is apparently not a right place to discuss.

(In reply to Andy Shevchenko from comment #64)
> (In reply to Andrey Ivanov from comment #63)
> > Andy, see also https://bugzilla.kernel.org/show_bug.cgi?id=202145 .
> > Because Mark say truth, maybe in his laptop touchpad work without patch.
> > But in GL703VD its not work.
> 
> Yes, it might be another issue and this bug is apparently not a right place
> to discuss.

Did i should create new bug? Or in this line we can try fix it and test solutions?

Hello

I've installed now Ubuntu 19.04 that comes with Kernel 5.0.0. The good news is, that the fix for the GPIO is now in Mainline for ASUS GL703GE and the touchpad works out of the box.

The Bad news is, that the problem with the Touchpad loosing connection if you put 5 fingers or the palm on it persists. Also in Kernel 5.0.0.

Therefore I the Kernel Version in this Bug to 5.0.0.

With kind regards
Marc Landolt

It worked out of the box for me too, but the problem of loosing connection still happened. As I noticed the problem of my touchpad it also happen in Windows. When the Cpu usage get high the touchpad being crazy for a while (it loosing and move a little bit then loosing again) could it be the problem physically on the touchpad?

Hello

I just tried Kernel 5.2-rc4
(remember to disable secure boot)

It seems that at least in gdm the touchpad does not loose the connection anymore if I put 5 fingers or the palm on it with 5.2-rc4.

BUT I could not login to gnome-shell because 5.2-rc4 seems to brick the keyboard functionality. Not even an external attached UBS Keyboard works anymore... the keyboard does not even work in recovery mode. so this problems does not seem to be e xserver problem.

i also tested 5.1.8, there I have again the problem with the disconnect if i put 5 fingers or the palm on the touchpad but keyboard works.

So the 5 finger problem possibly it got fixed in 5.2, but keyboard does not work anymore, not even an external usb keyboard. I will test again when 5.2 is not RC anymore.

Greetings
Marc Landolt

Hi, I have Asus Fx504GE with the same touchpad model that was facing this bug. I am using 5.2-rc6 with ubuntu 19.01 and I can confirm that touchpad no longer looses connection when five fingers are placed or the palm touches it. Thanks to the devs for working on this issue.

touchpad stops working after resume from suspend.

Using kernel on Ubuntu 5.2.3-050203, multitouch trackpad behavior corrected.

However (as noted above) on resume (after suspend to ram) trackpad tracking becomes very jiterry and eventual fails with "i2c_hid_get_input Incomplete report (16/255)". Unloading and reloading module fixes it for only a short term - ie it starts working, becomes jittery again, and eventually fails again.

Created attachment 283991 [details]
attachment-10603-0.html

I confirm the behavior described in #71.  I've just rolled back to 4.19.59,
where the random freezing can be fixed by unload/reload, until this is
definitively fixed in the 5-series.

On Fri, Jul 26, 2019 at 10:37 AM <bugzilla-daemon@bugzilla.kernel.org>
wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=200663
>
> notzippy@gmail.com changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |notzippy@gmail.com
>
> --- Comment #71 from notzippy@gmail.com ---
> Using kernel on Ubuntu 5.2.3-050203, multitouch trackpad behavior
> corrected.
>
> However (as noted above) on resume (after suspend to ram) trackpad tracking
> becomes very jiterry and eventual fails with "i2c_hid_get_input Incomplete
> report (16/255)". Unloading and reloading module fixes it for only a short
> term
> - ie it starts working, becomes jittery again, and eventually fails again.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

This bug has been fixed by this commit https://github.com/torvalds/linux/commit/6cb0880f08229360c6c57416de075aa96930be78

And now the touchpad works even after resuming from suspend on my ASUS FX504GE, no more disconnection like described in earlier kernels. Thanks to everyone for working on this. For anyone's reference I am running Ubuntu 19.10 with kernel version :5.3.0-999-generic(Ubuntu mainline kernel with a daily update cycle from upstream)

The problem is *almost* fixed for me.  The touchpad now works perfectly, without freezing or generating "incomplete report"s, except for suspend/resume.  After resume, the touchpad freezes immediately and can only be revived by unloading/reloading the i2c_designware-platform module (*not* hid_multitouch).  Fortunately, this is easy to automate with systemd, but that is nonetheless a hack workaround.

(In reply to Ryan Reich from comment #74)
> The problem is *almost* fixed for me.  

In kernel 5.3.4.

(In reply to Ryan Reich from comment #75)
> (In reply to Ryan Reich from comment #74)
> > The problem is *almost* fixed for me.  
> 
> In kernel 5.3.4.

The commit required for touchpad to work fully, has been merged into kernel v5.4-rc2. So you could use that.

(In reply to Ryan Reich from comment #74)
> The problem is *almost* fixed for me.  The touchpad now works perfectly,
> without freezing or generating "incomplete report"s, except for
> suspend/resume.  After resume, the touchpad freezes immediately and can only
> be revived by unloading/reloading the i2c_designware-platform module (*not*
> hid_multitouch).  Fortunately, this is easy to automate with systemd, but
> that is nonetheless a hack workaround.

Can you test this patch: https://lore.kernel.org/linux-gpio/CAHp75VekvqHX_eUm88RQJQiU59hUoxUY=pP4MWsp6xn3os9bPg@mail.gmail.com/T/#t ?

I'm about to close this bug since nobody appear to test and confirm the state.
So I leave it in need info state for a while (day or two) and then close.

I can confirm that the problem has been fixed since kernel version v5.4 so you can close if needed.

Now closing based on comment #79, thanks!

It works but touch-to-click seems to stop working after sleep/resume. Workaround is to disable touch-to-click & then reenable it.