Bug 199463
| Summary: | Internal keyboard broken on Acer CB3-431 Chromebook (Edgar) | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Sultan Alsawaf (sultan) |
| Component: | Input Devices | Assignee: | Mika Westerberg (mika.westerberg) |
| Status: | RESOLVED PATCH_ALREADY_AVAILABLE | ||
| Severity: | normal | CC: | andy.shevchenko, mika.westerberg, william |
| Priority: | P1 | ||
| Hardware: | Intel | ||
| OS: | Linux | ||
| URL: | https://marc.info/?l=linux-gpio&m=152416908323651 | ||
| Kernel Version: | 4.16+ | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Bug Depends on: | 194945 | ||
| Bug Blocks: | |||
| Attachments: |
dmidecode
proc-interrupts-before-revert proc-interrupts-after-revert dmesg-before-revert dmesg-after-revert acpidump Patch to manually associate IRQ numbers dmesg-with-patch proc-interrupts-with-patch |
||
dmesg before revert: https://hastebin.com/wojetoxeni.vbs dmesg after revert: https://hastebin.com/sanabeduda.vbs This is another system that hardcodes Linux IRQ number:
Device (PS2K)
{
Name (_CRS, ResourceTemplate ()
{
...
Interrupt (ResourceConsumer, Edge, ActiveLow, Exclusive, ,, )
{
0x000000B6,
}
})
Can you attach output of dmidecoce as well?
Created attachment 275533 [details]
dmidecode
Created attachment 275535 [details]
proc-interrupts-before-revert
Created attachment 275537 [details]
proc-interrupts-after-revert
Created attachment 275539 [details]
dmesg-before-revert
Created attachment 275541 [details]
dmesg-after-revert
Created attachment 275543 [details]
acpidump
(In reply to Mika Westerberg from comment #2) > This is another system that hardcodes Linux IRQ number: > > Device (PS2K) > { > Name (_CRS, ResourceTemplate () > { > ... > Interrupt (ResourceConsumer, Edge, ActiveLow, > Exclusive, ,, ) > { > 0x000000B6, > } > }) > > Can you attach output of dmidecoce as well? Attached the output of dmidecode, along with the other files for historical reasons. Created attachment 275551 [details]
Patch to manually associate IRQ numbers
Can you try the attached patch if it makes any difference?
(In reply to Mika Westerberg from comment #10) > Created attachment 275551 [details] > Patch to manually associate IRQ numbers > > Can you try the attached patch if it makes any difference? The attached patch works. Great. Can you attach output of /proc/interrupts and dmesg after you have applied the patch? Also please check that the touchpad and audio codec still work. Created attachment 275553 [details]
dmesg-with-patch
Created attachment 275555 [details]
proc-interrupts-with-patch
(In reply to Mika Westerberg from comment #12) > Great. Can you attach output of /proc/interrupts and dmesg after you have > applied the patch? Done. (In reply to Mika Westerberg from comment #13) > Also please check that the touchpad and audio codec still work. Touchpad and audio codec are functional. Thanks for testing. I just sent the patch upstream. Awesome. Will this make its way into linux-stable as well? There is "Fixes:" tag so it should go if Linus W. decides so. |
Commit 03c4749dd6c7ff948a0ce59a44a1b97c015353c2 ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation"), introduced in 4.16, broke the internal keyboard on the Acer CB3-431 Chromebook. Reverting this commit fixes the internal keyboard. /proc/interrupts before revert (broken keyboard): https://hastebin.com/okobutalek.sql /proc/interrupts after revert (working keyboard): https://hastebin.com/ixuciyigat.sql acpidump: https://hastebin.com/usowawiduk.pl