Bug 199209
| Summary: | iwlwifi: 9260: crashes and hangs UI on file uploads over nfs | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | sergeidanilov (sergeidanilov) |
| Component: | network-wireless | Assignee: | DO NOT USE - assign "network-wireless-intel" component instead (linuxwifi) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | high | CC: | sergeidanilov |
| Priority: | P1 | ||
| Hardware: | Intel | ||
| OS: | Linux | ||
| Kernel Version: | 4.15.12 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: |
dmesg output
journalctl output consistent_crash_after_warning logs_without_tso crash_with_max_amsdu_len_1800.tar.xz fix candidate fix candidate |
||
|
Description
sergeidanilov
2018-03-26 05:38:18 UTC
Created attachment 274939 [details]
dmesg output
Created attachment 274941 [details]
journalctl output
my AP is Netgear R7800. For sniffing I configured it to work with no security on 80MHZ. But it crashes and hangs the same way on 160Mhz as well. Does it reproduce easily? Does the FW crash always come after the WARNING in iwl_mvm_tx_tso? I am very surprised to see this WARNING... Can you try to disable TSO? Yes, I will collect several crashes today to see whether its comes after warning. Just to confirm will it be enough to do something like ethtool -K eth0 tso off to disable tso? (In reply to sergeidanilov from comment #5) > Yes, > I will collect several crashes today to see whether its comes after warning. thanks > > Just to confirm will it be enough to do something like > ethtool -K eth0 tso off > to disable tso? Hm... on my system it doesn't work.. :( The easiest and safest is probably this: diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/9000.c b/drivers/net/wireless/intel/iwlwifi/cfg/9000.c index 83d47eb92724..7ef3572ccc26 100644 --- a/drivers/net/wireless/intel/iwlwifi/cfg/9000.c +++ b/drivers/net/wireless/intel/iwlwifi/cfg/9000.c @@ -145,7 +145,7 @@ static const struct iwl_tt_params iwl9000_tt_params = { .dccm2_len = IWL9000_DCCM2_LEN, \ .smem_offset = IWL9000_SMEM_OFFSET, \ .smem_len = IWL9000_SMEM_LEN, \ - .features = IWL_TX_CSUM_NETIF_FLAGS | NETIF_F_RXCSUM, \ + .features = NETIF_F_RXCSUM, \ .thermal_params = &iwl9000_tt_params, \ .apmg_not_supported = true, \ .mq_rx_supported = true, \ Emmanuel, Yes, crash always happens after WARNING in iwl_mvm_tx_tso. I attached three runs with consistent_crash_after_warning.tar.xz After disabling TSO its working just fine! attached logs_without_tso.tar.xz Created attachment 274955 [details]
consistent_crash_after_warning
Created attachment 274957 [details]
logs_without_tso
Can you please restore the original code and do (as root of course): echo 1800 > /sys/kernel/debug/iwlwifi/0000\:02\:00.0/iwlmvm/max_amsdu_len Thanks. Also, does this problem happen with iperf? It only under load with bfs? Created attachment 274975 [details]
crash_with_max_amsdu_len_1800.tar.xz
I tried to rep I tried to reproduce it with iperf and also with cifs and ftp. It works just fine with any of them It looks like problem narrows to nfs. it's consistent with nfs and immediately happens even with slow network speeds like 1MB/sec and small files. After I did echo 1800 > /sys/kernel/debug/iwlwifi/0000\:03\:00.0/iwlmvm/max_amsdu_len crash still happens. I collected new logs to crash_with_max_amsdu_len_1800.tar.xz Ok.... Interesting... Thanks. I am on vacation right now, but I'll try to think on what can be causing this issue. I got back to this. I could reproduce. WIP. Created attachment 275161 [details]
fix candidate
please test the patch attached.
Created attachment 275163 [details]
fix candidate
new version.
FWIW: I could check that the problem doesn't reproduce with the second version of the fix. Please confirm that it fixes the problem for you as well Waiting for your input before closing the bug. I confirm patch works. Thanks Emmanuel! |