Bug 197999

Summary:	[ipmi pci] BUG: unable to handle kernel NULL pointer dereference at (null)
Product:	Drivers	Reporter:	JianhongYin (yin-jianhong)
Component:	Other	Assignee:	drivers_other
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	bjorn, minyard
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.14.0	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	full console log console log (plain text) Proposed patch to fix the issue

Description JianhongYin 2017-11-27 01:45:48 UTC

'''
[   17.748379] ipmi device interface 
[   17.800243] hpwdt 0000:01:04.0: HPE Watchdog Timer Driver: NMI decoding initialized, allow kernel dump: ON (default = 1/ON) 
[   17.802325] hpwdt 0000:01:04.0: HPE Watchdog Timer Driver: 1.4.0, timer margin: 30 seconds (nowayout=0). 
[   17.962598] intel_rng: FWH not detected 
[   18.235369] sd 2:0:0:0: Attached scsi generic sg0 type 0 
[   18.421459] ACPI Warning: SystemIO range 0x0000000000000928-0x000000000000092F conflicts with OpRegion 0x0000000000000928-0x000000000000092F (\SGPE) (20170831/utaddress-247) 
[   18.424132] ACPI: If an ACPI driver is available for this device, you should use it instead of the native driver 
[   18.425910] lpc_ich: Resource conflict(s) found affecting gpio_ich 
[   18.511453] Loading iSCSI transport class v2.0-870. 
[   18.746569] IPMI System Interface driver. 
[   18.747299] ipmi_si dmi-ipmi-si.0: ipmi_platform: probing via SMBIOS 
[   18.748825] ipmi_si: SMBIOS: io 0xca2 regsize 1 spacing 1 irq 0 
[   18.755030] leds_ss4200: no LED devices found 
[   18.756008] ipmi_si: Adding SMBIOS-specified kcs state machine 
[   18.758204] ipmi_si IPI0001:00: ipmi_platform: probing via ACPI 
[   18.759473] ipmi_si IPI0001:00: [io  0x0ca2-0x0ca3] regsize 1 spacing 1 irq 0 
[   18.760988] ipmi_si dmi-ipmi-si.0: Removing SMBIOS-specified kcs state machine in favor of ACPI 
[   18.762651] ipmi_si: Adding ACPI-specified kcs state machine 
[   18.763917] ipmi_platform: probing via SPMI 
[   18.764930] ipmi_si: SPMI: io 0xca2 regsize 2 spacing 2 irq 0 
[   18.766145] (NULL device *): SPMI-specified kcs state machine: duplicate 
[   18.767602] ipmi_si 0000:01:04.6: probing via PCI 
[   18.768708] BUG: unable to handle kernel NULL pointer dereference at           (null) 
[   18.770121] IP:           (null) 
[   18.770670] PGD 0 P4D 0  
[   18.771227] Oops: 0010 [#1] SMP 
[   18.771875] Modules linked in: leds_ss4200(-) ipmi_si(+) auth_rpcgss scsi_transport_iscsi lpc_ich sg hpwdt ipmi_devintf hpilo floppy(+) ipmi_msghandler shpchp nfs_acl lockd i3000_edac grace sunrpc ip_tables xfs libcrc32c radeon sd_mod ata_generic pata_acpi i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm ata_piix libata tg3 drm serio_raw ptp i2c_core be2net pps_core dm_mirror dm_region_hash dm_log dm_mod 
[   18.778511] CPU: 0 PID: 567 Comm: systemd-udevd Not tainted 4.14.0 #1 
[   18.779865] Hardware name: HP ProLiant DL320 G5 , BIOS W04 06/10/2008 
[   18.781251] task: ffff880116ce1600 task.stack: ffffc900008bc000 
[   18.782506] RIP: 0010:          (null) 
[   18.783285] RSP: 0018:ffffc900008bfac0 EFLAGS: 00010246 
[   18.784414] RAX: 00000000fdbf0000 RBX: ffff880122ab2000 RCX: 0000000000000000 
[   18.785945] RDX: 0000000000000002 RSI: 0000000000000216 RDI: ffffc900008bfac8 
[   18.787447] RBP: ffffc900008bfac8 R08: 0000000000000002 R09: ffffc900008bfa5c 
[   18.788997] R10: 0000000000000026 R11: ffffea0004842ac0 R12: ffff880122ab20a0 
[   18.790531] R13: 0000000000000001 R14: 0000000000000003 R15: 0000000000000001 
[   18.792066] FS:  00007fed315068c0(0000) GS:ffff880127a00000(0000) knlGS:0000000000000000 
[   18.793784] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 
[   18.795022] CR2: 0000000000000000 CR3: 00000001221c3000 CR4: 00000000000006f0 
[   18.796538] Call Trace: 
[   18.797062]  ? ipmi_pci_probe+0x1fa/0x270 [ipmi_si] 
[   18.798109]  ? ipmi_pci_probe+0x270/0x270 [ipmi_si] 
[   18.799152]  ? local_pci_probe+0x3f/0xa0 
[   18.799944]  ? pci_assign_irq+0x27/0x120 
[   18.800776]  ? pci_device_probe+0x146/0x1b0 
[   18.801682]  ? driver_probe_device+0x2b3/0x4a0 
[   18.802622]  ? __driver_attach+0xd6/0xe0 
[   18.803450]  ? driver_probe_device+0x4a0/0x4a0 
[   18.804391]  ? bus_for_each_dev+0x68/0xb0 
[   18.805203]  ? bus_add_driver+0x41/0x260 
[   18.806032]  ? driver_register+0x5b/0xd0 
[   18.806813]  ? cleanup_ipmi_si+0x80/0x80 [ipmi_si] 
[   18.807826]  ? ipmi_si_pci_init+0x2a/0x50 [ipmi_si] 
[   18.808887]  ? init_ipmi_si+0x17f/0x1a0 [ipmi_si] 
[   18.809916]  ? cleanup_ipmi_si+0x80/0x80 [ipmi_si] 
[   18.810946]  ? do_one_initcall+0x4d/0x1a0 
[   18.811795]  ? free_unref_page_commit+0x85/0xf0 
[   18.812769]  ? _cond_resched+0x15/0x30 
[   18.813578]  ? kmem_cache_alloc_trace+0x9c/0x1a0 
[   18.814571]  ? do_init_module+0x22/0x220 
[   18.815400]  ? do_init_module+0x5a/0x220 
[   18.816247]  ? load_module+0x21b2/0x2970 
[   18.817074]  ? m_show+0x1c0/0x1c0 
[   18.817775]  ? SYSC_finit_module+0x94/0xe0 
[   18.818661]  ? entry_SYSCALL_64_fastpath+0x1a/0x7d 
[   18.819690] Code:  Bad RIP value. 
[   18.820399] RIP:           (null) RSP: ffffc900008bfac0 
[   18.821511] CR2: 0000000000000000 
[   18.822300] ---[ end trace 5427b1c5778ecedd ]--- 
[   18.823320] Kernel panic - not syncing: Fatal exception 
[   18.824483] Kernel Offset: disabled 
[   18.825258] ---[ end Kernel panic - not syncing: Fatal exception 
'''

Comment 1 JianhongYin 2017-11-27 01:48:00 UTC

Created attachment 260885 [details]
full console log

Comment 2 Bjorn Helgaas 2017-11-27 14:35:06 UTC

Created attachment 260899 [details]
console log (plain text)

Unpacking for ease of viewing.

Comment 3 Bjorn Helgaas 2017-11-27 14:49:24 UTC

Is this a regression?  If so, please set Regression=yes in the bugzilla and include the last known working version.

I doubt this is a PCI core issue, so moving to drivers/other.  I'll point Corey (the IPMI maintainer) to this.

Comment 4 Corey Minyard 2017-11-30 17:24:10 UTC

Created attachment 260955 [details]
Proposed patch to fix the issue

I realized I had a kernel.org bugzilla account.  I believe this will fix the issue.

Comment 5 Corey Minyard 2017-12-12 13:00:22 UTC

Patch is in the mainstream kernel, but I don't have the rights to resolve this.

Comment 6 Bjorn Helgaas 2017-12-12 15:01:57 UTC

Should be resolved by http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1ac8aa8d0568, which is expected to appear in v4.15-rc4.