Bug 192051

Summary: [bisected] No hibernation/suspend/shutdown after commit 7279b238badec09efd0545293e64c21feee97f73
Product: Power Management Reporter: no.spam.to.me
Component: Hibernation/SuspendAssignee: Tomas Winkler (tomasw)
Status: CLOSED CODE_FIX    
Severity: high CC: pmenzel+bugzilla.kernel.org, tomasw, yu.c.chen
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: >v4.9 Subsystem:
Regression: Yes Bisected commit-id:
Attachments: dmesg of latest running kernel

Description no.spam.to.me 2017-01-06 23:22:12 UTC 
Hi!

After bisecting the kernel I found that this commit:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7279b238badec09efd0545293e64c21feee97f73

breaks "echo devices > /sys/power/pm_test" ... even shutdown does not work.
Comment 1 no.spam.to.me 2017-01-07 09:33:57 UTC 
Created attachment 250701 [details]
dmesg of latest running kernel
Comment 2 no.spam.to.me 2017-01-07 10:05:35 UTC 
Reverting 7279b238badec09efd0545293e64c21feee97f73 and 	3c17b6372e44c369649691f8c90822bb3f8ea3e0 (cause I didn't want to fiddle merging bus-fixup.c) also solves the Problem.
Comment 3 Chen Yu 2017-01-09 02:29:10 UTC 
Thanks for your report, will contact Alexander for support.
Comment 4 Tomas Winkler 2017-01-09 07:31:42 UTC 
Currently we can state this is happening on Calpella and Ibex Peak, we need to limit this new feature to only post Skylake devices. 
You can reassign the bug to me. 
Thanks
Tomas
Comment 5 Tomas Winkler 2017-01-09 14:29:19 UTC 
This patch was merged only to v4.10 rc cycles so update the affected kernel version
Comment 6 Tomas Winkler 2017-01-09 20:14:27 UTC 
A fix was posted here: https://lkml.org/lkml/2017/1/9/414
Comment 7 Paul Menzel 2017-01-11 08:50:34 UTC 
Note, this also happens on a Dell XPS13 (9360) with a Kaby Lake device.

[1] https://lkml.org/lkml/2017/1/10/448
Comment 9 Paul Menzel 2017-01-11 09:18:44 UTC 
> mei: bus: enable OS version only for SPT and newer
>
> Sending OS version for support of TPM2_ChangeEPS() is required only
> for SPT FW (HMB version 2.0) and newer.
>
> On older platforms the command should be just ignored by the firmware
> but some older platforms misbehave so it's safer to send the command
> only if required.

What’s SPT?
Comment 10 Paul Menzel 2017-01-18 10:01:26 UTC 
Just a closing note, that the issue on the Dell XPS13 (9360) is a different one.
See the thread *Regression on Dell XPS13* on the Linux kernel mailing list [1].


[1] https://lkml.org/lkml/2017/1/17/609
Comment 11 no.spam.to.me 2017-01-18 10:54:00 UTC 
Patch is included in Linus' 4.10-RC4, I compiled it yesterday and it works for me.
I think Paul will file a new bug or something, so I mark this closed.
Kudos to all!