Bug 183681

Summary:	bnx2 firmware mismatch
Product:	Other	Reporter:	Alexandru N. Barloiu (axl)
Component:	Other	Assignee:	other_other
Status:	NEW ---
Severity:	low	CC:	szg00000
Priority:	P1
Hardware:	Intel
OS:	Linux
Kernel Version:	4.8.4-gentoo	Subsystem:
Regression:	No	Bisected commit-id:

Description Alexandru N. Barloiu 2016-10-26 19:27:43 UTC

Not very sure which category this should go into, but here it goes. I was trying to build a single file kernel (without modules and initrd) that included support for bnx2, which on my machine doesn't work without firmware files. 

however firmware/Makefile specifies:

fw-shipped-$(CONFIG_BNX2) += bnx2/bnx2-mips-09-6.2.1a.fw \
			     bnx2/bnx2-rv2p-09-6.0.17.fw \
			     bnx2/bnx2-rv2p-09ax-6.0.17.fw \
			     bnx2/bnx2-mips-06-6.2.1.fw \
			     bnx2/bnx2-rv2p-06-6.0.15.fw

and drivers/net/ethernet/broadcom/bnx2.c specifies:

#define FW_MIPS_FILE_06         "bnx2/bnx2-mips-06-6.2.3.fw"
#define FW_RV2P_FILE_06         "bnx2/bnx2-rv2p-06-6.0.15.fw"
#define FW_MIPS_FILE_09         "bnx2/bnx2-mips-09-6.2.1b.fw"
#define FW_RV2P_FILE_09_Ax      "bnx2/bnx2-rv2p-09ax-6.0.17.fw"
#define FW_RV2P_FILE_09         "bnx2/bnx2-rv2p-09-6.0.17.fw"

Comment 1 Alexandru N. Barloiu 2016-12-04 02:02:23 UTC

we are now at 4.8.12. not sure if I am doing something wrong, or it a simple thing someone forgot to change in both places. shouldn't these 2 things match? the one in the driver.c and firmware makefile?

bnx2-mips-09-6.2.1a.fw is actually bnx2-mips-09-6.2.1b.fw and bnx2/bnx2-mips-06-6.2.1.fw is actually bnx2/bnx2-mips-06-6.2.3.fw. 

it only affects a system when you try to include firmware in kernel. IN KERNEL. not initrd. if you build it as a module, the firmware will load prolly in initrd. and it will use a file from /lib/firmware. but if you try to built it into the kernel, in firmware/bnx2 there are only old ihex files. 

is this intentional?