Bug 16544
| Summary: | drivers/power/olpc_battery.c:387: error: unknown field ‘owner’ specified in initializer | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | jd1008 |
| Component: | Other | Assignee: | Guenter Roeck (linux) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | blocking | CC: | linux |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.35-git6 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: | kernel configuration file | ||
Same error in 2.6.35-git7: ..... CC drivers/power/olpc_battery.o CC [M] drivers/net/e1000e/ethtool.o drivers/power/olpc_battery.c:387: error: unknown field ‘owner’ specified in initializer drivers/power/olpc_battery.c:387: warning: excess elements in struct initializer drivers/power/olpc_battery.c:387: warning: (near initialization for ‘olpc_bat_eeprom.attr’) CC [M] drivers/net/enic/enic_res.o make[2]: *** [drivers/power/olpc_battery.o] Error 1 used same config file as above. Ditto in git8: CC drivers/power/olpc_battery.o drivers/power/olpc_battery.c:387: error: unknown field ‘owner’ specified in initializer drivers/power/olpc_battery.c:387: warning: excess elements in struct initializer drivers/power/olpc_battery.c:387: warning: (near initialization for ‘olpc_bat_eeprom.attr’) make[1]: *** [drivers/power/olpc_battery.o] Error 1 make: *** [drivers/power/olpc_battery.o] Error 2 Folks, I am wondering why someone deleted struct module *owner; from struct attribute in file include/linux/sysfs.h This is what is breaking the compilation. If it was removed for good reason, then why was the reference to it also not removed? The field was deleted because it is no longer used. As for why I didn't catch this one - sorry, I am only human. Patch submitted. Patch integrated. Someone with permissions might want to close this bug. |
Created attachment 27380 [details] kernel configuration file Tried to build 2.6.35-git6 Errors stopped the build. . . . CC drivers/power/power_supply_leds.o CC drivers/power/olpc_battery.o CC net/wireless/wext-priv.o CC [M] net/sunrpc/auth_gss/gss_krb5_keys.o drivers/power/olpc_battery.c:387: error: unknown field ‘owner’ specified in initializer drivers/power/olpc_battery.c:387: warning: excess elements in struct initializer drivers/power/olpc_battery.c:387: warning: (near initialization for ‘olpc_bat_eeprom.attr’) make[2]: *** [drivers/power/olpc_battery.o] Error 1 make[1]: *** [drivers/power] Error 2 make[1]: *** Waiting for unfinished jobs.... .config attached