Bug 16434
Summary: | Crash during boot - swap - ssd trim - MV88SX6081 8-port SATA II PCI-X Intel SSD | ||
---|---|---|---|
Product: | IO/Storage | Reporter: | jodds |
Component: | Serial ATA | Assignee: | Jeff Garzik (jgarzik) |
Status: | RESOLVED OBSOLETE | ||
Severity: | normal | CC: | akpm, alan, mlord |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.33 - 2.6.35 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: |
trace_and_system_info
Fix sata_mv to handle DSM/TRIM commands Additional patch for 2.6.35 kernels |
Description
jodds
2010-07-21 18:38:54 UTC
Created attachment 27188 [details]
trace_and_system_info
Recategorised to ata. sata_mv is crashing. Mmm.. two issues in one: 1. sata_mv should not crash when something BAD happens, and.. 2. Need to force BM-DMA mode for TRIM commands, rather than EDMA mode. I'm traveling on holiday right now, and cannot do much for the time being. Cheers Created attachment 27517 [details]
Fix sata_mv to handle DSM/TRIM commands
Posted to linux-ide today by me.
Created attachment 27520 [details]
Additional patch for 2.6.35 kernels
The first patch here is sufficient for 2.6.34 kernels.
But in 2.6.35, a new BUG_ON() line in libata-sff.c breaks sata_mv completely.
So here is a patch to get rid of that overly aggressive BUG_ON() line, so that DSM/TRIM and ATAPI commands can work again with the chipsets controlled by the sata_mv driver.
Do you have access to necessary hardware to do all the tests that you would like to do? Would access to a Supermicro AOC-SATA2-MV8 PCI-X controller be helpful to you (assuming that you do not have access to one already), or is any controller with the given chipset good enough? I have samples here of all of the chips known to sata_mv, except for the kirkwood (appliance/SOC) variant. Usually it's good enough to have "any controller" with the given chipset. But there are many different Marvell chips that sata_mv knows about. I have tested the patches with the latest, "generation IIe" 7042 chip, and with the earlier "generation II" 6081 chip. Another user has verified them with the very similar kirkwood chip. The earlier 5xxx chips probably don't work at all with TRIM or ATAPI --> no bus-master DMA support on them (Marvell chips normally use a fancier DMA mode known as "EDMA" instead of old-school BM-DMA). Cheers Note: your Supermicro AOC-SATA2-MV8 PCI-X board very likely has the 6081 chip on it. Cheers |