|Summary:||Regression since commit 0b28bac5aef|
|Product:||Drivers||Reporter:||Larry Finger (Larry.Finger)|
|Component:||Serial||Assignee:||Russell King (rmk)|
|Severity:||high||CC:||dmitry.torokhov, rjw, wl|
|Kernel Version:||2.6.35-rc4, 2.6.35-rc5||Tree:||Mainline|
|Bug Depends on:|
Description Larry Finger 2010-07-14 23:53:11 UTC
Since the commit in the title, a kernel build on an HP Mini 110 Netbook no longer has keyboard input. The main difference is that if CONFIG_SERIO_I8042=y, the keyboard works. The faulty commit was located by bisection and has been verified by reverting the patch. Further investigation shows that the faulty hunk is diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index 3bfe8fa..256b9e9 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -22,7 +22,7 @@ config SERIO_I8042 tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86 default y depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \ - (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN + (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !X86_MRST help i8042 is the chip over which the standard AT keyboard and PS/2 mouse are connected to the computer. If you use these devices, Reverting this one hunk alone results in a working system. Obviously, this Netbook does not have X86_MRST set.
Comment 1 Larry Finger 2010-07-15 00:45:49 UTC
Clarification: CONFIG_X86_MRST=y in .config. I tripped over the double negative.
Comment 2 Werner Lemberg 2010-07-15 05:24:09 UTC
The same is true for my Dell Inspiron 6400 laptop; I can press the power button to initiate a clean shutdown (obviously, this key is not handled by the normal keyboard driver), but except this button no other input (including the mouse) works.
Comment 3 Rafael J. Wysocki 2010-07-15 08:56:48 UTC
First-Bad-Commit : 0b28bac5aef7bd1ab213723df031e61db9ff151a commit 0b28bac5aef7bd1ab213723df031e61db9ff151a Author: Randy Dunlap <email@example.com> Date: Thu Jun 17 22:31:17 2010 -0700 Input: fixup X86_MRST selects Signed-off-by: Randy Dunlap <firstname.lastname@example.org> Cc: Jacob Pan <email@example.com> Signed-off-by: Dmitry Torokhov <firstname.lastname@example.org>
Comment 4 Larry Finger 2010-07-15 15:43:02 UTC
A workaround is to disable Moorestown support. When you do this, CONFIG_SERIO_I8042 is once again selected and the box works. According to Dmitri, "HPA posted a patch series that should fix the problem".
Comment 5 Dmitry Torokhov 2010-07-21 21:55:28 UTC
Should be fixed by series of commits ending with 5cdfa1c3bbabb809ef3134f741a63e13373a8cad
Comment 6 Larry Finger 2010-07-21 22:07:45 UTC