Bug 162

Summary: compile failure on drivers/media/video/bttv-cards.c
Product: Drivers Reporter: John Kim (john)
Component: Video(Other)Assignee: Bugme Janitors Team (bugme-janitors)
Status: CLOSED CODE_FIX    
Severity: normal    
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: Subsystem:
Regression: --- Bisected commit-id:

Description John Kim 2002-12-11 10:48:46 UTC 
Exact Kernel version:  2.5.51
Distribution:  Gentoo 1.4rc1
Hardware Environment:  Abit KG7-RAID, AMD tbird, 512MB, Geforce3
Software Environment:  gcc 3.2.1, glibc 2.3.1
Problem Description:

Compiling bttv into the kernel breaks.  I think this is slightly different from
#93 in that #93 is compiling as module.  It appears patche attached for bug #93
has been merged but only fixes compile as module.

  gcc -Wp,-MD,drivers/media/video/.bttv-cards.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigra
phs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=i686 -Iarch/i386/mach-gener
ic -nostdinc -iwithprefix include    -DKBUILD_BASENAME=bttv_cards
-DKBUILD_MODNAME=bttv   -c -o drivers/media/
video/bttv-cards.o drivers/media/video/bttv-cards.c
drivers/media/video/bttv-cards.c: In function `miro_pinnacle_gpio':
drivers/media/video/bttv-cards.c:1742: `AUDC_CONFIG_PINNACLE' undeclared (first
use in this function)
drivers/media/video/bttv-cards.c:1742: (Each undeclared identifier is reported
only once
drivers/media/video/bttv-cards.c:1742: for each function it appears in.)
make[3]: *** [drivers/media/video/bttv-cards.o] Error 1
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make: *** [drivers] Error 2


Steps to reproduce:

CONFIG_VIDEO_DEV=y
CONFIG_VIDEO_BT848=y
Comment 1 Dave Jones 2002-12-11 12:12:26 UTC 
looks like it's missing a #include "audiochip.h"
Comment 2 Dave Jones 2002-12-11 12:14:16 UTC 
Oops, and also..

http://bytesex.org/patches/2.5/20_tda9887-2.5.51.diff

(likely various other patches in that dir too fwiw)
Comment 3 Dave Jones 2002-12-13 16:44:53 UTC 
Close when merged with mainline
Comment 4 Steven Barnhart 2002-12-29 09:12:39 UTC 
Patch sent to Alan and cc'd to Linus. Now to wait (and hope) it is applied to
get rid of this bug that has existed for three versions.
Comment 5 John Kim 2003-01-09 14:56:43 UTC 
This has been fixed in 2.5.55.