Bug 16144

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Sun, 6 Jun 2010 21:41:36 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=16144
> 
>            Summary: OMAP video driver cannot build
>            Product: Drivers
>            Version: 2.5
>     Kernel Version: 2.6.33-rc4 to 2.6.35-rc2
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: blocking
>           Priority: P1
>          Component: Video(Other)
>         AssignedTo: drivers_video-other@kernel-bugs.osdl.org
>         ReportedBy: luke-jr+linuxbugs@utopios.org
>         Regression: Yes
> 
> 
> CC      drivers/video/omap/rfbi.o                                             
> drivers/video/omap/rfbi.c: In function 'rfbi_get_clocks':                     
> drivers/video/omap/rfbi.c:86: error: 'dispc' undeclared (first use in this
> function)
> drivers/video/omap/rfbi.c:86: error: (Each undeclared identifier is reported
> only once
> drivers/video/omap/rfbi.c:86: error: for each function it appears in.)        
> make[1]: *** [drivers/video/omap/rfbi.o] Error 1                              
> make: *** [drivers/video/omap/rfbi.o] Error 2                                 
> 
> The 'dispc' referred to herein is and has always been defined in
> drivers/video/omap/dispc.c as an anonymous struct.
> 
> Broken in...
> commit f778a12dd33200513596a0d4d3ba4d5f09e79c09
> Author: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> Date:   Wed Dec 16 13:18:07 2009 +0200
> 
>     OMAP: OMAPFB: fix clk_get for RFBI
> 
>     omapfb platform device was still used to get clocks inside rfbi.c
> 
>     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
>     Tested-by: Sergey Lapin <slapin@ossfans.org>
> 

hm, dispc is static in drivers/video/omap/dispc.c.  I don't see how
this change can have passed Tomi or Sergey's testing.

Reply-To: tomi.valkeinen@nokia.com

On Thu, 2010-06-10 at 23:11 +0200, ext Andrew Morton wrote:

> > Broken in...
> > commit f778a12dd33200513596a0d4d3ba4d5f09e79c09
> > Author: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > Date:   Wed Dec 16 13:18:07 2009 +0200
> > 
> >     OMAP: OMAPFB: fix clk_get for RFBI
> > 
> >     omapfb platform device was still used to get clocks inside rfbi.c
> > 
> >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> >     Tested-by: Sergey Lapin <slapin@ossfans.org>
> > 
> 
> hm, dispc is static in drivers/video/omap/dispc.c.  I don't see how
> this change can have passed Tomi or Sergey's testing.

Me neither. Although I guess it's because no config uses rfbi.c.

I have a patch for it and will send a pull request shortly.

 Tomi