Bug 16075

Summary:	Dell Studio 1555 eject key does not work
Product:	Drivers	Reporter:	Islam Motab (pharon)
Component:	Platform	Assignee:	acpi_platform-drivers (acpi_platform-drivers)
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	akpm, alan, matiasjrossi, mjg59-kernel, rjw
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.34	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	Fallback to buffer_entry 2 in case 1 is 0x0

Description Islam Motab 2010-05-29 10:40:08 UTC

Pressing the eject key on my Dell Studio 1555 does not work and dmesg produces this message : dell-wmi: Unknown key 0 pressed

Comment 1 Islam Motab 2010-05-30 06:15:20 UTC

I've added a debugging printk in dell-wmi after line 222 like this :

printk(KERN_INFO "dell:wmi 0x%x , 0x%x \n", buffer_entry[1], buffer_entry[2]);

Dmesg now shows :

dell:wmi 0x0 , 0xe009 
dell-wmi: Unknown key 0 pressed

So for some reason buffer_entry[1] is used although it is empty.

Comment 2 Islam Motab 2010-05-30 06:17:53 UTC

Created attachment 26579 [details]
Fallback to buffer_entry 2 in case 1 is 0x0

The attached patch fixes the eject key for me falling back to buffer_entry[2] in case buffer_entry[1] is 0x0 . 

I suspect it might be better to fix the "dell_new_hk_type" logic though.

Comment 3 Islam Motab 2010-05-30 06:44:29 UTC

I think this bug is better placed in ACPI - platform drivers but I don't have permission to do so. Can someone with the correct privileges do that please ? Thanks :)

Comment 4 Andrew Morton 2010-06-02 20:15:34 UTC

Please don't send patches via bugzilla - it causes lots of problems with
our usual patch management and review processes.

Please send this patch via email as per Documentation/SubmittingPatches. 
Suitable recipients may be found via scripts/get_maintainer.pl.  Please
also cc myself on the email.

Thanks.