Bug 15951

Caused by:

commit 9630bdd9b15d2f489c646d8bc04b60e53eb5ec78
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Wed Feb 17 23:41:07 2010 +0100

    ACPI: Use GPE reference counting to support shared GPEs

    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

First-Bad-Commit : 9630bdd9b15d2f489c646d8bc04b60e53eb5ec78

I wonder if this patch helps: https://bugzilla.kernel.org/attachment.cgi?id=26362

No it didn't help.
I have applied that patch on top of previous patches (and 2.6.34-rc5). Is that correct or should I test with the clean linus tree with your patch?

$ git diff v2.6.34-rc5..
diff --git a/drivers/acpi/acpica/evgpeblk.c b/drivers/acpi/acpica/evgpeblk.c       
index fef7219..b6e1e0c 100644                                                      
--- a/drivers/acpi/acpica/evgpeblk.c                                               
+++ b/drivers/acpi/acpica/evgpeblk.c                                               
@@ -367,7 +367,7 @@ acpi_ev_match_prw_and_gpe(acpi_handle obj_handle,              
        union acpi_operand_object *pkg_desc;                                       
        union acpi_operand_object *obj_desc;                                       
        u32 gpe_number;                                                            
-       acpi_status status;                                                        
diff --git a/drivers/acpi/acpica/evgpeblk.c b/drivers/acpi/acpica/evgpeblk.c
index fef7219..b6e1e0c 100644
--- a/drivers/acpi/acpica/evgpeblk.c
+++ b/drivers/acpi/acpica/evgpeblk.c
@@ -367,7 +367,7 @@ acpi_ev_match_prw_and_gpe(acpi_handle obj_handle,
        union acpi_operand_object *pkg_desc;
        union acpi_operand_object *obj_desc;
        u32 gpe_number;
-       acpi_status status;
diff --git a/drivers/acpi/acpica/evgpeblk.c b/drivers/acpi/acpica/evgpeblk.c
index fef7219..b6e1e0c 100644
--- a/drivers/acpi/acpica/evgpeblk.c
+++ b/drivers/acpi/acpica/evgpeblk.c
@@ -367,7 +367,7 @@ acpi_ev_match_prw_and_gpe(acpi_handle obj_handle,
        union acpi_operand_object *pkg_desc;
        union acpi_operand_object *obj_desc;
        u32 gpe_number;
-       acpi_status status;
+       acpi_status status = AE_OK;

        ACPI_FUNCTION_TRACE(ev_match_prw_and_gpe);

@@ -447,12 +447,13 @@ acpi_ev_match_prw_and_gpe(acpi_handle obj_handle,
                                                        gpe_block->
                                                        block_base_number];

+               status = acpi_ev_disable_gpe(gpe_event_info);
                gpe_event_info->flags |= ACPI_GPE_CAN_WAKE;
        }

       cleanup:
        acpi_ut_remove_reference(pkg_desc);
-       return_ACPI_STATUS(AE_OK);
+       return_ACPI_STATUS(status);
 }

 /*******************************************************************************
diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c
index 4aaf249..2192fcd 100644
--- a/drivers/acpi/system.c
+++ b/drivers/acpi/system.c
@@ -389,10 +389,10 @@ static ssize_t counter_set(struct kobject *kobj,
        if (index < num_gpes) {
                if (!strcmp(buf, "disable\n") &&
                                (status & ACPI_EVENT_FLAG_ENABLED))
-                       result = acpi_set_gpe(handle, index, ACPI_GPE_DISABLE);
+                       result = acpi_disable_gpe(handle, index, ACPI_GPE_TYPE_RUNTIME);
                else if (!strcmp(buf, "enable\n") &&
                                !(status & ACPI_EVENT_FLAG_ENABLED))
-                       result = acpi_set_gpe(handle, index, ACPI_GPE_ENABLE);
+                       result = acpi_enable_gpe(handle, index, ACPI_GPE_TYPE_RUNTIME);
                else if (!strcmp(buf, "clear\n") &&
                                (status & ACPI_EVENT_FLAG_SET))
                        result = acpi_clear_gpe(handle, index, ACPI_NOT_ISR);
diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c
index 4b9d339..a0f4859 100644
--- a/drivers/acpi/wakeup.c
+++ b/drivers/acpi/wakeup.c
@@ -113,8 +113,9 @@ int __init acpi_wakeup_device_init(void)
                if (!dev->wakeup.flags.always_enabled ||
                    dev->wakeup.state.enabled)
                        continue;
-               acpi_enable_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number,
+               /*acpi_enable_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number,
                                ACPI_GPE_TYPE_WAKE);
+                */
                dev->wakeup.state.enabled = 1;
        }
        mutex_unlock(&acpi_device_lock);

Created attachment 26533 [details]
ACPI / ACPICA: Fix problems related to GPE reference counting

Please test the attached patch (on top of 2.6.34 final).

Unfortunately, I have to disappoint you again. This doesn't help as well.
I have tried the patch from comment 4 on the clean .34 kernel and the laptop/system behaves the very same way.

Rafael,
is this problem also fixed by your GPE ref fixup patch set?

Possibly, but not surely.  I think that further debugging should be done on top of that patchset, though.

get it.

Michal,
please apply the patch set
https://patchwork.kernel.org/patch/104903/
https://patchwork.kernel.org/patch/104912/
https://patchwork.kernel.org/patch/104909/
https://patchwork.kernel.org/patch/104911/
https://patchwork.kernel.org/patch/104910/
on top of the latest upstream kernel and see if it helps.

$ git shortlog v2.6.35-rc2..
Rafael J. Wysocki (5):
      ACPI / ACPICA: Use helper function for computing GPE masks
      ACPI / ACPICA: Fix low-level GPE manipulation code
      ACPI / ACPICA: Avoid writing full enable masks to GPE registers
      ACPI / ACPICA: Fix GPE initialization
      ACPI / ACPICA: Fix sysfs GPE interface

And unfortunately no success again.

Created attachment 26728 [details]
Debug patch

Well, thanks.

Now, we can do some more serious debugging without the need to backport changes, though, so please apply this patch on top of the previous patchset and attach dmesg output from a fresh boot.

Created attachment 26766 [details]
dmesg from boot with the debug patch

Created attachment 26782 [details]
ACPI: Avoid enabling GPEs for wakeup early

Well, everything seems to be correct.

But, let's try this.  Please apply the attached patch and see if the problem is
still there.  Either way, please attach a dmesg output from a fresh boot.

Ah, I forgot to say, please apply the patch from comment #12 on top of the
previous patches.

Created attachment 26803 [details]
ACPI: Do not enable button GPE

In fact I think the patch from comment #12 won't help, so please apply this one (on top of the previous patches) instead and see if the problem is still there.  Please attach a dmesg output from a fresh boot in either case.

Created attachment 26805 [details]
ACPICA: Debug disabling of GPEs

Also, regardless of the result of the previous test, please apply the attached
patch (on top of the previous ones), run "echo core > /sys/power/pm_test"
and "poweroff -u".  Then, please generate a dmesg output and attach it here.

In addition to that, please verify that acpi_power_off_prepare() is executed
on your box during poweroff.

(In reply to comment #14)
> Created an attachment (id=26803) [details]
> ACPI: Do not enable button GPE
> 
> In fact I think the patch from comment #12 won't help, so please apply this
> one
> (on top of the previous patches) instead and see if the problem is still
> there.
>  Please attach a dmesg output from a fresh boot in either case.

It didn't help. I will upload both dmesgs (1st boot and boot after poweroff - they both look pretty much the same) shortly.

Created attachment 26807 [details]
1st boot with the patch from comment 14

Created attachment 26808 [details]
boot ofter power off with the patch from comment 14

(In reply to comment #15)
> Created an attachment (id=26805) [details]
> ACPICA: Debug disabling of GPEs
> 
> Also, regardless of the result of the previous test, please apply the
> attached
> patch (on top of the previous ones), run "echo core > /sys/power/pm_test"
> and "poweroff -u".  

are you sure about -u parameter. My poweroff doesn't have such a parameter

> 
> In addition to that, please verify that acpi_power_off_prepare() is executed
> on your box during poweroff.

How do I do that?

Created attachment 26809 [details]
ACPICA: Avoid updating GPE wakeup masks

Since the patch from comment #14 didn't help, please try this one (and attach
dmesg output).

(In reply to comment #19)
> (In reply to comment #15)
> > Created an attachment (id=26805) [details] [details]
> > ACPICA: Debug disabling of GPEs
> > 
> > Also, regardless of the result of the previous test, please apply the
> attached
> > patch (on top of the previous ones), run "echo core > /sys/power/pm_test"
> > and "poweroff -u".  
> 
> are you sure about -u parameter. My poweroff doesn't have such a parameter

The parameter is correct, but the command is not. :-)

I meant "powersave", sorry.

> > In addition to that, please verify that acpi_power_off_prepare() is
> executed
> > on your box during poweroff.
> 
> How do I do that?

You can add something like "while (1) cpu_relax();" at the end of it and see
if the poweroff sequence stops instead of powering off the system.

Created attachment 26810 [details]
ACPI: Do not enable wakeup GPEs on poweroff

Also, please check if the problem is still there with this patch applied.

Created attachment 26820 [details]
ACPI / PM: Do not enable wakeup GPEs permanently

OK, I think I've found the issue.  It is described in the changelog of this
patch.

Please test it (on top of the patches from comment #8, the debug patch from
comment #10 and the one from comment #15) and report back.

In case it doesn't help, please attach full dmesg output from a suspend/resume
cycle.

OK, so recap what should be tested:
1) "echo core > /sys/power/pm_test
   powersave -u (btw. my debian box doesn't have this - what is the equivalent? - simple suspend to ram?)

2) check whether acpi_power_off_prepare is called during poweroff
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 3fb4bde..0fab34e 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -685,6 +685,8 @@ static void acpi_power_off_prepare(void)
        /* Prepare to power off the system */
        acpi_sleep_prepare(ACPI_STATE_S5);
        acpi_disable_all_gpes();
+
+       while (1) cpu_relax();
 }

 static void acpi_power_off(void)

3) try patch from comment 22

4) try patch from comment 23 if 3) fails

Is that correct?

Please try the patch from comment #23 first, because that's what I think should
be applied (provided that it works).

If it doesn't work, please try the patches from comment #22 and from comment #20
both at the same time (on top of comment #8, comment #10, and comment #15).

Failing the above, please run the "echo core > ..." test with the patches from
comment #8, comment #10, comment #15, comment #20, and comment #22 applied and
attach the output of dmesg.

[On openSUSE "powersave -u" suspends to RAM, but it additionally executes some
user space suspend scripts around that.]

(In reply to comment #26)
> Please try the patch from comment #23 first, because that's what I think
> should
> be applied (provided that it works).

Bingo! It seems to be working.

$ git shortlog v2.6.35-rc2..
Michal Hocko (2):
      Debugging patch from bko
      acpi: acpica debug disabling of gpes

Rafael J. Wysocki (6):
      ACPI / ACPICA: Use helper function for computing GPE masks
      ACPI / ACPICA: Fix low-level GPE manipulation code
      ACPI / ACPICA: Avoid writing full enable masks to GPE registers
      ACPI / ACPICA: Fix GPE initialization
      ACPI / ACPICA: Fix sysfs GPE interface
      ACPI / PM: Do not enable GPEs for system wakeup in advance

Do you need boot dmesg?

(In reply to comment #27)
> (In reply to comment #26)
> > Please try the patch from comment #23 first, because that's what I think
> > should be applied (provided that it works).
> 
> Bingo! It seems to be working.

Good.

> $ git shortlog v2.6.35-rc2..
> Michal Hocko (2):
>       Debugging patch from bko
>       acpi: acpica debug disabling of gpes
> 
> Rafael J. Wysocki (6):
>       ACPI / ACPICA: Use helper function for computing GPE masks
>       ACPI / ACPICA: Fix low-level GPE manipulation code
>       ACPI / ACPICA: Avoid writing full enable masks to GPE registers
>       ACPI / ACPICA: Fix GPE initialization
>       ACPI / ACPICA: Fix sysfs GPE interface
>       ACPI / PM: Do not enable GPEs for system wakeup in advance
> 
> Do you need boot dmesg?

No, thanks.

Patch : https://patchwork.kernel.org/patch/106701/

patch is now applied to acpi tree

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=cb1cb1780f2025a7d612de09131bf6530f80fb1a