Bug 156561

Summary:	[oxygen] typo in ac97_fp_rec_volume_put
Product:	Drivers	Reporter:	Tom Yan (tom.ty89)
Component:	Sound(ALSA)	Assignee:	Jaroslav Kysela (perex)
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	clemens, teodor98sz, tiwai, v10lator
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.7	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	[oxygen] Fix typo in ac97_fp_rec_volume_put

Description Tom Yan 2016-09-12 11:24:27 UTC

value[0] here should be value[1]:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c#n733

Compare ac97_fp_rec_volume_put with ac97_fp_rec_volume_get:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c?h=v4.7#n722

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c?h=v4.7#n708

Comment 1 Teodor Szente 2017-01-01 19:52:28 UTC

Created attachment 249541 [details]
[oxygen] Fix typo in ac97_fp_rec_volume_put

Comment 2 Thomas 2024-01-12 10:53:24 UTC

This patch fixes an audio distortion issue on modern (currently 6.6.8) kernels for me. Thanks a lot.

Comment 3 Takashi Iwai 2024-01-12 11:12:09 UTC

This one was completely overlooked.  Now I submitted and merged the trivial fix.