Bug 15626

Created attachment 25695 [details]
lspci -t

Created attachment 25696 [details]
lspci -xxxx

Created attachment 25697 [details]
/proc/interrupts without kms

Created attachment 25698 [details]
/proc/interrupts with kms

Can you attach the output of lspci -vnn and /proc/interrupts

Created attachment 25712 [details]
lspci -vnn

Created attachment 25715 [details]
check if gfx msi is enabled

This patch should fix it, but requires you have the patch referenced below applied first (should already be in Linus' tree) as it's really the same issue.

http://marc.info/?l=dri-devel&m=126926011226719&w=2

Created attachment 25716 [details]
updated patch

whoops, missed an id in the last patch.  Same conditions apply.

I tested out the patch, but I am still experiencing the same problem.  

I added a printk to line 2503 of dirvers/pci/quirks.c to check the value of nb_cntl and its value is 0x78f.  I am not sure what this value means, but it does cause the if statement immediately following to not be executed, so I don't think MSI is being disabled.

Created attachment 25757 [details]
fix

Does this patch do the trick?

(In reply to comment #10)
> Created an attachment (id=25757) [details]
> fix
> 
> Does this patch do the trick?

This patch fixes the problem.
Thank you!

Alex, please ensure that this patch has Cc:<stable@kernel.org> in the changelog so that we don't forget to backport it.

Created attachment 25803 [details]
fix

Updated patch with stable cc.

Alex - disabling MSI for only this device (and it's subordinate buses via the existing patches) is insufficient, right?

If sufficient, this may be a better solution than disabling MSI globally:

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 81d19d5..603cd97 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2215,6 +2215,16 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA,
 			PCI_DEVICE_ID_NVIDIA_NVENET_15,
 			nvenet_msi_disable);
 
+/* The Radeon Xpress 200M/RS480 has problems with delivering MSI interrupts
+ * correctly, causing crashing; disable MSI for this device.
+ */
+static void __devinit radeon_msi_disable(struct pci_dev *dev)
+{
+	dev_info(&dev->dev, "Disabling MSI for ATI Radeon\n");
+	dev->no_msi = 1;
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATI, 0x5a3f, radeon_msi_disable);
+
 static int __devinit ht_check_msi_mapping(struct pci_dev *dev)
 {
 	int pos, ttl = 48;

(In reply to comment #14)
> Alex - disabling MSI for only this device (and it's subordinate buses via the
> existing patches) is insufficient, right?

My patch is correct as is.  It doesn't disable MSI's globally, it only disables them for the internal gfx bridge and it's subordinate devices.  MSI's work fine on other bridges on the chipset.

I haven't seen this patch in any of the 2.6.34-rc* releases.  Is there any chance this fix makes it into 2.6.34?

possibly related to this bug as well?
https://bugzilla.kernel.org/show_bug.cgi?id=15982

Xpress 200m, conflict with ALSA when KMS is enabled

(In reply to comment #17)
> possibly related to this bug as well?
> https://bugzilla.kernel.org/show_bug.cgi?id=15982
> 
> Xpress 200m, conflict with ALSA when KMS is enabled


booting with pci=noirq,nomsi doesnt help with sound

(In reply to comment #17)
> possibly related to this bug as well?
> https://bugzilla.kernel.org/show_bug.cgi?id=15982

If pci=nomsi doesn't help than it's not related.  MSI's are already disabled on other rs4xx chipsets.

I've sent a rebased patch to Jesse and linux-pci.

This bug was fixed in kernel version 2.6.34 by this commit:

commit c414a117c6094c3f86b533f97beaf45ef9075f03
Author: Alex Deucher <alexdeucher@gmail.com>
Date:   Tue Mar 30 17:22:32 2010 -0400

    drm/radeon/kms: disable MSI on IGP chips
    
    Doesn't seem to work reliably and the pci quirks don't
    always work.
    
    Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>


This commit is different than the proposed fix that was attached to this bug.  The patch attached to this bug was committed as 9313ff450400e6a2ab10fe6b9bdb12a828329410 after the 2.6.34 release.

Both of these commits cause the audio on my laptop to stop working.  However, if I boot with pci=noacpi then audio works fine.  As far as I am concerned this bug is fixed, I'll file a different bug about the audio problem.