Bug 152131

Summary: e1000e Failed to restore TIMINCA clock rate delta: -22
Product: Drivers Reporter: Conrad Kostecki (ck+kernelbugzilla)
Component: NetworkAssignee: drivers_network (drivers_network)
Status: RESOLVED OBSOLETE    
Severity: normal CC: david.weinehall, indolflinus, ingvarthorvald
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 4.7.0 Subsystem:
Regression: No Bisected commit-id:
Attachments: Delta Update Fix

Description Conrad Kostecki 2016-08-12 21:17:07 UTC 
With kernel 4.7, I've noticed, that my dmesg is printing multiple times "e1000e 0000:00:1f.6: Failed to restore TIMINCA clock rate delta: -22"
At that time, no lan cable is conncted to my lan port.

With kernel 4.6.x, I've never seen this message.

That seems something to do with this change, i think: https://patchwork.ozlabs.org/patch/611258/

Kernel: 4.7.0-gentoo (Gentoo-Sources, but it also happens with vanilla-sources)
OS: Gentoo
Device: ThinkPad X260 with Intel 219I-LM
E1000E: e1000e.InterruptThrottleRate=1 e1000e.SmartPowerDownEnable=1
Comment 1 [account disabled by the administrator] 2016-08-18 02:55:12 UTC 
Just to be guess can you bisect and prove it's that actual commit. It seems so after skim reading it but want to be sure.
Comment 2 Conrad Kostecki 2016-08-18 08:25:45 UTC 
(In reply to ingvarthorvald from comment #1)
> Just to be guess can you bisect and prove it's that actual commit. It seems
> so after skim reading it but want to be sure.

I've never done before any bisect. So, I will have a look, how to do it?

When I do browse the Linux Github, I can see:
https://github.com/torvalds/linux/commit/aa524b66c5efd1d3220b74168d803e8b2ee1d212#diff-711a6dd55865f08da50a4caae30cc571

That's the commit, which brought the error message in my log. Before this commit, that error message was not in the code.
Comment 3 [account disabled by the administrator] 2016-08-18 14:29:40 UTC 
Can you try removing this line:
adapter->ptp_delta = delta;
in e1000e_phc_adjfreq and see what happens.
Comment 4 Conrad Kostecki 2016-08-28 14:07:31 UTC 
Seems to work. Recompile worked and network is still working. I didn't saw this message again.
Comment 5 [account disabled by the administrator] 2016-08-28 19:18:59 UTC 
Ok that's good we found the offending line, seems that it needs to be changed to use the updated delta not the older delta.
Comment 6 [account disabled by the administrator] 2016-08-28 19:19:34 UTC 
Created attachment 230931 [details]
Delta Update Fix
Comment 7 [account disabled by the administrator] 2016-08-30 18:48:08 UTC 
Can you try the below patch and see if it helped.
Comment 8 Conrad Kostecki 2024-01-21 19:42:15 UTC 
Closing.