Bug 14920

Summary: scripts/mkcompile_h should use absolute paths
Product: Other Reporter: Glenn Sommer (glemsom)
Component: OtherAssignee: other_other
Status: CLOSED OBSOLETE    
Severity: low CC: alan
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.32.2 Subsystem:
Regression: No Bisected commit-id:
Attachments: Use full path to dnsdomainname and domainname in mkcompile_h

Description Glenn Sommer 2009-12-28 22:18:07 UTC
Created attachment 24333 [details]
Use full path to dnsdomainname and domainname in mkcompile_h

Currently scripts/mkcompile_h checks for /bin/dnsdomainname and /bin/domainname when trying to find the DNS name.
But when creating the file - the full absolute path to the executable isn't used.

IMO if we check for "/bin/dnsdomainname", we should also use "/bin/dnsdomainname" - and not blindly trust /bin is the first directory in $PATH.

I've attached a patch to use "/bin/dnsdomainname" instead of "dnsdomainname". And "/bin/domainname" instead of "domainname"
Comment 1 Alan 2010-01-19 16:04:43 UTC
Can you send the patch to linux-kernel@vger.kernel.org with a signed-off-by: line as per Documentation/SubmittingPatches

Thanks
Alan