Bug 14747

After a new git bisect run, it appears that the first bad commit is the following:

commit 2a84cb9852f52c0cd1c48bca41a8792d44ad06cc
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Sun Aug 30 03:06:14 2009 +0400

    ACPI: EC: Merge IRQ and POLL modes

I have tried to revert it to confirm that it was the correct commit but it's not possible to do so.

Does nobody has any idea on this very annoying problem ?

This bug has been opened around 2 weeks ago and I didn't get any help on this. Does somebody really looks at this one ?

What machine do you have?

My computer is an ACER Travelmate 4001 with an Intel Centrino. Here is the output of lspci:

00:00.0 Host bridge: Intel Corporation 82852/82855 GM/GME/PM/GMV Processor to I/O Controller (rev 02)
00:00.1 System peripheral: Intel Corporation 82852/82855 GM/GME/PM/GMV Processor to I/O Controller (rev 02)
00:00.3 System peripheral: Intel Corporation 82852/82855 GM/GME/PM/GMV Processor to I/O Controller (rev 02)
00:01.0 PCI bridge: Intel Corporation 82852/82855 GM/GME/PM/GMV Processor to AGP Controller (rev 02)
00:1d.0 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 03)
00:1d.1 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 03)
00:1d.2 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 03)
00:1d.7 USB Controller: Intel Corporation 82801DB/DBM (ICH4/ICH4-M) USB2 EHCI Controller (rev 03)
00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev 83)
00:1f.0 ISA bridge: Intel Corporation 82801DBM (ICH4-M) LPC Interface Bridge (rev 03)
00:1f.1 IDE interface: Intel Corporation 82801DBM (ICH4-M) IDE Controller (rev 03)
00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 03)
00:1f.5 Multimedia audio controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 03)
00:1f.6 Modem: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller (rev 03)
01:00.0 VGA compatible controller: ATI Technologies Inc RV350 [Mobility Radeon 9600 M10]
02:02.0 Ethernet controller: Broadcom Corporation BCM4401 100Base-T (rev 01)
02:04.0 Network controller: Intel Corporation PRO/Wireless 2200BG Network Connection (rev 05)
02:06.0 CardBus bridge: Texas Instruments PCIxx21/x515 Cardbus Controller
02:06.2 FireWire (IEEE 1394): Texas Instruments OHCI Compliant IEEE 1394 Host Controller
02:06.3 Mass storage controller: Texas Instruments PCIxx21 Integrated FlashMedia Controller

Created attachment 24226 [details]
output of dmesg with kernel 2.6.32

I also send the result of dmesg in case you need it.

Could you please check if the last patch from bug #14446 helps?

Created attachment 24228 [details]
Put back udelay at transaction start 

Please check one more patch.

Created attachment 24229 [details]
output of dmesg with kernel 2.6.32 and additional patches

Unfortunately, the 2 patches you proposed don't solve the problem. It seems the touchpad is now detected:

[   12.261028] Synaptics claims to have extended capabilities, but I'm not able to read them.
[   12.824962] Synaptics Touchpad, model: 1, fw: 5.9, id: 0x126eb1, caps: 0xa04713/0x0
[   12.866729] input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio4/input/input4

Furthermore, the synchronisation problem still occurs:
[   58.427180] psmouse.c: TouchPad at isa0060/serio4/input0 lost synchronization, throwing 1 bytes away.
[   58.941246] psmouse.c: resync failed, issuing reconnect request

Could you please uncomment "#define DEBUG" at the beginning of drivers/acpi/ec.c and attach dmesg?

Created attachment 24291 [details]
dmesg with debugging enabled in ec.c

So here is the dmesg output you asked for.

Could you please check if last patch from this bug reports helps:
http://bugzilla.kernel.org/show_bug.cgi?id=14858

Created attachment 24297 [details]
dmesg with debugging enabled in ec.c and patch from bug #14858

Unfortunately, this last patch doesn't solve the problem. In case you need it, I have attached a new dmesg output.

Could you please post acpidump output?

Created attachment 24299 [details]
accelerate query execution #2

please check if this patch is any better than #14858

Created attachment 24304 [details]
output of acpidump

This last patch doesn't solve the problem too. As you have asked, I also send the output of acpidump.

Could you please also attach dmesg with the last patch applied?

Created attachment 24306 [details]
dmesg with debugging enabled in ec.c 

So here is the dmesg output with debugging enabled in ec.c. Do you also want a "normal" dmesg ?

Are you sure that this dmesg is from kernel with patch from comment #15 applied?
It looks more like plain 2.6.32 with DEBUG enabled...

Created attachment 24307 [details]
dmesg with debugging enabled in ec.c

I indeed attached the wrong file. This new output is the correct dmesg output with the last patch applied.

Created attachment 24309 [details]
accelerate query execution #3

please check one more patch. please post a dmesg with debug enabled.

Created attachment 24310 [details]
accelerate query execution #4

broken patch

Created attachment 24311 [details]
dmesg with debugging enabled in ec.c and patch from comment #22

The problem still occurs with this last patch. Furthermore, are the 2 first patches (fix msi detection and put back udelay) still needed ?

Created attachment 24317 [details]
add some sleep

please add this on top of #4

It finally works with the latest patch from comment #24. It's even still working if I revert the patch which puts back udelay (from comment #8).

Thanks a lot for your help.

Handled-By : Alexey Starikovskiy <astarikovskiy@suse.de>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=24317

patch in comment #24 is in acpi-test tree

Thanks, but the patch in comment #22 is also needed.

I have checked and it seems that you in fact took the patch from comment #22, but the patch from comment #24 is also needed to make my touchpad work.

The patch from comment #22

commit a62e8f1978f49e52f87a711ff6711b323d4b12ff
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Thu Dec 24 11:34:16 2009 +0300

    ACPI: EC: Accelerate query execution

and the patch from comment #24

commit 54070101f86ca9a6e9ba243c999d144721ec3db7
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Wed Dec 30 15:53:10 2009 +0300

    ACPI: EC: Add wait for irq storm

both shipped in Linux-2.6.33-rc5
closed