Bug 14554

Summary: LVDS is not detected correctly as LID is always reported as closed
Product: Drivers Reporter: Bryan Hundven (bryanhundven)
Component: Video(DRI - Intel)Assignee: ykzhao (yakui.zhao)
Status: RESOLVED PATCH_ALREADY_AVAILABLE    
Severity: high CC: gordon.jin, jbarnes, sven.koehler, xt28, yakui.zhao
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.32-rc6 Subsystem:
Regression: No Bisected commit-id:
Attachments: lspci of q1u
i915 stack trace
dmesg with trace
trace of kernel 2.6.32.2
output of dmidecode
try the patch that adds HP nx9020/Samsung SX20s to ACPI LID quirk list
try the patch that adds HP nx9020/Samsung SX20s to ACPI LID quirk list

Description Bryan Hundven 2009-11-07 20:13:04 UTC
Created attachment 23696 [details]
lspci of q1u

Tried running 2.6.32-rc6 on my Samsung Q1U-CMXP. i915 with kms dumped a trace and unloaded.
Comment 1 Bryan Hundven 2009-11-07 20:14:00 UTC
Created attachment 23697 [details]
i915 stack trace
Comment 2 Bryan Hundven 2009-11-23 10:20:47 UTC
I guess I should also note that the native resolution on this device is 1024x600.
If there is anything else I can provide for this bug, please let me know.
Comment 3 Sven Köhler 2009-11-29 17:05:18 UTC
Created attachment 23971 [details]
dmesg with trace

Same problem here.
PC: Samsung X20 notebook
Chip: Intel 915

KMS works nice with 2.6.31.6
2.6.32-rc8 gives me stacktrace very much like the one already attached.
Comment 4 Jesse Barnes 2009-12-02 19:29:37 UTC
Can either of you bisect this?
Comment 5 Jesse Barnes 2009-12-02 19:33:20 UTC
Might be a dupe of 14649 too.
Comment 6 Bryan Hundven 2009-12-04 00:04:37 UTC
From comment #3 of 14646, Martin Bammer explains: 'The lid is detected
as "closed" and no external vga monitor is connected. A closed lid leads to
"LVDS-1 is disconnected". "VGA-1 is disconnected" and "LVDS-1 is disconnected"
leads to "No connectors reported connected with modes" and then kms fails.'

The Samsung Q1U (CMXP) is a mobile internet device without a lid, and may have a bad lid value as well. It is most possible that this is a dup of 14649.

I am building a kernel now, with Martin's suggestion in comment #4 to comment out the lines:
    if (!acpi_lid_open() && !dmi_check_system(bad_lid_status))
        status = connector_status_disconnected;
in i915/intel_lvds.c, and I will post results tonight.

I also want to try a kernel before and after commit: e99da35f060f9a3407f7def474a1df31f3b8643a (drm/i915: Check the LID device to decide whether the...)
If i915 still works after that commit, then this one:
c1c7af60892070e4b82ad63bbfb95ae745056de0 (drm/i915: force mode set at lid open time)
Comment 7 Sven Köhler 2009-12-19 23:16:47 UTC
Created attachment 24233 [details]
trace of kernel 2.6.32.2
Comment 8 ykzhao 2010-01-02 14:13:18 UTC
will you please add the boot option of "nomodeset" and attach the following
output after the system is booted?
    > cat /proc/acpi/button/lid/LID/state

will you please also attach the output of dmidecode?

Thanks.
Comment 9 Sven Köhler 2010-01-03 18:46:26 UTC
Created attachment 24423 [details]
output of dmidecode

"cat /proc/acpi/button/lid/LID0/state" always returns "state: closed" for me. No matter, whether the lid is actually closed or not.
Comment 10 Jesse Barnes 2010-01-04 17:15:06 UTC
Yakui, can you add a quirk for this machine?
Comment 11 ykzhao 2010-01-06 05:36:34 UTC
Created attachment 24460 [details]
try the patch that adds HP nx9020/Samsung SX20s to ACPI LID quirk list

Will you please try the attached patch on the latest upstream kernel and see whether the issue can be fixed?

thanks.
Comment 12 Sven Köhler 2010-01-06 09:18:50 UTC
(In reply to comment #11)
> Will you please try the attached patch on the latest upstream kernel and see
> whether the issue can be fixed?

What do you mean by "can be fixed"?

Well, I applied the patch this morning, before I went to work. The kernel was 2.6.32.2 and applying the patch didn't seem to solve the issue. I was still getting a black screen on boot. I will a look this evening, whether there is still a kernel trace in the logs.

Or was I supposed to try 2.6.33-rc3 + patch?
Comment 13 Bryan Hundven 2010-01-06 16:56:19 UTC
Ykzhao,

Sorry for the late response, been busy. I will try the patch on my Q1U
today.

Thanks.

On Jan 5, 2010 9:36 PM, <bugzilla-daemon@bugzilla.kernel.org> wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=14554
--- Comment #11 from ykzhao <yakui.zhao@intel.com>  2010-01-06 05:36:34 ---
Created an attachment (id=24460)
 --> (http://bugzilla.kernel.org/attachment.cgi?id=24460)
try the patch that adds HP nx9020/Samsung SX20s to ACPI LID quirk list

Will you please try the attached patch on the latest upstream kernel and see
whether the issue can be fixed?

thanks.

-- Configure bugmail:
http://bugzilla.kernel.org/userprefs.cgi?tab=email------- You are
receiving...
Comment 14 Sven Köhler 2010-01-06 19:13:55 UTC
The patch doesn't work for me. No matter whether I use 2.6.32.2 or 2.6.33-rc3 - the trace is still there, and the screen remains black:

Jan  6 20:05:28 bert kernel: WARNING: at drivers/gpu/drm/drm_crtc_helper.c:1035 drm_helper_initial_config+0x60/0x70()
Jan  6 20:05:28 bert kernel: Hardware name: SX20S
Jan  6 20:05:28 bert kernel: No connectors reported connected with modes
Comment 15 Sven Köhler 2010-01-06 19:15:14 UTC
Addition:
/proc/acpi/button/lid/LID0/state still returns "closed". Is that supposed to happen, even though I applied the patch?
Comment 16 Philipp Kohlbecher 2010-01-11 10:13:28 UTC
Could you take a look at bug #14957 and see whether it is a duplicate of this bug?

Could you try the corrected patch posted there and see whether it works for you?

Sven, please note that the patch is a workaround--the screen should be activated even though the ACPI lid status is still incorrectly reported as closed. (For that problem, please see bug #14977.)
Comment 17 ykzhao 2010-01-14 06:52:35 UTC
Created attachment 24545 [details]
try the patch that adds HP nx9020/Samsung SX20s to ACPI LID quirk list

Sorry that I don't attach the updated patch.

Will you please try the updated patch and see whether it can work for you?

thanks.
Comment 18 Sven Köhler 2010-01-14 20:24:07 UTC
(In reply to comment #17)
> Will you please try the updated patch and see whether it can work for you?

It works for me now!

But just out of interest: if the LID of a laptop that is not in the quirk list is actually closed during boot (for example if you start your Laptop via WOL), then people have the same issues?
Comment 19 ykzhao 2010-01-17 12:50:16 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > Will you please try the updated patch and see whether it can work for you?
> It works for me now!

Thanks for the testing.
> But just out of interest: if the LID of a laptop that is not in the quirk
> list
> is actually closed during boot (for example if you start your Laptop via
> WOL),
> then people have the same issues?
What you said is right. If the laptop with the incorrect LID status is not in the quirk list, they will have the same issue.

As the patch is already in Eric's for-linus tree, this bug will be marked as resolved.

thanks.