Bug 14541
Summary: | getcwd() incorrectly returning ENOENT... | ||
---|---|---|---|
Product: | File System | Reporter: | Daniel J Blueman (daniel.blueman) |
Component: | NFS | Assignee: | Trond Myklebust (trondmy) |
Status: | CLOSED CODE_FIX | ||
Severity: | high | CC: | akpm |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://marc.info/?l=linux-nfs&m=125707965119418&w=2 | ||
Kernel Version: | 2.6.30, 2.6.31, 2.6.32-rc5 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: | NFSv4: Fix a cache validation bug which causes getcwd() to return ENOENT |
Description
Daniel J Blueman
2009-11-04 09:28:18 UTC
Created attachment 23665 [details] NFSv4: Fix a cache validation bug which causes getcwd() to return ENOENT Changeset a65318bf3afc93ce49227e849d213799b072c5fd (NFSv4: Simplify some cache consistency post-op GETATTRs) incorrectly changed the getattr bitmap for readdir(). This causes the readdir() function to fail to return a fileid/inode number, which again exposed a bug in the NFS readdir code that causes spurious ENOENT errors to appear in applications (see http://bugzilla.kernel.org/show_bug.cgi?id=14541). The immediate band aid is to revert the incorrect bitmap change, but more long term, we should change the NFS readdir code to cope with the fact that NFSv4 servers are not required to support fileids/inode numbers. Sorry for having taken so long to get back to this bug. A combination of travel and family circumstances kept me busy. Also thanks for having taken all the trouble to bisect the problem and setting up the bug report... Does the above patch suffice fix things? Bingo! This patch fixes the behaviour and passed some heavy testing with two good test-cases. Good work, Trond. Worthwhile for the stable stream also. I'm not seeing a Cc:stable@kernel.org in that changelog, but it's needed there, yes? I wasn't aware that it is acceptable practice to Cc: stable@kernel.org in bugzilla reports, but if it is, then yes we should add them... Oh, sorry. You said 'changelog'... My reading skills will improve once I get a morning coffee in me... Marking bug as CLOSED. Please reopen if the problem reoccurs. |