Bug 14478
Summary: | processes using libgc (such as w3m) crash under 2.6.32-rc4 | ||
---|---|---|---|
Product: | Process Management | Reporter: | Michael S. Tsirkin (m.s.tsirkin) |
Component: | Other | Assignee: | Alexey Dobriyan (adobriyan) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | adobriyan |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.32-rc4 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: | .config showing the problem |
Description
Michael S. Tsirkin
2009-10-26 17:29:32 UTC
NOT reproduced on Gentoo/2.6.32-rc5, post .config just in case. Created attachment 23554 [details]
.config showing the problem
.config attached
Note: I am running 32 bit userspace on 64 bit kernel I just checked 64 bit userspace and it does not seem to have this problem reproduced in compat mode oh wow! d899bf7b55f503ba7d3d07ed27c3a37e270fa7db is the first bad commit commit d899bf7b55f503ba7d3d07ed27c3a37e270fa7db Author: Stefani Seibold <stefani@seibold.net> Date: Tue Sep 22 16:45:40 2009 -0700 procfs: provide stack information for threads With this patch applied, w3m does not crash anymore for me. The patch fixing the issue in question is: > Assign tsk->stack_start even when doing compat execve(2). > > As side effect, fix segfault inside boehm-gc library. > http://bugzilla.kernel.org/show_bug.cgi?id=14478 > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Alexey, please attach it in bugzilla. diff -puN fs/compat.c~proc-fix-stack_start-in-compat-mode fs/compat.c --- a/fs/compat.c~proc-fix-stack_start-in-compat-mode +++ a/fs/compat.c @@ -1531,6 +1531,8 @@ int compat_do_execve(char * filename, if (retval < 0) goto out; + current->stack_start = current->mm->start_stack; + /* execve succeeded */ current->fs->in_exec = 0; current->in_execve = 0; commit 89240ba059ca468ae7a8346edf7f95082458c2fc x86, fs: Fix x86 procfs stack information for threads on 64-bit |