Bug 14227

Summary:	pata_sc1200: Activate secondary channel patch Oops
Product:	IO/Storage	Reporter:	Alexandros C. Couloumbis (alex)
Component:	Serial ATA	Assignee:	Alan (alan)
Status:	RESOLVED CODE_FIX
Severity:	high	CC:	alan
Priority:	P1
Hardware:	All
OS:	Linux
URL:	http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=c0f2ee34a5a0b79fd98d965ad8ae765d4639bfa5
Kernel Version:	2.6.30/2.6.31	Subsystem:
Regression:	Yes	Bisected commit-id:
Attachments:	wrap boot log

Description Alexandros C. Couloumbis 2009-09-25 12:07:14 UTC

the wrap x86 board does not boot on linux-2.6.30.5 using ata/scsi sc1200 (pata_sc1200) 

Please check: https://dev.openwrt.org/ticket/5768

Comment 1 Alan 2009-09-25 12:33:06 UTC

Doh.. 

Try changing

       /* Can't enable port 2 yet, see top comments */
        const struct ata_port_info *ppi[] = { &info, };

to

      const struct ata_port_info *ppi[] = { &info, NULL };

Comment 2 Alexandros C. Couloumbis 2009-09-25 20:28:01 UTC

Created attachment 23182 [details]
wrap boot log

Comment 3 Alexandros C. Couloumbis 2009-09-25 20:29:10 UTC

I used nbd's patch: https://dev.openwrt.org/browser/trunk/target/linux/x86/patches-2.6.31/100-pata_sc1200-wrap.patch?rev=17723 based on Alan's Cox suggestion and everything works fine.  

--- a/drivers/ata/pata_sc1200.c
+++ b/drivers/ata/pata_sc1200.c
@@ -236,7 +236,7 @@
                 .port_ops = &sc1200_port_ops
         };
         /* Can't enable port 2 yet, see top comments */
-        const struct ata_port_info *ppi[] = { &info, };
+        const struct ata_port_info *ppi[] = { &info, &ata_dummy_port_info };
 
         return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
 }

This ticket can now close. Thank you.