Bug 13587

Summary: drivers/serial/bfin_sport_uart.c:235: bad call to memset
Product: Drivers Reporter: David Binderman (dcb314)
Component: SerialAssignee: Russell King (rmk)
Severity: normal CC: alan
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.30 Tree: Mainline
Regression: No

Description David Binderman 2009-06-20 13:27:53 UTC
memset(buffer, 20, '\0');

Possible newbie coding error in that the 2nd & 3rd
parameter look the wrong way around to me.

Also, the coding police have noticed a lot
of mentions of the fixed constant "20" in the
same routine. Possible improve style by replacing
by a sizeof expression or other symbolic constant ?