Bug 13456

Summary: found overlapping data buffer
Product: Drivers Reporter: Martin Ettl (ettl.martin)
Component: OtherAssignee: drivers_other
Status: RESOLVED CODE_FIX    
Severity: normal CC: alan
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.29.3 Subsystem:
Regression: No Bisected commit-id:

Description Martin Ettl 2009-06-04 16:00:02 UTC 

    


    


      



        
          Comment 1
        

        
          Martin Ettl

        

        
        

        
          2009-06-04 16:01:20 UTC
        

      






Hello,

i detected an overlapping data buffer at file 
"linux-2.6.29.3/drivers/staging/rt2870/sta/wpa.c"
For detection, i used the static code analysis tool cppcheck. It prints the
following message:
[linux-2.6.29.3/drivers/staging/rt2870/sta/wpa.c:1967]: (error) Overlapping data buffer custom

Take a loop at file wpa.c at line 1967:

       sprintf(custom, "%s unicast", custom);

Here, var "custom" is used by iteself, this is dangerous!!!!

Best regards

Ettl Martin

    


    


      



        
          Comment 2
        

        
          Alan

        

        
        

        
          2009-06-05 13:39:51 UTC
        

      






Fixed, thanks

The staging code is pending clean up before proper integration so I don't doubt there are plenty of these.