Bug 13122
Summary: | reiserfs_delete_xattrs: Couldn't delete all xattrs (-13) | ||
---|---|---|---|
Product: | File System | Reporter: | Rafael J. Wysocki (rjw) |
Component: | ReiserFS | Assignee: | ReiseFS developers team (reiserfs-devel) |
Status: | CLOSED CODE_FIX | ||
Severity: | normal | CC: | liquid.acid, stefanr |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.30-rc2 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Bug Depends on: | |||
Bug Blocks: | 13070 |
Description
Rafael J. Wysocki
2009-04-16 23:47:38 UTC
A bisection result: http://marc.info/?l=linux-kernel&m=124188253923643 Proposed patches: http://lkml.org/lkml/2009/5/10/91 Caused-by: commit d984561b326cd0fe0d1183d11b9b4fa1d011d21d Author: Jeff Mahoney <jeffm@suse.com> Date: Mon Mar 30 14:02:35 2009 -0400 reiserfs: eliminate per-super xattr lock With the switch to using inode->i_mutex locking during lookups/creation in the xattr root, the per-super xattr lock is no longer needed. This patch removes it. Signed-off-by: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> First-Bad-Commit : d984561b326cd0fe0d1183d11b9b4fa1d011d21d Handled-By : Jeff Mahoney <jeffm@suse.com> Patch : http://lkml.org/lkml/2009/5/10/91 On Sunday 17 May 2009, Linus Torvalds wrote:
>
> On Sat, 16 May 2009, Rafael J. Wysocki wrote:
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.29. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13122
> > Subject : reiserfs_delete_xattrs: Couldn't delete all xattrs
> (-13)
> > Submitter : Alexander Beregalov <a.beregalov@gmail.com>
> > Date : 2009-04-16 19:23 (31 days old)
> > First-Bad-Commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d984561b326cd0fe0d1183d11b9b4fa1d011d21d
> > References : http://marc.info/?l=linux-kernel&m=123990989515105&w=4
> > Handled-By : Jeff Mahoney <jeffm@suse.com>
> > Patch : http://lkml.org/lkml/2009/5/10/91
>
> The fix should now be merged as b83674c0da6558e357c6b482ccf299eeea77d8ef
> ("reiserfs: fixup perms when xattrs are disabled")
Hmm, I encountered the problem in 2.6.30_rc5 (didn't check the previous RCs) and updated today to rc6 only to find that the kernel segfaults now (in a reiserfs call). Going back to rc5 removes the segfaults, but the warnings come back. I fixed this for rc6 by enabling xattr support for reiserfs in the kernel config (I had it disabled). I'm going to try to log the segfault somehow. I didn't seem to be written to the system log when it occured. I don't know how this is handled on kernel.org. Should I open a new bug for this problem or does someone have to reopen this one here? Greets, Tobias The patches that are supposed to fix the issue have gone in after 2.6.30-rc6. So, the bug should be fixed in -rc7 and if it's not, please reopen this entry. Tobias, you are most likely seeing bug 13321. You can either try current git, or -rc6 plus extra patches (linked in bug 13321) or wait for -rc7. PS: If you get something different from bug 13321 (see attachment 21374 [details] there) with latest git, then please open a new bug. Thanks Stefan for the info! I'm pretty sure it's bug #13321. I just removed xattr support for reiserfs from kernel config again and it also crashes in reiserfs_for_each_xattr on boot. Going to wait for rc7 though :) |