Bug 12705
Summary: | X200: Brightness broken since 2.6.29-rc4-58-g4c098bc | ||
---|---|---|---|
Product: | Drivers | Reporter: | Rafael J. Wysocki (rjw) |
Component: | Video(DRI - Intel) | Assignee: | drivers_video-dri-intel (drivers_video-dri-intel) |
Status: | CLOSED INSUFFICIENT_DATA | ||
Severity: | normal | CC: | alan, aris, eric, gordon.jin, trenn |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.29-rc4-58-g4c098bc | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Bug Depends on: | |||
Bug Blocks: | 12398, 56331 |
Description
Rafael J. Wysocki
2009-02-14 12:51:28 UTC
Hi, Nico Will you please attach the output of acpidump, lspci -vxxx? Thanks. http://marc.info/?l=linux-kernel&m=123479975503827&w=2 e806b4957412bf472d826bd8cc571da041248799 is the first commit cc Eric Do you mean the first bad one? (In reply to comment #3) > Do you mean the first bad one? > right. commit e806b4957412bf472d826bd8cc571da041248799 Author: Eric Anholt <eric@anholt.net> Date: Thu Jan 22 09:56:58 2009 -0800 drm/i915: Suppress GEM teardown on X Server exit in KMS mode. Fixes hangs when starting X for the second time. Signed-off-by: Eric Anholt <eric@anholt.net> Signed-off-by: Dave Airlie <airlied@linux.ie> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index debad5c..a590d61 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -3273,6 +3273,9 @@ i915_gem_lastclose(struct drm_device *dev) { int ret; + if (drm_core_check_feature(dev, DRIVER_MODESET)) + return; + ret = i915_gem_idle(dev); if (ret) DRM_ERROR("failed to idle hardware: %d\n", ret); On Tuesday 24 February 2009, Nico Schottelius wrote:
> Still existing.
>
> Rafael J. Wysocki [Mon, Feb 23, 2009 at 10:48:13PM +0100]:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12705
> > Subject : X200: Brightness broken since 2.6.29-rc4-58-g4c098bc
On Wednesday 04 March 2009, Nico Schottelius wrote:
> Rafael J. Wysocki [Tue, Mar 03, 2009 at 08:25:55PM +0100]:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > (either way).
>
> Well, well... nobody really cares about this bug, so it's still
> there. Seems this automatic reminder will be persistent until 2.6.30.
On Wednesday 04 March 2009, Zhang Rui wrote: > On Wed, 2009-03-04 at 03:22 +0800, Rafael J. Wysocki wrote: > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12705 > > Subject : X200: Brightness broken since 2.6.29-rc4-58-g4c098bc > > Submitter : Nico Schottelius <nico-linux-20090213@schottelius.org> > > Date : 2009-02-13 9:33 (19 days old) > > References : http://marc.info/?l=linux-kernel&m=123451768406825&w=4 > > Handled-By : Len Brown <lenb@kernel.org> > > > > e806b4957412bf472d826bd8cc571da041248799 is first bad commit commit e806b4957412bf472d826bd8cc571da041248799 Author: Eric Anholt <eric@anholt.net> Date: Thu Jan 22 09:56:58 2009 -0800 drm/i915: Suppress GEM teardown on X Server exit in KMS mode. Fixes hangs when starting X for the second time. Signed-off-by: Eric Anholt <eric@anholt.net> Signed-off-by: Dave Airlie <airlied@linux.ie> References : http://marc.info/?l=linux-kernel&m=123479975503827&w=2 First-Bad-Commit : e806b4957412bf472d826bd8cc571da041248799 Not-Handled-By : Len Brown <lenb@kernel.org> Handled-By : Eric Anholt <eric@anholt.net> On Sunday 26 April 2009, Nico Schottelius wrote:
> Rafael J. Wysocki [Sun, Apr 26, 2009 at 11:46:25AM +0200]:
> > This message has been generated automatically as a part of a report
> > of regressions introduced between 2.6.28 and 2.6.29.
>
> Sure, still broken. For some version it works, for most newer not,
> as reported.
I'm running 2.6.30 (44b7532b8b464f606053562400719c9c21276037) on a X200 and writing on /proc/acpi/video/VID/LCD0/brightness works while on battery and AC. Using /sys/class/backlight/acpi_video0 also works. Nico, can you test with a newer version? Can the reporter confirm this still exist in 2.6.30 or 31? Closing stale bug |