Bug 12536

Summary: oops when plugging in AC
Product: ACPI Reporter: Johannes Berg (johannes)
Component: Power-ProcessorAssignee: acpi_power-processor
Status: CLOSED CODE_FIX    
Severity: normal    
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.29-rc2-wl-dirty Subsystem:
Regression: Yes Bisected commit-id:
Bug Depends on:    
Bug Blocks: 12398    

Description Johannes Berg 2009-01-24 07:04:44 UTC 
Seems like a race condition, I'm sure I've plugged in AC before at runtime without this happening...

[ 3820.603439] BUG: unable to handle kernel paging request at ffffffff805b375f
[ 3820.603448] IP: [<ffffffff803f720b>] memcpy_c+0xb/0x20
[ 3820.603457] PGD 203067 PUD 207063 PMD 7c822161 PTE 5b3161
[ 3820.603465] Oops: 0003 [#1] PREEMPT SMP 
[ 3820.603472] last sysfs file: /sys/devices/LNXSYSTM:00/device:00/PNP0C0A:00/power_supply/BAT0/energy_full
[ 3820.603476] CPU 1 
[ 3820.603479] Modules linked in: zd1211rw sha256_generic af_packet binfmt_misc rfcomm l2cap kvm_intel kvm acpi_cpufreq cpufreq_userspace cpufreq_powersave fuse loop btusb bluetooth bcm5974 snd_hda_codec_realtek hid_apple usbhid arc4 snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm uvcvideo b43 videodev v4l1_compat v4l2_compat_ioctl32 snd_seq_oss rfkill snd_seq_midi_event mac80211 snd_seq joydev cfg80211 snd_timer applesmc snd_seq_device hwmon sg input_polldev mbp_nvidia_bl ehci_hcd ohci_hcd sr_mod backlight ssb snd cdrom soundcore snd_page_alloc usbcore evdev sd_mod unix
[ 3820.603555] Pid: 89, comm: kacpi_notify Not tainted 2.6.29-rc2-wl-dirty #20
[ 3820.603559] RIP: 0010:[<ffffffff803f720b>]  [<ffffffff803f720b>] memcpy_c+0xb/0x20
[ 3820.603564] RSP: 0018:ffff88007d8c3bc8  EFLAGS: 00010246
[ 3820.603567] RAX: ffffffff805b375f RBX: ffff880001aa0340 RCX: 0000000000000001
[ 3820.603570] RDX: 0000000000000000 RSI: ffffffff805cc600 RDI: ffffffff805b375f
[ 3820.603573] RBP: ffff88007d8c3c10 R08: 0000000000000000 R09: 0000000000000000
[ 3820.603575] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff81013038
[ 3820.603578] R13: ffffffff805cc600 R14: ffffffff8042dacf R15: ffff88007d84c670
[ 3820.603581] FS:  0000000000000000(0000) GS:ffff88007de69190(0000) knlGS:0000000000000000
[ 3820.603584] CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
[ 3820.603587] CR2: ffffffff805b375f CR3: 0000000000201000 CR4: 00000000000026e0
[ 3820.603590] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 3820.603593] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 3820.603597] Process kacpi_notify (pid: 89, threadinfo ffff88007d8c2000, task ffff88007d8ba450)
[ 3820.603600] Stack:
[ 3820.603602]  ffffffffa0f2636c ffff880000000001 ffffffff805b375f ffffffff00000198
[ 3820.603609]  ffffffff805b4aa2 ffffffff8100f820 0000000000185a60 ffff88007da6a9c0
[ 3820.603617]  0000000000000000 ffff88007d8c3c30 ffffffffa0f26406 ffff88007d8c3c40
[ 3820.603625] Call Trace:
[ 3820.603627]  [<ffffffffa0f2636c>] ? get_cur_val+0xcc/0x100 [acpi_cpufreq]
[ 3820.603635]  [<ffffffff805b375f>] ? down_write+0x6f/0x80
[ 3820.603642]  [<ffffffff805b4aa2>] ? _spin_unlock_irqrestore+0x42/0x80
[ 3820.603648]  [<ffffffffa0f26406>] get_cur_freq_on_cpu+0x66/0x90 [acpi_cpufreq]
[ 3820.603653]  [<ffffffff804d47b8>] cpufreq_update_policy+0xa8/0x110
[ 3820.603660]  [<ffffffff804d4820>] ? handle_update+0x0/0x10
[ 3820.603666]  [<ffffffff80446e8d>] ? acpi_ut_release_mutex+0x5d/0x61
[ 3820.603672]  [<ffffffff804542a5>] acpi_processor_ppc_has_changed+0x85/0x8c
[ 3820.603678]  [<ffffffff804485f6>] ? acpi_bus_get_device+0x25/0x39
[ 3820.603683]  [<ffffffff80450543>] acpi_processor_notify+0x57/0xc9
[ 3820.603688]  [<ffffffff80433fe8>] acpi_ev_notify_dispatch+0x5f/0x6b
[ 3820.603694]  [<ffffffff8042dafb>] acpi_os_execute_deferred+0x2c/0x39
[ 3820.603699]  [<ffffffff8042dacf>] ? acpi_os_execute_deferred+0x0/0x39
[ 3820.603704]  [<ffffffff8025a735>] run_workqueue+0x105/0x250
[ 3820.603711]  [<ffffffff8025a6e3>] ? run_workqueue+0xb3/0x250
[ 3820.603715]  [<ffffffff8025a92f>] worker_thread+0xaf/0x130
[ 3820.603720]  [<ffffffff8025f480>] ? autoremove_wake_function+0x0/0x40
[ 3820.603726]  [<ffffffff8025a880>] ? worker_thread+0x0/0x130
[ 3820.603730]  [<ffffffff8025efb9>] kthread+0x49/0x90
[ 3820.603735]  [<ffffffff8020cdba>] child_rip+0xa/0x20
[ 3820.603740]  [<ffffffff8020c780>] ? restore_args+0x0/0x30
[ 3820.603745]  [<ffffffff8025ef70>] ? kthread+0x0/0x90
[ 3820.603749]  [<ffffffff8020cdb0>] ? child_rip+0x0/0x20
[ 3820.603753] Code: 81 ea d8 1f 00 00 48 3b 42 20 73 07 48 8b 50 f9 31 c0 c3 31 d2 48 c7 c0 f2 ff ff ff c3 90 90 90 48 89 f8 89 d1 c1 e9 03 83 e2 07 <f3> 48 a5 89 d1 f3 a4 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 
[ 3820.603823] RIP  [<ffffffff803f720b>] memcpy_c+0xb/0x20
[ 3820.603828]  RSP <ffff88007d8c3bc8>
[ 3820.603830] CR2: ffffffff805b375f
[ 3820.603834] ---[ end trace d64c84938314fbbc ]---
Comment 1 Johannes Berg 2009-01-26 04:32:57 UTC 
Same just happened on disconnecting AC:

[ 9342.095406] BUG: unable to handle kernel paging request at ffffffff805b383f
[ 9342.095415] IP: [<ffffffff803f729b>] memcpy_c+0xb/0x20
[ 9342.095424] PGD 203067 PUD 207063 PMD 7cb15161 PTE 5b3161
[ 9342.095432] Oops: 0003 [#1] PREEMPT SMP 
[ 9342.095438] last sysfs file: /sys/devices/LNXSYSTM:00/device:00/PNP0C0A:00/power_supply/BAT0/energy_full
[ 9342.095443] CPU 0 
[ 9342.095446] Modules linked in: zd1211rw mac80211 cfg80211 sha256_generic af_packet binfmt_misc rfcomm l2cap kvm_intel kvm acpi_cpufreq cpufreq_userspace cpufreq_powersave fuse loop btusb bluetooth bcm5974 hid_apple snd_hda_codec_realtek usbhid arc4 snd_hda_intel snd_hda_codec snd_hwdep uvcvideo rfkill snd_pcm_oss snd_mixer_oss videodev v4l1_compat v4l2_compat_ioctl32 snd_pcm joydev snd_seq_oss snd_seq_midi_event snd_seq snd_timer snd_seq_device snd sg applesmc hwmon ohci_hcd ehci_hcd input_polldev mbp_nvidia_bl sr_mod soundcore backlight ssb cdrom snd_page_alloc usbcore evdev sd_mod unix [last unloaded: cfg80211]
[ 9342.095525] Pid: 89, comm: kacpi_notify Not tainted 2.6.29-rc2-wl-11979-gc32422d-dirty #21
[ 9342.095528] RIP: 0010:[<ffffffff803f729b>]  [<ffffffff803f729b>] memcpy_c+0xb/0x20
[ 9342.095534] RSP: 0018:ffff88007d8c3bc8  EFLAGS: 00010246
[ 9342.095536] RAX: ffffffff805b383f RBX: ffff880001aa03c0 RCX: 0000000000000001
[ 9342.095539] RDX: 0000000000000000 RSI: ffffffff805cc5e0 RDI: ffffffff805b383f
[ 9342.095542] RBP: ffff88007d8c3c10 R08: 0000000000000000 R09: 0000000000000000
[ 9342.095545] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff81013038
[ 9342.095547] R13: ffffffff805cc5e0 R14: ffffffff8042db6f R15: ffff88007d84a670
[ 9342.095551] FS:  0000000000000000(0000) GS:ffffffff81022040(0000) knlGS:0000000000000000
[ 9342.095554] CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
[ 9342.095557] CR2: ffffffff805b383f CR3: 0000000000201000 CR4: 00000000000026e0
[ 9342.095560] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 9342.095563] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 9342.095566] Process kacpi_notify (pid: 89, threadinfo ffff88007d8c2000, task ffff88007d8ba450)
[ 9342.095569] Stack:
[ 9342.095571]  ffffffffa0f2c36c ffff880000000001 ffffffff805b383f ffffffff00000198
[ 9342.095578]  ffffffff805b4b82 ffffffff8100f820 0000000000185a60 ffff88007a0cd478
[ 9342.095585]  0000000000000000 ffff88007d8c3c30 ffffffffa0f2c406 ffff88007d8c3c40
[ 9342.095594] Call Trace:
[ 9342.095597]  [<ffffffffa0f2c36c>] ? get_cur_val+0xcc/0x100 [acpi_cpufreq]
[ 9342.095605]  [<ffffffff805b383f>] ? down_write+0x6f/0x80
[ 9342.095611]  [<ffffffff805b4b82>] ? _spin_unlock_irqrestore+0x42/0x80
[ 9342.095617]  [<ffffffffa0f2c406>] get_cur_freq_on_cpu+0x66/0x90 [acpi_cpufreq]
[ 9342.095623]  [<ffffffff804d4898>] cpufreq_update_policy+0xa8/0x110
[ 9342.095630]  [<ffffffff804d4900>] ? handle_update+0x0/0x10
[ 9342.095636]  [<ffffffff80446f2d>] ? acpi_ut_release_mutex+0x5d/0x61
[ 9342.095642]  [<ffffffff80454345>] acpi_processor_ppc_has_changed+0x85/0x8c
[ 9342.095649]  [<ffffffff80448696>] ? acpi_bus_get_device+0x25/0x39
[ 9342.095654]  [<ffffffff804505e3>] acpi_processor_notify+0x57/0xc9
[ 9342.095659]  [<ffffffff80434088>] acpi_ev_notify_dispatch+0x5f/0x6b
[ 9342.095665]  [<ffffffff8042db9b>] acpi_os_execute_deferred+0x2c/0x39
[ 9342.095671]  [<ffffffff8042db6f>] ? acpi_os_execute_deferred+0x0/0x39
[ 9342.095676]  [<ffffffff8025a735>] run_workqueue+0x105/0x250
[ 9342.095682]  [<ffffffff8025a6e3>] ? run_workqueue+0xb3/0x250
[ 9342.095687]  [<ffffffff8025a92f>] worker_thread+0xaf/0x130
[ 9342.095692]  [<ffffffff8025f480>] ? autoremove_wake_function+0x0/0x40
[ 9342.095698]  [<ffffffff8025a880>] ? worker_thread+0x0/0x130
[ 9342.095703]  [<ffffffff8025efb9>] kthread+0x49/0x90
[ 9342.095707]  [<ffffffff8020cdba>] child_rip+0xa/0x20
[ 9342.095713]  [<ffffffff8020c780>] ? restore_args+0x0/0x30
[ 9342.095718]  [<ffffffff8025ef70>] ? kthread+0x0/0x90
[ 9342.095722]  [<ffffffff8020cdb0>] ? child_rip+0x0/0x20
[ 9342.095726] Code: 81 ea d8 1f 00 00 48 3b 42 20 73 07 48 8b 50 f9 31 c0 c3 31 d2 48 c7 c0 f2 ff ff ff c3 90 90 90 48 89 f8 89 d1 c1 e9 03 83 e2 07 <f3> 48 a5 89 d1 f3 a4 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 
[ 9342.095799] RIP  [<ffffffff803f729b>] memcpy_c+0xb/0x20
[ 9342.095803]  RSP <ffff88007d8c3bc8>
[ 9342.095806] CR2: ffffffff805b383f
[ 9342.095810] ---[ end trace 6efc058a6f96f13f ]---

Haven't seen this on .28 ever, and now twice on .29, so marking as regression.
Comment 2 Johannes Berg 2009-01-29 11:47:18 UTC 
Seems this got fixed in -rc3, thanks.