Bug 12471

Summary:	udev rules for pcmcia-0.15 with nonstatic socket contains wrong path to the pcmcia-socket-startup binary
Product:	Drivers	Reporter:	Andrew Savchenko (bircoph)
Component:	PCMCIA	Assignee:	Dominik Brodowski (linux)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	komurojun-mbn, linux
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.28	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	proposed fix proposed fix to pcmciautils

Description Andrew Savchenko 2009-01-17 13:50:55 UTC

(Sorry, this is pcmciautils related bug, but as far pcmciautils is part of Linux kernel, I have no other idea where to post it using bugzilla.)

Latest working kernel version: pcmcia-0.14
Earliest failing kernel version: pcmcia-0.15
Distribution: vanilla and gentoo
Hardware Environment: Yenta-socket and NE2000 pcmcia network card
Software Environment: pcmcia-0.15, udev-135, linux-2.6.28
Problem Description: When nonstatic socket configuration is enabled (this is required on my hardware to work properly) pcmcia-socket-startup binary is installed in /sbin/, but udev rule points to /lib/udev/.

Steps to reproduce: compile with STARTUP = true and install

Patch is attached, assuming pcmcia-socket-startup should be placed at /lib/udev/.

Comment 1 Andrew Savchenko 2009-01-17 13:53:34 UTC

Created attachment 19868 [details]
proposed fix

Comment 2 Komuro 2009-01-17 19:17:08 UTC

Hi,

pcmcia-socket-startup is loaded by /etc/udev/rules.d/60-pcmcia.rules.

At your Distribution,
You should fix the  "/etc/udev/rules.d/60-pcmcia.rules" instead.



# if this is a PCMCIA socket which needs a resource database,
# pcmcia-socket-startup sets it up
ACTION=="add", SUBSYSTEM=="pcmcia_socket", \
                RUN+="/sbin/pcmcia-socket-startup"

Comment 3 Andrew Savchenko 2009-01-18 07:24:56 UTC

Hello,
(In reply to comment #2)
> Hi,
> 
> pcmcia-socket-startup is loaded by /etc/udev/rules.d/60-pcmcia.rules.
> 
> At your Distribution,
> You should fix the  "/etc/udev/rules.d/60-pcmcia.rules" instead.
[...]

But why this should be fixed at distribution? I dot mind of placing this binary at /sbin, but udev rules should be consistent with this.
/etc/udev/rules.d/60-pcmcia.rules are generated from udev/rules-* in the source tree. And udev/rules-nonstaticsocket contains as of version 0.15:

# if this is a PCMCIA socket which needs a resource database,
# pcmcia-socket-startup sets it up
SUBSYSTEM=="pcmcia_socket", \
                RUN+="/lib/udev/pcmcia-socket-startup"

And it should contain the text you noted above if pcmcia-socket-startup should be placed at /sbin in your opinion. Please fix this.

Comment 4 Komuro 2009-01-19 03:36:45 UTC

Hi,

Unfortunately, the pcmciautils maintainer Dominik Brodowski 
(linux@dominikbrodowski.net) does not respond these days.
and he only can access and change the source-code of the pcmciautils.


Please use the pcmciautils-014 instead.

Comment 5 Andrew Savchenko 2009-01-19 10:16:39 UTC

Hello,

(In reply to comment #4)
> Unfortunately, the pcmciautils maintainer Dominik Brodowski 
> (linux@dominikbrodowski.net) does not respond these days.
> and he only can access and change the source-code of the pcmciautils.

I see...
Well, currently I use 015 on my system. This bug is just fixed locally on my system. The goal of this report was to make solution available to another people.

Comment 6 Komuro 2009-07-27 12:59:02 UTC

Dominik is alive :)

Could you fix the pcmciautils-015 bug above
as soon as possible?


Komuro

Comment 7 Dominik Brodowski 2009-07-29 16:31:31 UTC

Created attachment 22522 [details]
proposed fix to pcmciautils

Proposed fix to pcmciautils -- add a udevhelperdir variable and evaluate it both for installation and for udev rules generation.