Bug 12401
| Summary: | 2.6.28 regression: xbacklight broken on ThinkPad X61s | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Rafael J. Wysocki (rjw) |
| Component: | Video(DRI - non Intel) | Assignee: | Tino Keitel (tino.keitel) |
| Status: | CLOSED DOCUMENTED | ||
| Severity: | normal | CC: | acpi-bugzilla, jbarnes, mjg59-kernel, rui.zhang, tino.keitel, tino.keitel, trenn |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.28 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Bug Depends on: | |||
| Bug Blocks: | 11808, 56331 | ||
|
Description
Rafael J. Wysocki
2009-01-10 13:45:57 UTC
Notify-Also : Zhang Rui <rui.zhang@intel.com> Notify-Also : Matthew Garrett <mjg59@srcf.ucam.org> Exposed by: commit 22c13f9d8179f4c9caecfcb60a95214562b9addc Author: Thomas Renninger <trenn@suse.de> Date: Fri Aug 1 17:37:54 2008 +0200 ACPI: video: Ignore devices that aren't present in hardware Signed-off-by: Thomas Renninger <trenn@suse.de> Acked-by: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Len Brown <len.brown@intel.com> First-Bad-Commit : 22c13f9d8179f4c9caecfcb60a95214562b9addc On my T61 2.6.28 is the kernel which made the brightness keys work :) The OpRegion stuff fixed all for me, and xbacklight works fine too. So maybe there's some stuff missing for x61 but on other X3100 it's working. Cheers, This looks like a duplicate of #12361. *** Bug 12361 has been marked as a duplicate of this bug. *** I remember Matthew and Rui saying that OpRegion does not always work due to IRQ problems with the Intel graphics driver? But I don't know how to find that out or how far it is solved. Hmm, Matthew does not have a bugzilla account... Matthias: Can you switch brightness by echoing brightness levels into the remaining backlight device's sysfs files? Tino, please attach the acpidump output. you can get it by using the latest pmtools at http://www.lesswatts.org/projects/acpi/utilities.php If this is still a problem, I strongly suspect that it's down to the 915 drm failing to get the IRQs. This has been a perennial problem - it's been fixed at various points. However, the ACPI change means that that systems that expect opregion support *must* have the i915 drm loaded to get working brightness control. The acpidump output is attached to bug #12361 If drm must be loaded, then this could be the real cause why xbacklight is not working, and why it worked the last time I tried 2.6.28.2. I disable drm most of the time, because it saves some power, and the X61s is a small and mobile laptop. Oh, right. There's no way to make this work correctly without drm. Can you try with that built? I guess this problem can also be fixed by the patch in http://bugzilla.kernel.org/show_bug.cgi?id=11259#c26 matthow, right? No. This bug relates to the fact that the DRM code is now required for working backlight control on some i915 machines. oops, sorry first, I mean the patch in comment#25 bug#11259. second, what we need is that i915 driver MUST be loaded on IGD OpRegion boxes to support backlight control, which the patch in comment#25 bug#11259 is not(it only fixes the oops when KMS is set). well, I don't think we got a proposal for this bug in the IRC yesterday. Matthew, any ideas? If users with opregion-based hardware don't build the i915 DRM they don't get backlight control. I don't think there's any other way of dealing with this. Distros will all be building with DRM, so I don't think it's a real problem. sounds good. close this bug as the backlight works if DRM is loaded (comment #11). |