Bug 120331
| Summary: | kmemleak: 1 new suspected memory leaks | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Mathieu Malaterre (mathieu.malaterre) |
| Component: | Other | Assignee: | drivers_other |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | bastienphilbert, frank.rowand |
| Priority: | P1 | ||
| Hardware: | PPC-32 | ||
| OS: | Linux | ||
| Kernel Version: | 4.5.5 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: | Test Patch | ||
Forgot to mention, the leak appears after each reboot.
[...]
[ 16.857534] input: Mouseemu virtual mouse as /devices/virtual/input/input6
[ 16.857576] device: 'mouse1': device_add
[ 16.857653] PM: Adding info for No Bus:mouse1
[ 16.859514] device: 'event6': device_add
[ 16.859609] PM: Adding info for No Bus:event6
[ 661.316052] kmemleak: 1 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
[...]
unreferenced object 0xdf532e60 (size 32):
comm "swapper", pid 1, jiffies 4294892300 (age 1993.532s)
hex dump (first 32 bytes):
6c 32 2d 63 61 63 68 65 23 31 00 dd e4 dd 1e c2 l2-cache#1......
ec d4 ba ce 04 ec cc de 8e 85 e9 ca c4 ec cc 9e ................
backtrace:
[<c02d3350>] kvasprintf+0x64/0xc8
[<c02d3400>] kasprintf+0x4c/0x5c
[<c0453814>] safe_name.isra.1+0x80/0xc4
[<c04545d8>] __of_attach_node_sysfs+0x6c/0x11c
[<c075f21c>] of_core_init+0x8c/0xf8
[<c0729594>] kernel_init_freeable+0xd4/0x208
[<c00047e8>] kernel_init+0x24/0x11c
[<c00158ec>] ret_from_kernel_thread+0x5c/0x64
I believe this might help in tracking the leak: [ 0.023043] device-tree: Duplicate name in PowerPC,G4@0, renamed to "l2-cache#1" See if the below patch fixes your memory leak. Created attachment 224311 [details]
Test Patch
Right :) How do I say it politely: [...] kfree(name); return name; [...] Anyway the real patch can be found here: https://patchwork.kernel.org/patch/9179049/ I am not sure why this was not approved yet. Ooops, apparently this was merged: https://lkml.org/lkml/2016/6/24/616 Then close this bug as fixed and no longer a known but fixed bug. d9fc88072332 of: fix memory leak related to safe_name() |
I keep getting memleak report on my PowerPC (Mac Mini G4) system. $ sudo cat /sys/kernel/debug/kmemleak unreferenced object 0xdf532e60 (size 32): comm "swapper", pid 1, jiffies 4294892300 (age 3148.652s) hex dump (first 32 bytes): 6c 32 2d 63 61 63 68 65 23 31 00 dd e4 df 1e c2 l2-cache#1...... e8 d4 ba ce 04 fe cd de 8e 85 e9 4b c6 ec c4 92 ...........K.... backtrace: [<c02d3350>] kvasprintf+0x64/0xc8 [<c02d3400>] kasprintf+0x4c/0x5c [<c0453814>] safe_name.isra.1+0x80/0xc4 [<c04545d8>] __of_attach_node_sysfs+0x6c/0x11c [<c075f21c>] of_core_init+0x8c/0xf8 [<c0729594>] kernel_init_freeable+0xd4/0x208 [<c00047e8>] kernel_init+0x24/0x11c [<c00158ec>] ret_from_kernel_thread+0x5c/0x64 It would be nice to check `safe_name` is freed in all cases.