Bug 11969

Summary:	the EC fixup solution for 2.6.27 kernel
Product:	ACPI	Reporter:	ykzhao (yakui.zhao)
Component:	EC	Assignee:	ykzhao (yakui.zhao)
Status:	REJECTED INVALID
Severity:	normal
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	v2.6.27 stable kernel	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	[patch 1/6]: simplify the EC mode switch [patch 2/4]: don't isse EC burst disable command if EC exits the burst mode [Patch 3/6]: Add the 2us delay before checking EC status while in polling mode [patch 4/6]: Disable the burst mode when returning incorrect ackonwledge byte [patch 5/6]: Add the delay in EC GPE handler to workaround EC GPE storm on some broken laptops [patch 6/6]: EC cleanup: delete the unsed code and data

Description ykzhao 2008-11-06 19:02:43 UTC

Latest working kernel version:
Earliest failing kernel version:
Distribution:
Hardware Environment:
Software Environment:
Problem Description: 
This is an EC fixup solution for 2.6.27 kernel. If EC driver can't work well on 2.6.27 kernel, please try the attached patch set and attach the output of dmesg.


Steps to reproduce:

Comment 1 ykzhao 2008-11-06 23:17:36 UTC

Created attachment 18717 [details]
[patch 1/6]: simplify the EC mode switch

simplify the EC mode switch. And when there is no EC GPE interrupt confirm, EC is switched to polling mode. But EC GPE is still enabled.
Only two tasks are done in the EC GPE handler:
     a. check the SCI_EVT flag bit
     b. wake up the waiting process

Comment 2 ykzhao 2008-11-06 23:19:24 UTC

Created attachment 18718 [details]
[patch 2/4]: don't isse EC burst disable command if EC exits the burst mode

If EC already exits the burst mode, don't issue the burst disable command.

Comment 3 ykzhao 2008-11-06 23:20:43 UTC

Created attachment 18719 [details]
[Patch 3/6]: Add the 2us delay before checking EC status while in polling mode

Comment 4 ykzhao 2008-11-06 23:22:24 UTC

Created attachment 18720 [details]
[patch 4/6]: Disable the burst mode when returning incorrect ackonwledge byte

Comment 5 ykzhao 2008-11-06 23:23:47 UTC

Created attachment 18721 [details]
[patch 5/6]: Add the delay in EC GPE handler to workaround EC GPE storm on some broken laptops

Comment 6 ykzhao 2008-11-06 23:25:55 UTC

Created attachment 18722 [details]
[patch 6/6]: EC cleanup: delete the unsed code and data

Comment 7 ykzhao 2008-11-06 23:27:44 UTC

If there exists the EC issue on the 2.6.27 kernel, please try the attached patch set and see whether the problem can be fixed.
   After the test, please attach the output of dmesg.
   Thanks.

Comment 8 ykzhao 2008-11-06 23:29:00 UTC

Please not close this bug. 
    Maybe when there exists  the EC issue on the 2.6.27 kernel, they can try the patch set.

Thanks.

Comment 9 ykzhao 2008-11-10 17:52:23 UTC

The bug will be rejected as the patch set has conflicts with the patch from EC maintainer.

Thanks.