Bug 11961

Summary: TSC-10 DM USB touchscreen driver assume 2-byte response from controller
Product: Drivers Reporter: Nuno Lucas (ntlucas)
Component: Input DevicesAssignee: drivers_input-devices
Severity: normal CC: akpm
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: Subsystem:
Regression: No Bisected commit-id:

Description Nuno Lucas 2008-11-05 09:44:56 UTC
Latest working kernel version: never
Earliest failing kernel version:
Distribution: kernel.org
Hardware Environment: x86
Software Environment:
Problem Description:

The usbtouchscreen module implements a driver for the TSC-10 DM USB touchscreen controllers, but assumes a 2-byte response for the CMD_RESET and CMD_RATE commands, when they can be only a single byte when no EEPROM is connected.

The following patch in the dmc_tsc10_init() function (which fixes the problem) should make it clear:

diff -urpN linux- linux-
--- linux-     2008-10-22 22:19:25.000000000 +0100
+++ linux-  2008-11-05 17:01:06.000000000 +0000
@@ -407,7 +407,8 @@ static int dmc_tsc10_init(struct usbtouc
                              0, 0, buf, 2, USB_CTRL_SET_TIMEOUT);
        if (ret < 0)
                return ret;
-       if (buf[0] != 0x06 || buf[1] != 0x00)
+       printk( "dmc_tsc10_init: RESET=>'%02X%02X\n'", buf[0], buf[1]  );
+       if (buf[0] != 0x06 /*|| buf[1] != 0x00*/)
                return -ENODEV;

        /* set coordinate output rate */
@@ -418,7 +419,8 @@ static int dmc_tsc10_init(struct usbtouc
                              TSC10_RATE_150, 0, buf, 2, USB_CTRL_SET_TIMEOUT);
        if (ret < 0)
                return ret;
-       if ((buf[0] != 0x06 || buf[1] != 0x00) &&
+       printk( "dmc_tsc10_init: RATE=>'%02X%02X\n'", buf[0], buf[1]  );
+       if ((buf[0] != 0x06 /*|| buf[1] != 0x00*/) &&
            (buf[0] != 0x15 || buf[1] != 0x01))
                return -ENODEV;

The driver worked with an earlier controller revision, but new revisions of the controller (now discontinued, but still on sale) fail.

It seems the problem is that the early controller had the SEL4/EEPROM-CS pin high, but the new controller has it down, making the response different.

Without the fix, the controller would answer the single byte 0x06 (ACK), making the init fail with -ENODEV because buf[1] is 0xFF (as initialized before).

As the single byte is the only thing we need to check it was ok, there is no need to verify the second byte.

The [0x15 0x01] case is the NAK [0x15] response for when there is no data in the EEPROM [bit-0 of second byte set], so I let that be, as I don't have any controller with an EEPROM.

With this patch, both the earlier and latest controller work the same.
Comment 1 Andrew Morton 2008-11-05 10:27:01 UTC
Please submit patches via email.  Documentation/SubmittingPatches
describes the process.  Suitable recipients for this patch are

Dmitry Torokhov <dtor@mail.ru>
Andrew Morton <akpm@linux-foundation.org>

Comment 2 Nuno Lucas 2008-11-06 07:32:41 UTC
Patch sent via email:

Comment 3 Nuno Lucas 2009-04-08 12:43:28 UTC
I'm closing this as the patch was applied to 2.6.29.