Bug 119261
| Summary: | Boot EC requirement - Lid no longer wakes system from suspend | ||
|---|---|---|---|
| Product: | ACPI | Reporter: | Gabriele Mazzotta (gabriele.mzt) |
| Component: | ACPICA-Core | Assignee: | Lv Zheng (lv.zheng) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | normal | CC: | gabriele.mzt, rjw, rui.zhang |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 4.7-rc1 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Attachments: |
acpidump output
dmesg [PATCH] ACPI / EC: Restore boot_ec support for the EC device described in DSDT |
||
|
Description
Gabriele Mazzotta
2016-05-30 15:14:44 UTC
Created attachment 218251 [details]
dmesg
I'm sorry, dell-wmi doesn't work even with the above commits reverted. Probably I saw it working again while bisecting and got confused. I'll see if I can find what broke it and open a separate bug report if unrelated. (In reply to Gabriele Mazzotta from comment #2) > I'm sorry, dell-wmi doesn't work even with the above commits reverted. > Probably I saw it working again while bisecting and got confused. I'll see > if I can find what broke it and open a separate bug report if unrelated. OK. Probably because of a different issue. Please also upload the acpidump of the machine here for us to confirm. If you are using 4.7-rc1, I do know 1 issue that can be fixed by the following patch: https://patchwork.kernel.org/patch/9137615/ You can try again with this patch applied. Thanks in advance. Best regards -Lv > Please also upload the acpidump of the machine here for us to confirm. It's already uploaded. > If you are using 4.7-rc1, I do know 1 issue that can be fixed by the > following patch: > https://patchwork.kernel.org/patch/9137615/ > You can try again with this patch applied. This seems to make no difference regarding the issue here reported. Yes, I saw the acpidump. After extracting it, I got no ECDT. So the problem is not ECDT related. From the dmesg, I can see: [ 0.410275] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug [ 0.421787] ACPI Error: No handler for Region [ECRM] (ffff88021688a3f0) [EmbeddedControl] (20160422/evregion-166) [ 0.421792] ACPI Error: Region EmbeddedControl (ID=3) has no handler (20160422/exfldio-299) [ 0.421796] ACPI Error: Method parse/execution failed [\_SB.LID0._PSW] (Node ffff88021688f4d8), AE_NOT_EXIST (20160422/psparse-542) [ 0.421802] ACPI: _PSW execution failed ... [ 0.437173] ACPI : EC: GPE = 0xa, I/O: command/status = 0x66, data = 0x62 [ 0.437175] ACPI : EC: EC started This looks like the order issue. We have plan to stop implementing EC opregion as a driver, but handle it by default using an operation region handler. This should be able to fix this issue. Let me try this and post the fix here. Thanks -Lv Created attachment 218601 [details]
[PATCH] ACPI / EC: Restore boot_ec support for the EC device described in DSDT
Please give this fix a try.
Thanks
-Lv
(In reply to Lv Zheng from comment #6) > Created attachment 218601 [details] > [PATCH] ACPI / EC: Restore boot_ec support for the EC device described in > DSDT > > Please give this fix a try. > > Thanks > -Lv This fixed the problem, thanks. Thanks for the confirmation. I'll send it to the upstream. Best regards -Lv (In reply to Lv Zheng from comment #8) > Thanks for the confirmation. > I'll send it to the upstream. > > Best regards > -Lv I've just noticed that part of my email address got lost in the Reported-by string. (In reply to Gabriele Mazzotta from comment #9) > (In reply to Lv Zheng from comment #8) > > Thanks for the confirmation. > > I'll send it to the upstream. > > > > Best regards > > -Lv > > I've just noticed that part of my email address got lost in the Reported-by > string. Ah, yes! I'll send an update to the mailing list. Thanks -Lv Let me close it because the fix has been upstreamed: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=dcf15cb Thanks -Lv |