Bug 1186

Summary: PCI Link programming hangs system if USB - TMTA/ALi - PIC
Product: ACPI Reporter: Greg Kroah-Hartman (greg)
Component: Config-InterruptsAssignee: Len Brown (lenb)
Severity: high CC: acpi-bugzilla, adq_dvb, alex, nickpiggin
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.0-test3-bk3 Subsystem:
Regression: --- Bisected commit-id:
Attachments: acpidump on 2.6.0-test3-bk2
lspci -v on 2.6.0-test3-bk2
/proc/interrupts on 2.6.0-test3-bk2
dmesg on 2.6.0-test3-bk2
dmesg on 2.6.0-test3-bk3
/proc/interrupts on 2.6.0-test3-bk3
lspci -v on 2.6.0-test3-bk3
Using orginal active irq to set up PCI Interrupt Link
proposed pci_link.c patch

Description Greg Kroah-Hartman 2003-09-04 17:17:11 UTC
In kernel 2.6.0-test3-bk3 ACPI PCI interrupt routing logic changed which
causes any USB accesses on my machine to lock up the kernel.

This is on a Fujitsu P2120 laptop.

What logs would be helpful with this problem?
Comment 1 Shaohua 2003-09-08 19:27:12 UTC
please attach acpidmp, lspci, dmesg, and /proc/interrupts. thanks a lot!
Comment 2 Greg Kroah-Hartman 2003-09-08 20:54:18 UTC
Created attachment 842 [details]
acpidump on 2.6.0-test3-bk2
Comment 3 Greg Kroah-Hartman 2003-09-08 20:55:07 UTC
Created attachment 843 [details]
lspci -v on 2.6.0-test3-bk2
Comment 4 Greg Kroah-Hartman 2003-09-08 20:55:39 UTC
Created attachment 844 [details]
/proc/interrupts on 2.6.0-test3-bk2
Comment 5 Greg Kroah-Hartman 2003-09-08 20:56:09 UTC
Created attachment 845 [details]
dmesg on 2.6.0-test3-bk2
Comment 6 Greg Kroah-Hartman 2003-09-08 21:11:36 UTC
Created attachment 846 [details]
dmesg on 2.6.0-test3-bk3
Comment 7 Greg Kroah-Hartman 2003-09-08 21:12:16 UTC
Created attachment 847 [details]
/proc/interrupts on 2.6.0-test3-bk3
Comment 8 Greg Kroah-Hartman 2003-09-08 21:12:59 UTC
Created attachment 848 [details]
lspci -v on 2.6.0-test3-bk3
Comment 9 Greg Kroah-Hartman 2003-09-08 21:13:40 UTC
all are attached.  If anything else is needed, please let me know.
Comment 10 Shaohua 2003-09-08 22:22:53 UTC
does access to any USB port cause hang? can netcard work? can you verify if 
USB can work with acpi=off, and attach the dmesg and /proc/interrupts? Thanks 
a lot.
Comment 11 Greg Kroah-Hartman 2003-09-08 22:41:40 UTC
If I plug a USB device into the machine, it locks up hard. So yes, any USB access
causes the crash.

And no, sorry, I can't get nmi_watchdog to work on this box, so I can't see
where the kernel is hung at.

acpi=off never worked in the past.  I can try it again tomorrow if you _really_
think that it will help out.
Comment 12 Luming Yu 2003-09-16 04:06:36 UTC
Could you please explain "In kernel 2.6.0-test3-bk3 ACPI PCI interrupt routing
logic changed which causes any USB accesses on my machine to lock up the kernel."
Did you mean some kernel works before?

Is it possible to setup a serial console to catch dmesg when plugging a USB
mouse and pulling out a USB mouse ? (Please turn USB debug option and ACPI debug
option ON ). Thanks a lot!

Comment 13 Greg Kroah-Hartman 2003-09-16 09:06:31 UTC
I mean that 2.6.0-test3-bk2 works, and that 2.6.0-test3-bk3 does not work.  I
did not submit _any_ USB changes into that kernel release (and if you look at
the diff, you will see that there are no usb changes there.)

I do not have a serial port on this machine, and I do not have nmi_watchdog
support either, so sorry, I can not catch an oops message.

And if I plug a USB device into the machine, it hangs, I don't have to unplug
it.  There are no USB debug messages printed.  I am assuming that this is
because the USB interrupt comes in to the wrong vector.

And no CONFIG_USB_DEBUG doesn't show anything either :(
Comment 14 Luming Yu 2003-09-16 21:10:47 UTC
Created attachment 903 [details]
Using orginal active irq to set up PCI Interrupt Link 

I hope it could address your problem. Thanks a lot.
Comment 15 Greg Kroah-Hartman 2003-09-17 08:56:10 UTC
Ugh, I have already posted on the linux-acpi and lkml mailing lists that the
patch just posted there works for me.

I would not suggest you add any more #ifdefs to the acpi code as with the patch
you have just proposed.

So please just forward on the patch from Andrew de Quincey to Linus and Marcelo.
Comment 16 Greg Kroah-Hartman 2003-09-29 10:01:16 UTC
*** Bug 1286 has been marked as a duplicate of this bug. ***
Comment 17 Len Brown 2003-09-29 21:41:12 UTC
*** Bug 1257 has been marked as a duplicate of this bug. ***
Comment 18 Len Brown 2003-09-29 22:00:47 UTC
The patch from Andrew de Quincy is 
available now in these bitkeeper trees: 
It is also available as a plain pach "acpi_pci_link_allocate" here: 
Comment 19 Len Brown 2003-10-02 22:13:15 UTC
this fix is available in... 
Comment 20 Len Brown 2003-11-04 21:49:40 UTC
Created attachment 1354 [details]
proposed pci_link.c patch

Unfortunately the previous patch for this issue had some side-effects
on other systems.  Please test the attached pci_link.c patch
and gather the dmesg, /proc/interrupts, and if USB works or not.

If the patch fails to boot, please try booting it with cmdline

Comment 21 Len Brown 2003-11-20 21:09:31 UTC
We didn't have to change our policy of leaving active PIC-mode interrupts alone after all. 
(though we did add a cmdline to re-program them, and we did change 
 our policy in APIC mode). 
So I'm re-closing this one.