Bug 11827
Summary: | suspend broken on powerbook5,6 | ||
---|---|---|---|
Product: | Drivers | Reporter: | Johannes Berg (johannes) |
Component: | Input Devices | Assignee: | Jiri Slaby (jirislaby) |
Status: | CLOSED CODE_FIX | ||
Severity: | normal | CC: | benh, jirislaby, rjw, schwab |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.28-rc1 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Bug Depends on: | |||
Bug Blocks: | 7216, 11808 | ||
Attachments: | suspend oops fixup |
Description
Johannes Berg
2008-10-25 05:07:32 UTC
May it be a graphics issue? We've had some reports indicating a graphics issue wrt suspend on some x86 boxes. Anyway, if you can bisect, please do that. Not sure, I never had problems with graphics. I'll try to bisect next week. # bad: [c500c9714011edab021591340042787722db9cf0] HID: hid, make parsing event driven Oops on suspend: address 0xc44 NIP hid_suspend+0x2c/0x70 LR usb_suspend_both+0xcc/0x2cc --> set_bit(HID_SUSPENDED, &usbhid->iofl); usbhid is NULL Thanks! Annotation for the list of recent regressions: Caused by: commit c500c9714011edab021591340042787722db9cf0 Author: Jiri Slaby <jirislaby@gmail.com> Date: Fri May 16 11:49:16 2008 +0200 HID: hid, make parsing event driven Signed-off-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Jiri Kosina <jkosina@suse.cz> damn. I also just found it after spending a day bisecting and getting nowhere, and then remembering no_console_suspend... anyone got a fix? http://johannes.sipsolutions.net/files/dsc_2446.jpg (In reply to comment #5) > damn. I also just found it after spending a day bisecting and getting > nowhere, > and then remembering no_console_suspend... anyone got a fix? > > http://johannes.sipsolutions.net/files/dsc_2446.jpg Jiri Slaby is working on patch right now. Created attachment 18453 [details]
suspend oops fixup
Could you try the attached patch?
Works here. Handled-By : Jiri Slaby <jirislaby@gmail.com> Patch : http://marc.info/?l=linux-kernel&m=122510631211237&w=4 Merged as commit 3d5afd324a4bf9f64f59599bf1e93cd7dd1dc97a |