Bug 117461

Summary: Log improvement - "ACPI: %u ACPI AML tables successfully acquired and loaded" should be KERN_INFO
Product: ACPI Reporter: Andy Lutomirski (luto)
Component: OtherAssignee: Lv Zheng (lv.zheng)
Status: CLOSED CODE_FIX    
Severity: normal CC: dsmythies, yu.c.chen
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 4.5 Tree: Mainline
Regression: No
Attachments: add KERN_INFO for acpi_info
[PATCH] ACPICA: Utilities: Introduce facility to allow Linux to set correct logging levels

Description Andy Lutomirski 2016-05-01 02:22:00 UTC
It's currently KERN_WARNING.  KERN_WARNING should be used for warnings, not success messages.

I looked at the code, found that it's ACPI_INFO, and then got lost in all the indirection when trying to figure out where KERN_WARNING comes from.
Comment 1 Chen Yu 2016-05-07 08:01:57 UTC
This is because either ACPI_INFO or ACPI_WARNING actually invoke
printk(KERN_CONT) at last, and the default message level of printk is KERN_WARNING. 
It looks like we might need to change the implementation of ACPI_INFO,ACPI_WARNING,etc to comply with the loglevel context.
Comment 2 Chen Yu 2016-05-07 11:56:34 UTC
Created attachment 215431 [details]
add KERN_INFO for acpi_info

This patch is to add KERN_INFO prefix for acpi_info
Comment 3 Lv Zheng 2016-05-11 03:04:04 UTC
Created attachment 215901 [details]
[PATCH] ACPICA: Utilities: Introduce facility to allow Linux to set correct logging levels

OK.

Please try the attached improvement.

Thanks
-Lv
Comment 4 Lv Zheng 2016-05-20 03:09:15 UTC
Patch upstreamed to the ACPICA repo.
Closing...
Comment 5 Doug Smythies 2017-02-15 01:08:43 UTC
Please see bug 193531, where there seems to be some side effects from the patch.