Bug 115181

Summary:	Asus N750JV sound problems
Product:	Drivers	Reporter:	Bobby Mihalca (bobbymihalca)
Component:	Sound(ALSA)	Assignee:	Jaroslav Kysela (perex)
Status:	RESOLVED CODE_FIX
Severity:	enhancement	CC:	tiwai
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.4.5	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	fixes proposed patch Asus N750JV external subwoofer fixup Asus N750JV headphone white noise fixup Asus N550JV headphone white noise fixup, bug 70821

Description Bobby Mihalca 2016-03-23 10:28:29 UTC

Created attachment 210341 [details]
fixes

1. Subwoofer does not work out of the box on my Asus N750JV.
2. There is constant white noise from headphones (same as Bug 70821 for Asus N550JV).

I have a patch that fixes both problems.
1. is fixed by applying same config fix as for N550JV
2. is fixed by muting by amp. The same fixup sould work for N550JV and close bug 70821

Comment 1 Bobby Mihalca 2016-03-23 10:50:46 UTC

Created attachment 210351 [details]
proposed patch

Comment 2 Takashi Iwai 2016-03-23 10:54:19 UTC

(In reply to Bobby Mihalca from comment #0)
> Created attachment 210341 [details]
> fixes
> 
> 1. Subwoofer does not work out of the box on my Asus N750JV.
> 2. There is constant white noise from headphones (same as Bug 70821 for Asus
> N550JV).
> 
> I have a patch that fixes both problems.
> 1. is fixed by applying same config fix as for N550JV
> 2. is fixed by muting by amp. The same fixup sould work for N550JV and close
> bug 70821

The patch looks good to me.  Could you provide the proper changelog and your sign-off to get it merged into upstream?  See Documentation/SubmittingPatches for details.

We can add one more patch to apply your quirk for N550JV later, too.

Comment 3 Bobby Mihalca 2016-03-23 11:59:05 UTC

Created attachment 210401 [details]
Asus N750JV external subwoofer fixup

Comment 4 Bobby Mihalca 2016-03-23 11:59:40 UTC

Created attachment 210411 [details]
Asus N750JV headphone white noise fixup

Comment 5 Bobby Mihalca 2016-03-23 12:05:12 UTC

Created attachment 210421 [details]
Asus N550JV headphone white noise fixup, bug 70821

this is untested, but given how almost identical the hardware is and bug 70821 it should work.
even if is not applyed someone with Asus N550JV and headphone white noise may find it here and maybe test it.

Comment 6 Takashi Iwai 2016-03-23 15:10:41 UTC

Thanks.  The patches were submitted and queued for merge now.