Bug 114401

Summary: crash dump aic94xx
Product: SCSI Drivers Reporter: Bulanov Maxim (bulanovmg)
Component: AIC94XXAssignee: scsi_drivers-aic94xx
Status: RESOLVED CODE_FIX    
Severity: normal CC: bastienphilbert
Priority: P1    
Hardware: x86-64   
OS: Linux   
Kernel Version: 4.4.3-gentoo #1 SMP Mon Feb 29 16:03:39 MSK 2016 x86_64 Subsystem:
Regression: No Bisected commit-id:

Description Bulanov Maxim 2016-03-11 13:47:03 UTC 
[350548.713114] ------------[ cut here ]------------
[350548.713130] kernel BUG at drivers/scsi/aic94xx/aic94xx_hwi.h:344!
[350548.713144] invalid opcode: 0000 [#1] SMP
[350548.713159] Modules linked in: w83793 w83627hf hwmon_vid aic94xx
[350548.713184] CPU: 1 PID: 1372 Comm: scsi_eh_6 Tainted: G        W       4.4.3-gentoo #1
[350548.713200] Hardware name: Supermicro X7DB8/X7DB8, BIOS 2.1c 07/04/2011
[350548.713215] task: ffff8800bb992340 ti: ffff8800bb168000 task.ti: ffff8800bb168000
[350548.713231] RIP: 0010:[<ffffffffa000b9e4>]  [<ffffffffa000b9e4>] asd_abort_task+0x444/0x450 [aic94xx]
[350548.713257] RSP: 0018:ffff8800bb16bd18  EFLAGS: 00010283
[350548.713269] RAX: 0000000000000246 RBX: ffff88007b0d7840 RCX: 0000000000000000
[350548.713284] RDX: 0000000000000001 RSI: 0000000000000246 RDI: ffff8800bbbc6808
[350548.713299] RBP: ffff8800bb16bd90 R08: ffff8800bb168000 R09: 0000000000000000
[350548.713314] R10: 0000000000000000 R11: 0000000000000004 R12: ffff8800b9d18000
[350548.713329] R13: ffff880034e0bcc0 R14: ffff8800bbbc6808 R15: ffff8800bb16bd48
[350548.713590] FS:  0000000000000000(0000) GS:ffff88013fc80000(0000) knlGS:0000000000000000
[350548.713853] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[350548.713989] CR2: 00007fa7f9e49000 CR3: 0000000001e09000 CR4: 00000000000406e0
[350548.714086] Stack:
[350548.714391]  0000000000000000 0000880000000000 ffffffff00000000 ffff880000000000
[350548.714391]  ffff8800bb16bd38 ffff8800bb16bd38 ffff880000000000 ffff880000000000
[350548.714391]  ffff8800bb16bd58 ffff8800bb16bd58 0000000000000005 ffff8800bb16bde8
[350548.714391] Call Trace:
[350548.714391]  [<ffffffff8159dd6e>] sas_scsi_recover_host+0x42e/0xb60
[350548.714391]  [<ffffffff81584eb2>] scsi_error_handler+0xa2/0x520
[350548.714391]  [<ffffffff81806968>] ? __schedule+0x348/0x8b0
[350548.714391]  [<ffffffff81584e10>] ? scsi_eh_get_sense+0x170/0x170
[350548.714391]  [<ffffffff81584e10>] ? scsi_eh_get_sense+0x170/0x170
[350548.714391]  [<ffffffff81095154>] kthread+0xc4/0xe0
[350548.714391]  [<ffffffff81095090>] ? kthread_worker_fn+0x140/0x140
[350548.714391]  [<ffffffff8180a91f>] ret_from_fork+0x3f/0x70
[350548.714391]  [<ffffffff81095090>] ? kthread_worker_fn+0x140/0x140
[350548.714391] Code: fe ff ff b8 02 00 00 00 eb e9 8b 45 90 85 c0 75 e2 4c 89 e7 e8 de f4 ff ff 89 45 88 e9 cf fe ff ff b8 f4 ff ff ff e9 06 fe ff ff <0f> 0b c7 45 88 05 00 00 00 eb 99 90 55 31 c9 ba 02 00 00 00 48
[350548.714391] RIP  [<ffffffffa000b9e4>] asd_abort_task+0x444/0x450 [aic94xx]
[350548.714391]  RSP <ffff8800bb16bd18>
[350548.714978] ---[ end trace ce789fd9c515a590 ]---
Comment 1 [account disabled by administrator] 2016-04-06 19:26:43 UTC 
out_done:
         tascb->completion = NULL;
         if (res == TMF_RESP_FUNC_COMPLETE) {
                 task->lldd_task = NULL;
add these line:
                 list_del_init(&ascb->list);
                 mb();
                 asd_ascb_free(tascb);
         }
         ASD_DPRINTK("task 0x%p aborted, res: 0x%x\n", task, res);
         return res;
 
  out_free:
same here:
         list_del_init(&ascb->list);
         asd_ascb_free(ascb);
         ASD_DPRINTK("task 0x%p aborted, res: 0x%x\n", task, res);
         return res;
}
Tell me if this fixes your issue.
Comment 2 Bulanov Maxim 2016-04-07 18:29:20 UTC 
Thank you, look like this help me. I not get crash more, just error.

[ 1193.833040] sas: Enter sas_scsi_recover_host busy: 1 failed: 1
[ 1193.833047] sas: trying to find task 0xffff8800bb0e7700
[ 1193.833049] sas: sas_scsi_find_task: aborting task 0xffff8800bb0e7700
[ 1193.833153] sas: sas_scsi_find_task: querying task 0xffff8800bb0e7700
[ 1193.833155] sas: sas_scsi_find_task: aborting task 0xffff8800bb0e7700
[ 1193.833247] sas: sas_scsi_find_task: querying task 0xffff8800bb0e7700
[ 1193.833249] sas: sas_scsi_find_task: aborting task 0xffff8800bb0e7700
[ 1193.833350] sas: sas_scsi_find_task: querying task 0xffff8800bb0e7700
[ 1193.833355] sas: sas_scsi_find_task: aborting task 0xffff8800bb0e7700
[ 1193.833456] sas: sas_scsi_find_task: querying task 0xffff8800bb0e7700
[ 1193.833458] sas: sas_scsi_find_task: aborting task 0xffff8800bb0e7700
[ 1193.833554] sas: sas_scsi_find_task: querying task 0xffff8800bb0e7700
[ 1193.833556] sas: task 0xffff8800bb0e7700 is not at LU: I_T recover
[ 1193.833558] sas: I_T nexus reset for dev 5003048000257da6
[ 1194.334256] sas: I_T 5003048000257da6 recovered
[ 1194.334279] sas: ata7: end_device-6:0: dev error handler
[ 1194.334291] sas: ata8: end_device-6:1: dev error handler
[ 1194.334297] sas: ata9: end_device-6:2: dev error handler
[ 1194.334301] sas: ata10: end_device-6:3: dev error handler
[ 1194.334307] sas: ata11: end_device-6:4: dev error handler
[ 1194.334314] sas: ata12: end_device-6:5: dev error handler
[ 1194.334315] sas: ata13: end_device-6:6: dev error handler
[ 1194.334322] sas: ata14: end_device-6:7: dev error handler
[ 1194.334327] ata14.00: retrying FLUSH 0xea Emask 0x0
Comment 3 [account disabled by administrator] 2016-04-07 18:51:02 UTC 
That seems to be due to a WARN_ON that only triggers once. Does this work OK now besides the warning.