Bug 114251

In function beiscsi_create_cqs() at drivers/scsi/be2iscsi/be_main.c:line 3307, if pci_alloc_consistent() at line 3328 fails, function beiscsi_create_cqs() will return the value of variable ret, which is 0 indicating success defined at line 3310.But,function beiscsi_create_cqs() should propagate the error and return the error to its caller functions.
The related code snippets in beiscsi_create_cqs are as following.
beiscsi_create_cqs @@ drivers/scsi/be2iscsi/be_main.c:line 3307

3307 static int beiscsi_create_cqs(struct beiscsi_hba *phba,
3308                              struct hwi_context_memory *phwi_context)
3309 {
3310         unsigned int i, num_cq_pages;
3311         int ret = 0;
3312         struct be_queue_info *cq, *eq;
3313         struct be_dma_mem *mem;
3314         struct be_eq_obj *pbe_eq;
3315         void *cq_vaddress;
3316         dma_addr_t paddr;
3317 
3318         num_cq_pages = PAGES_REQUIRED(phba->params.num_cq_entries * \
3319                                       sizeof(struct sol_cqe));
3320 
3321         for (i = 0; i < phba->num_cpus; i++) {
3322                 cq = &phwi_context->be_cq[i];
3323                 eq = &phwi_context->be_eq[i].q;
3324                 pbe_eq = &phwi_context->be_eq[i];
3325                 pbe_eq->cq = cq;
3326                 pbe_eq->phba = phba;
3327                 mem = &cq->dma_mem;
3328                 cq_vaddress = pci_alloc_consistent(phba->pcidev,
3329                                                      num_cq_pages * PAGE_SIZE,
3330                                                      &paddr);
3331                 if (!cq_vaddress)
3332                         goto create_cq_error;
		  	...
3354         }
		  	...
3355         return 0;
3356 
3357 create_cq_error:
3358         for (i = 0; i < phba->num_cpus; i++) {
3359                 cq = &phwi_context->be_cq[i];
3360                 mem = &cq->dma_mem;
3361                 if (mem->va)
3362                         pci_free_consistent(phba->pcidev, num_cq_pages
3363                                             * PAGE_SIZE,
3364                                             mem->va, mem->dma);
3365         }
3366         return ret;
3367 
3368 }
	
Generally, when the call to pci_alloc_consistent() fails, the return value of caller functions 
should be different from another return value set when the call to pci_alloc_consistent() succeeds, 
like the following codes in another file.
ilo_ccb_setup @@ drivers/net/ethernet/hp/hp100.c:line 726
258 static int ilo_ccb_setup(struct ilo_hwinfo *hw, struct ccb_data *data, int slot)
259 {
			  ...
271         data->dma_va = pci_alloc_consistent(hw->ilo_dev, data->dma_size,
272                                             &data->dma_pa);
273         if (!data->dma_va)
274                 return -ENOMEM;
			  ...
    }