Bug 11326
| Summary: | iwl3945: Error: Response NULL in 'REPLY_ADD_STA', followed by fault | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Jim Paris (jim) |
| Component: | network-wireless | Assignee: | Zhu Yi (yi.zhu) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | marcus, raa.lkml |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.27-rc3 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: | patch to try | ||
|
Description
Jim Paris
2008-08-13 21:36:41 UTC
Hmmm...assigning to Zhu Yi based on iwl3945 error message... Created attachment 17258 [details]
patch to try
Please see if this patch fix the problem.
I had a very similar crash and tried your patch. After a day of light use, I couldn't reproduce it. It may have helped. I continue using it... It certainly helped with the crash: I had the error message once, but no crash. What does the patch actually do? What is canceled (according the labels name)? (In reply to comment #4) > It certainly helped with the crash: I had the error message once, but > no crash. What does the patch actually do? What is canceled (according > the labels name)? > The patch has been submitted upstream. The commit message explains the details you are interested in. http://marc.info/?l=linux-wireless&m=123143878214020&w=2 Could you please close this bug? According to the last message (attached) from Zhu Yi <yi.zhu@intel.com> it is not fixed, just worked around: From: Zhu Yi <yi.zhu@intel.com> To: Alex Riesen <raa.lkml@gmail.com> Cc: "Chatre, Reinette" <reinette.chatre@intel.com>, "linville@tuxdriver.com" <linville@tuxdriver.com>, "ipw3945-devel@lists.sourceforge.net" <ipw3945-devel@lists.sourceforge.net>, Jim Paris <jim@jtan.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org> In-Reply-To: <81b0412b0812250640t5d6180dct31d8cd941e06ef50@mail.gmail.com> References: <alpine.LFD.2.00.0812241540170.3535@localhost.localdomain> <81b0412b0812250640t5d6180dct31d8cd941e06ef50@mail.gmail.com> Date: Fri, 26 Dec 2008 10:27:02 +0800 Message-Id: <1230258422.27521.9.camel@debian> On Thu, 2008-12-25 at 22:40 +0800, Alex Riesen wrote: > iwl3945 is still broken as described in > > http://bugzilla.kernel.org/show_bug.cgi?id=11326 > > It is actually quite annoying, as it prevents shutdown when crashed. > The bug discussion mentions a fix (which looks like a workaround, > because there is still a scary message in the log). But at least > the system can be safely shut down. The patch should be a valid fix for the symptom. But we haven't find the root cause yet. Will submit the patch to wireless-testing. Thanks, -yi May I suggest _not_ to close the _bug_ until it is actually _fixed_? (Ok not worked around, the crash in aftereffect was fixed. Which still does not fix the bug with "Response NULL in 'REPLY_ADD_STA'") OTOH, how about opening another bug for specifically this "NULL in REPLY_ADD_STA" problem? (assuming the problem is not found yet) Jim or admin, The patch fixing the BUG is now in wireless-testing. Could you please close this bug? Sorry for the delay -- yes, this does fix the crash so I think the bug can be closed. Thanks. |