Bug 112121
| Summary: | Some PCIe options cause devices to be removed after suspend | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Mike Lothian (mike) |
| Component: | PCI | Assignee: | drivers_pci (drivers_pci) |
| Status: | RESOLVED PATCH_ALREADY_AVAILABLE | ||
| Severity: | normal | CC: | bastienphilbert, bjorn, kbusch, korolev.srg, nickkrause, pmenzel+bugzilla.kernel.org |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 4.5-rc2 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: |
Dmesg showing PCIe device removals
Dmesg with ignore_loglevel Dot config |
||
I did try and reply to the last email but I can't figure out how to send plaintext emails using Google Inbox I've just tested this again, I enabled PCI Hotplug & PCIe Hotplug and nothing - then I noticed I hadn't enabled the ACPI Hotplug driver - once I did the issue re-appeared I then had to use testdisk to restore my partition table :'( I've got a new dmesg out which I'll attach now along with my .config Created attachment 203621 [details]
Dmesg with ignore_loglevel
Created attachment 203631 [details]
Dot config
Try changing this lines:
[PCI_D3hot] = ACPI_STATE_D3_HOT,
to:
[PCI_D3hot] = ACPI_STATE_D3_COLD,
as you may be having a issue with ACPI states being screwed up during your suspend due to this change.
Work travel 3/23 - 3/24, responses will be delayed. Please contact Jon Derrick if needing a quicker response. Thanks, Keith Sorry for the delay - where about should I be changing that? Greetings Mike, Seems that's not the issue I am wondering if due to not enabling CONFIG_ACPI_PCI_SLOT. If not then reply and we can take it for there. I tried enabling CONFIG_ACPI_PCI_SLOT but the laptop refuses to boot with it, it complains about being unable to find systemd I've also tried changing
[PCI_D3hot] = ACPI_STATE_D3_HOT,
to:
[PCI_D3hot] = ACPI_STATE_D3_COLD,
in drivers/pci/pci-acpi.c, but it had no effect
Patch https://patchwork.kernel.org/patch/10212201/ fixes this issue, it also fixes USB-C detection and the CONFIG_ACPI_PCI_SLOT option now works too |
Created attachment 203091 [details] Dmesg showing PCIe device removals I was having issues with suspend, when the machine was being resumed iommu started removing devices - including my PCIe NVMe drive which contained my root partition The problem showed up with: [*] PCI support [*] Support mmconfig PCI config space access [*] PCI Express Port Bus support [*] PCI Express Hotplug driver [*] Root Port Advanced Error Reporting support [*] PCI Express ECRC settings control < > PCIe AER error injector support -*- PCI Express ASPM control [ ] Debug PCI Express ASPM Default ASPM policy (BIOS default) ---> [*] Message Signaled Interrupts (MSI and MSI-X) [ ] PCI Debugging [*] Enable PCI resource re-allocation detection < > PCI Stub driver [*] Interrupts on hypertransport devices [ ] PCI IOV support [*] PCI PRI support -*- PCI PASID support PCI host controller drivers ---- < > PCCard (PCMCIA/CardBus) support ---- [*] Support for PCI Hotplug ---> < > RapidIO support This is what I have now: [*] PCI support [*] Support mmconfig PCI config space access [*] PCI Express Port Bus support [ ] Root Port Advanced Error Reporting support -*- PCI Express ASPM control [ ] Debug PCI Express ASPM Default ASPM policy (BIOS default) ---> [*] Message Signaled Interrupts (MSI and MSI-X) [*] PCI Debugging [ ] Enable PCI resource re-allocation detection < > PCI Stub driver [*] Interrupts on hypertransport devices [ ] PCI IOV support [ ] PCI PRI support [ ] PCI PASID support PCI host controller drivers ---- < > PCCard (PCMCIA/CardBus) support ---- [ ] Support for PCI Hotplug ---- < > RapidIO support I tried disabling the iommu driver first but it had no effect If people are interested I could play with the above options to see which one causes the issue