Bug 11188
Summary: | CONFIG_MTD_NAND_AT91 instead of CONFIG_MTD_NAND_ATMEL in source files | ||
---|---|---|---|
Product: | Platform Specific/Hardware | Reporter: | Guillaume GARDET (guillaume.gardet) |
Component: | ARM | Assignee: | linux-arm-kernel (linux-arm-kernel) |
Status: | CLOSED CODE_FIX | ||
Severity: | high | CC: | bunk, guillaume.gardet, pdupreez |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.27-rc1 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Bug Depends on: | |||
Bug Blocks: | 11167 | ||
Attachments: |
Proposed patch
[MTD] [NAND] Fix rename of at91_nand -> atmel_nand |
Description
Guillaume GARDET
2008-07-31 05:20:09 UTC
Created attachment 17041 [details]
Proposed patch
This patch apply to 2.6.27-rc1 and fix this bug.
Handled-By : Guillaume GARDET <guillaume.gardet@free.fr> Patch : http://bugzilla.kernel.org/attachment.cgi?id=17041&action=view Created attachment 17045 [details] [MTD] [NAND] Fix rename of at91_nand -> atmel_nand Structs called at91_nand_data where renamed to atmel_nand_data and configs called *MTD_NAND_AT91* where renamed to *MTD_NAND_ATMEL*. This was unfortunately not done consistently, causing NAND chips not being initialised on several ARM boards. I am aware that the author of the original change did not rename MTD_NAND_AT91_BUSWIDTH to MTD_NAND_ATMEL_BUSWIDTH, for example. All *MTD_NAND_AT91* where renamed to *MTD_NAND_ATMEL* in order to keep naming consistency. This patch was only tested on a MACH_SAM9_L9260, as this is the only ARM board I have to my disposal. Before this patch: $ git-ls-files |xargs grep atmel_nand |wc -l 105 $ git-ls-files |xargs grep at91_nand |wc -l 4 $ git-ls-files |xargs grep MTD_NAND_ATMEL |wc -l 8 $ git-ls-files |xargs grep MTD_NAND_AT91 |wc -l 47 After this patch: $ git-ls-files |xargs grep atmel_nand |wc -l 109 $ git-ls-files |xargs grep at91_nand |wc -l 0 $ git-ls-files |xargs grep MTD_NAND_ATMEL |wc -l 55 $ git-ls-files |xargs grep MTD_NAND_AT91 |wc -l 0 Signed-off-by: Pieter du Preez <pdupreez@gmail.com> Caused-By: commit 3c3796cc32b6e53653a5eb868dc959b8c2779db9 commit d4f4c0aa8e36f69e46360b3d3569dc15d6099894 Your patch solves it, but while we're at it, why don't we just fix all the missed renames, that caused this bug? I did that in the patch in comment #3: http://bugzilla.kernel.org/show_bug.cgi?id=11188#c3 (In reply to comment #5) > Your patch solves it, but while we're at it, why don't > we just fix all the missed renames, that caused this bug? > > I did that in the patch in comment #3: > http://bugzilla.kernel.org/show_bug.cgi?id=11188#c3 > You're right! Thanks for your patch which fix _all_ the missed renames. :) Who can submit this patch in the git tree? Committed to the mtd git tree. Thanks. fixed by commit f6ed6f78d46b43b6d908b39ed3322f7cda23f4a8 |