Bug 11160

Summary: sky2 Oops on ifconfig eth0 down on linux-2.6.26-git11
Product: Drivers Reporter: Emil Karlson (jekarlson)
Component: NetworkAssignee: Jeff Garzik (jgarzik)
Status: CLOSED CODE_FIX    
Severity: low CC: linville
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.26-git11 Subsystem:
Regression: Yes Bisected commit-id:
Attachments: dmesg output

Description Emil Karlson 2008-07-25 01:19:15 UTC
Latest working kernel version: linux-2.6.26-git9
Earliest failing kernel version: linux-2.6.26-git11
Distribution: gentoo
Hardware Environment: macbook revision 2
Problem Description:
------------[ cut here ]------------
WARNING: at net/core/dev.c:1344 __netif_schedule+0x24/0x6d()
Modules linked in: coretemp hwmon i2c_i801 sky2
Pid: 3198, comm: ifconfig Not tainted 2.6.26-git11 #1

Call Trace:
 [<ffffffff8022eb69>] warn_on_slowpath+0x51/0x8c
 [<ffffffff80240459>] autoremove_wake_function+0x9/0x2e
 [<ffffffff80226550>] __wake_up_common+0x46/0x76
 [<ffffffff802273b3>] __wake_up+0x38/0x4e
 [<ffffffff804d163e>] __netif_schedule+0x24/0x6d
 [<ffffffffa0003a40>] sky2_down+0x367/0x433 [sky2]
 [<ffffffff804df797>] some_qdisc_is_running+0x4e/0x6e
 [<ffffffff804d3a62>] dev_close+0x69/0x88
 [<ffffffff804d374a>] dev_change_flags+0xa6/0x163
 [<ffffffff80509fe4>] devinet_ioctl+0x268/0x5c4
 [<ffffffff80285799>] __user_walk_fd+0x48/0x53
 [<ffffffff804c791a>] sock_ioctl+0x1eb/0x20f
 [<ffffffff80286d99>] vfs_ioctl+0x21/0x6c
 [<ffffffff8028700b>] do_vfs_ioctl+0x227/0x23d
 [<ffffffff8028705e>] sys_ioctl+0x3d/0x5f
 [<ffffffff8020b20b>] system_call_fastpath+0x16/0x1b

---[ end trace a64966769ce52dec ]---


Steps to reproduce: ifconfig eth0 down

This is also the first kernel version I tried with ath9k (which btw works), it may or may not have some influence on this, will try later.
Comment 1 Emil Karlson 2008-07-25 01:21:19 UTC
Created attachment 16981 [details]
dmesg output
Comment 2 Emil Karlson 2008-07-25 01:23:37 UTC
sky2 appears to still work after reloading the module, so this bug is mostly cosmetic.
Comment 3 Anonymous Emailer 2008-07-25 01:27:59 UTC
Reply-To: akpm@linux-foundation.org


(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Fri, 25 Jul 2008 01:19:16 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=11160
> 
>            Summary: sky2 Oops on ifconfig eth0 down on linux-2.6.26-git11

(it's a warning, not an oops)

>            Product: Drivers
>            Version: 2.5
>      KernelVersion: 2.6.26-git11
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Network
>         AssignedTo: jgarzik@pobox.com
>         ReportedBy: jkarlson@cc.hut.fi
> 
> 
> Latest working kernel version: linux-2.6.26-git9
> Earliest failing kernel version: linux-2.6.26-git11
> Distribution: gentoo
> Hardware Environment: macbook revision 2
> Problem Description:
> ------------[ cut here ]------------
> WARNING: at net/core/dev.c:1344 __netif_schedule+0x24/0x6d()
> Modules linked in: coretemp hwmon i2c_i801 sky2
> Pid: 3198, comm: ifconfig Not tainted 2.6.26-git11 #1
> 
> Call Trace:
>  [<ffffffff8022eb69>] warn_on_slowpath+0x51/0x8c
>  [<ffffffff80240459>] autoremove_wake_function+0x9/0x2e
>  [<ffffffff80226550>] __wake_up_common+0x46/0x76
>  [<ffffffff802273b3>] __wake_up+0x38/0x4e
>  [<ffffffff804d163e>] __netif_schedule+0x24/0x6d
>  [<ffffffffa0003a40>] sky2_down+0x367/0x433 [sky2]
>  [<ffffffff804df797>] some_qdisc_is_running+0x4e/0x6e
>  [<ffffffff804d3a62>] dev_close+0x69/0x88
>  [<ffffffff804d374a>] dev_change_flags+0xa6/0x163
>  [<ffffffff80509fe4>] devinet_ioctl+0x268/0x5c4
>  [<ffffffff80285799>] __user_walk_fd+0x48/0x53
>  [<ffffffff804c791a>] sock_ioctl+0x1eb/0x20f
>  [<ffffffff80286d99>] vfs_ioctl+0x21/0x6c
>  [<ffffffff8028700b>] do_vfs_ioctl+0x227/0x23d
>  [<ffffffff8028705e>] sys_ioctl+0x3d/0x5f
>  [<ffffffff8020b20b>] system_call_fastpath+0x16/0x1b
> 
> ---[ end trace a64966769ce52dec ]---
> 
> 
> Steps to reproduce: ifconfig eth0 down
> 
> This is also the first kernel version I tried with ath9k (which btw works),
> it
> may or may not have some influence on this, will try later.
> 

I think this is known about and is being worked on.
Comment 4 David S. Miller 2008-07-25 01:29:42 UTC
From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 25 Jul 2008 01:27:54 -0700

> 
> (switched to email.  Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
> 
> On Fri, 25 Jul 2008 01:19:16 -0700 (PDT) bugme-daemon@bugzilla.kernel.org
> wrote:
> 
> > http://bugzilla.kernel.org/show_bug.cgi?id=11160
> > 
> >            Summary: sky2 Oops on ifconfig eth0 down on linux-2.6.26-git11
> 
> (it's a warning, not an oops)
 ...
> I think this is known about and is being worked on.

Yes, in fact we don't warn for this case any more in Linus's
tree, so you can safely close this.