Bug 11140

Summary:	cannot select i2c-algo-pcf
Product:	Drivers	Reporter:	Daniel Smolik (marvin)
Component:	I2C	Assignee:	Jean Delvare (jdelvare)
Status:	CLOSED CODE_FIX
Severity:	low
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.26	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	i2c: Let users select algorithm drivers manually again

Description Daniel Smolik 2008-07-21 15:58:41 UTC

Latest working kernel version: 2.6.24.3
Earliest failing kernel version: 2.6.26
Distribution: Debian SID
Hardware Environment: Sun E450 2x 400Mhz/1GB Ram
Software Environment: source 2.6.26
Problem Description:
In menuconfig on 2.6.26 is not possilble select i2-algos and thus I cannot compile i2c-algos-pcf that i need. Copy Kconfig from 2.6.24.3 solve problem

Steps to reproduce:
untar 2.6.26 and run menuconfig look at I2C menu and there is nothing about i2c-algos

Comment 1 Daniel Smolik 2008-07-21 16:05:24 UTC

This commit is responsible for this:
Jean Delvare (2):
i2c: Remove the algorithm drivers from the config menu
i2c-dev: Split i2cdev_ioctl

Why remove algorithm drivers ?

Comment 2 Jean Delvare 2008-08-07 02:25:07 UTC

I2C algorithm drivers were not removed. They simply are no longer visible in the configuration menu. The reason for that is that i2c bus drivers which need these i2c algorithm drivers are supposed to select them automatically, so the user doesn't have to care.

The only driver which needs i2c-algo-pcf in the 2.6.26 kernel tree is i2c-elektor, and it properly selects I2C_ALGOPCF. What do you need i2c-algo-pcf for? If this is for an external driver, then maybe it's time for you to push it upstream. Or, if that external driver is maintained as a kernel patch, you simply need to fix your Kconfig to select I2C_ALGOPCF.

Comment 3 Jean Delvare 2008-08-08 01:57:57 UTC

Created attachment 17142 [details]
i2c: Let users select algorithm drivers manually again

Would this patch address your concerns?

Comment 4 Daniel Smolik 2008-08-08 11:25:07 UTC

bugme-daemon@bugzilla.kernel.org napsal(a):
> http://bugzilla.kernel.org/show_bug.cgi?id=11140
> 
> 
> khali@linux-fr.org changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>            Severity|normal                      |low
>              Status|NEW                         |ASSIGNED
> 
> 
> 
> 
> ------- Comment #2 from khali@linux-fr.org  2008-08-07 02:25 -------
> I2C algorithm drivers were not removed. They simply are no longer visible in
> the configuration menu. The reason for that is that i2c bus drivers which
> need
> these i2c algorithm drivers are supposed to select them automatically, so the
> user doesn't have to care.
> 
> The only driver which needs i2c-algo-pcf in the 2.6.26 kernel tree is
> i2c-elektor, and it properly selects I2C_ALGOPCF. What do you need
> i2c-algo-pcf
> for? If this is for an external driver, then maybe it's time for you to push
> it
> upstream. Or, if that external driver is maintained as a kernel patch, you
> simply need to fix your Kconfig to select I2C_ALGOPCF.
> 
> 
I use it for this diver:
http://www.david-web.co.uk/index.php?p=envctrl
I have both E450 and E250 and try helping with development.

				Dan

Comment 5 Daniel Smolik 2008-08-08 11:25:18 UTC

I use it for this diver:
http://www.david-web.co.uk/index.php?p=envctrl
I have both E450 and E250 and try helping with development.
Thanks this helps.


                Dan