Bug 11073
Summary: | SiS 190/191 on ASUS P5SD2-VM dont detect link status / dont send traffic | ||
---|---|---|---|
Product: | Drivers | Reporter: | Leandro Oliveira (leandro) |
Component: | Network | Assignee: | Francois Romieu (romieu) |
Status: | CLOSED WILL_FIX_LATER | ||
Severity: | normal | CC: | alan, bugzilla, coenraad, herton, leandro, nagura-s |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.24 / 2.6.25 | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: |
patch to do polling for link status
Patch for SiS191 LAN chip |
Description
Leandro Oliveira
2008-07-12 06:41:59 UTC
Created attachment 16963 [details]
patch to do polling for link status
I have the same problem here, it's a sis190 with realtek phy in a Clevo notebook. Here hardware doesn't report LinkChange inside iterrupt handler, so I used the already present phy timer to do polling for link status.
I have a motherboard ASUS P5SD2-VM with SIS968 chipset and SIS190/191 10/100 ethernet controler. Using kernel 2.6.25.x - 2.6.26.2 (Plamo linux 4.5alpha) this device is found by kernel send trafic at sis190.c mii_chip_table 1 line insert. { "Atheros PHY AR8012", { 0x004d, 0xd020 }, LAN, 0 }, Created attachment 18069 [details]
Patch for SiS191 LAN chip
I've attached what nagura shouichi suggests, in patch form. The patch can be applied to 2.6.24 as well as 2.6.27 (and presumably anything in between), and I can confirm that this fixes the issue for another SiS 191 on an Asus P5SD2-VM motherboard.
The patch I posted here is for another bug then, by the bug description I thought it was the same, didn't paid attention for the "don't send traffic" part, my bad. The problem I experienced wasn't because of missing phy id like this ticket, but only a problem in link detection, for example not detecting removal of ethernet cable, network traffic always worked, while debugging I found the issue (LinkChange not reported inside interrupt handler) and posted the patch. Should I open a new ticket, is the patch good, is more info needed? Are you sure its not just missing the PHY link as per https://answers.launchpad.net/ubuntu/+question/38994 I had the same problem on the same board, and patched the sis190.c file by adding a line: } mii_chip_table[] = { ++ { "Atheros PHY AR8012", { 0x004d, 0xd020 }, LAN, 0 }, { "Broadcom PHY BCM5461", { 0x0020, 0x60c0 }, LAN, F_PHY_BCM5461 }, Works perfectly now, detects link, etc... Havent tried the patch posted earlier... sounds dodgy, especially for "the worlds most advanced GbE PHY..."... Hopefully it's not just using the chip in a compatibility mode, but I can confirm that it transmits and detects link status on a 100mbit connection. Possibly duplicate of http://bugzilla.kernel.org/show_bug.cgi?id=10994 The fix for http://bugzilla.kernel.org/show_bug.cgi?id=10994 went in mainline. Can somebody check if the bug still exists in 2.6.28-rc2 ? -- Ueimor (In reply to comment #5) > Are you sure its not just missing the PHY link as per > https://answers.launchpad.net/ubuntu/+question/38994 Yes, sis190 here is using a realtek phy that is detected looking at kernel log, unrelated issue to this ticket. I opened a new one now: http://bugzilla.kernel.org/show_bug.cgi?id=11926 This bug has been split in two: The fix for http://bugzilla.kernel.org/show_bug.cgi?id=10994 went in mainline. (FIXED) http://bugzilla.kernel.org/show_bug.cgi?id=11926 (UNFIXED) FYI, Anybody free to confirm... ;) Closing this as the two split bugs are sufficient now |