Bug 109291
Summary: | The system cannot enter any suspend state. | ||
---|---|---|---|
Product: | File System | Reporter: | Michael Long (harn-solo) |
Component: | XFS | Assignee: | XFS Guru (xfs-masters) |
Status: | NEW --- | ||
Severity: | normal | CC: | david, szg00000 |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 4.4.0-rc | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
Michael Long
2015-12-13 10:26:24 UTC
The xfsaild is already idle and not running - it won't run again until some activity in the filesystem wakes it up again. Hence the xfsaild will never call try_to_freeze() and be frozen by the freezer. This looks like a bug in the freezer algorithm, not XFS. Likely caused by this change in 4.4-rc1: commit 24ba16bb3d499c49974669cd8429c3e4138ab102 Author: Jiri Kosina <jkosina@suse.cz> Date: Mon Nov 2 13:46:58 2015 +1100 xfs: clear PF_NOFREEZE for xfsaild kthread Since xfsaild has been converted to kthread in 0030807c, it calls try_to_freeze() during every AIL push iteration. It however doesn't set itself as freezable, and therefore this try_to_freeze() will never do anything. Before (hopefully eventually) kthread freezing gets converted to fileystem freezing, we'd rather mark xfsaild freezable (as it can generate I/O during suspend). Signed-off-by: Jiri Kosina <jkosina@suse.cz> Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com> |