Bug 1077
| Summary: | Inoperative CompUSA USB optical notebook mouse | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Warren Togami (warren) |
| Component: | USB | Assignee: | Greg Kroah-Hartman (greg) |
| Status: | REJECTED WILL_NOT_FIX | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Hardware: | i386 | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.0-0.test3.1.31 | Subsystem: | |
| Regression: | --- | Bisected commit-id: | |
|
Description
Warren Togami
2003-08-10 23:30:11 UTC
I have determined that the traceback above was an unrelated coincidence, not
triggered by the mouse.
===== drivers/usb/core/message.c 1.34 vs edited =====
--- 1.34/drivers/usb/core/message.c Mon Aug 11 07:56:25 2003
+++ edited/drivers/usb/core/message.c Tue Aug 12 07:54:19 2003
@@ -1055,6 +1055,7 @@
}
if ((!cp && configuration != 0) || (cp && configuration == 0)) {
warn("selecting invalid configuration %d", configuration);
+ usb_show_device(dev);
return -EINVAL;
}
After applying this patch suggested by David Brownell, this message appears in
dmesg.
Length = 18
DescriptorType = 01
USB version = 1.10
Vendor:Product = 062a:0000
MaxPacketSize0 = 8
NumConfigurations = 1
Device version = 2.04
Device Class:SubClass:Protocol = 00:00:00
Per-interface classes
Configuration:
bLength = 9
bDescriptorType = 02
wTotalLength = 0022
bNumInterfaces = 01
bConfigurationValue = 00
iConfiguration = 00
bmAttributes = a0
bMaxPower = 100mA
Interface: 0
Alternate Setting: 0
bLength = 9
bDescriptorType = 04
bInterfaceNumber = 00
bAlternateSetting = 00
bNumEndpoints = 01
bInterface Class:SubClass:Protocol = 03:01:02
iInterface = 00
Endpoint:
bLength = 7
bDescriptorType = 05
bEndpointAddress = 81 (in)
bmAttributes = 03 (Interrupt)
wMaxPacketSize = 0004
bInterval = 0a
On Wed, 2003-08-13 at 05:30, David Brownell wrote:
> Thanks for that info. It confirms what I expected: this
> device violates the USB specification. That's interesting
> to know. This particular violation doesn't seem common,
> since yours is the first report of this error. And it
> should be one we can turn into a "don't care".
>
>
> > Please instruct me about what to do next.
>
> Let us know if you can use the device after applying
> this patch! If it does, I'll ask Greg to merge it.
>
> - Dave
>
>
>
> --- 1.34/drivers/usb/core/message.c Mon Aug 11 07:56:25 2003
> +++ edited/drivers/usb/core/message.c Wed Aug 13 08:26:45 2003
> @@ -1053,10 +1053,18 @@
> break;
> }
> }
> - if ((!cp && configuration != 0) || (cp && configuration == 0)) {
> - warn("selecting invalid configuration %d", configuration);
> + if (!cp && configuration != 0) {
> + dev_dbg(&dev->dev, "selecting invalid configuration %d\n",
> + configuration);
> return -EINVAL;
> }
> +
> + /* the usb spec defines config zero as meaning the device is in
> + * ADDRESS state; otherwise it's CONFIGURED. but at least one
> + * usb 1.1 mouse (062a:0000 v2.4) won't even try to fake it.
> + */
> + if (cp && configuration == 0)
> + dev_warn(&dev->dev, "illegal descriptors, for config #0\n");
>
> /* if it's already configured, clear out old state first. */
> if (dev->state != USB_STATE_ADDRESS)
After applying this patch, these messages appear when the CompUSA mouse is
plugged in, immediately after all USB devices on my system including my Logitech
USB keyboard seize to function. If I am in X it locks up completely, if I am in
a VT I am able to use my laptop's PS/2 internal keyboard to poweroff.
hub 1-0:0: debounce: port 2: delay 100ms stable 4 status 0x301
hub 1-0:0: new USB device on port 2, assigned address 5
usb 1-2: illegal descriptors, for config #0
drivers/usb/core/message.c: error getting string descriptor 0 (error=-75)
Just return this device. It is broken very badly, and violates the USB spec |