Bug 100481

Summary:	synaptics ClickFinger3 setting stopped working in 4.1
Product:	Drivers	Reporter:	rainer+kernelorg
Component:	Input Devices	Assignee:	drivers_input-devices
Status:	RESOLVED CODE_FIX
Severity:	normal	CC:	barbieken, dmitry.torokhov, niranjan.public
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.1	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	restore 3 fingers click on Synaptics clickpad

Description rainer+kernelorg 2015-06-25 10:16:28 UTC

While the synaptics driver in kernels up to and including 4.0.6 does indeed send different button events when clicking the touchpad with three fingers, depening on the setting of ClickFinger3, the driver included in kernel 4.1 does not. With otherwise identical configurations, I can't seem to get a plain kernel 4.1 to send button 2 events for ClickFinger3 events. Replacing synaptics.c and synaptics.h in the 4.1 source tree with the versions from kernel 4.0.6 reverts to the old, correct behaviour. 

TapButton3 on the other hand appears to be working OK in both 4.0.6 and 4.1.

I don't see any relevant changes in evtest |egrep BTN

with 4.0.6

Event: time 1435226269.303392, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 1
Event: time 1435226269.303392, type 1 (EV_KEY), code 334 (BTN_TOOL_TRIPLETAP), value 1
Event: time 1435226270.164069, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1435226270.326422, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0
Event: time 1435226270.865842, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1435226271.000603, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0
Event: time 1435226271.405719, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1435226271.514175, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0
Event: time 1435226272.136086, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1435226272.298935, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0


with 4.1

Event: time 1435226517.404197, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 1
Event: time 1435226517.404197, type 1 (EV_KEY), code 334 (BTN_TOOL_TRIPLETAP), value 1
Event: time 1435226518.199004, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1435226518.444850, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0
Event: time 1435226519.611769, type 1 (EV_KEY), code 325 (BTN_TOOL_FINGER), value 1
Event: time 1435226519.611769, type 1 (EV_KEY), code 334 (BTN_TOOL_TRIPLETAP), value 0
Event: time 1435226519.620124, type 1 (EV_KEY), code 330 (BTN_TOUCH), value 0


The touch- / clickpad I'm using is in a Lenovo thinkpad 440s.

[    1.321773] psmouse serio1: synaptics: queried max coordinates: x [..5112], y [..3834]
[    1.353593] psmouse serio1: synaptics: queried min coordinates: x [1024..], y [1024..]
[    1.353597] psmouse serio1: synaptics: quirked min/max coordinates: x [1024..5112], y [2024..4832]
[    1.415727] psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1, caps: 0xd002a3/0x940300/0x127c00, board id: 2668, fw id: 1545510
[    1.415733] psmouse serio1: synaptics: serio: Synaptics pass-through port at isa0060/serio1/input0

Comment 1 barbieken 2015-07-08 15:37:42 UTC

Confirm, Thinkpad T540p

https://forums.gentoo.org/viewtopic-p-7776230.html#7776230

It's quite serious bug for such laptops users, without 3 fingers click mouse is almost required

Comment 2 barbieken 2015-07-08 16:35:27 UTC

Created attachment 182191 [details]
restore 3 fingers click on Synaptics clickpad

This patch for 4.1.1 fixed the problem for me

Comment 3 rainer+kernelorg 2015-07-10 11:26:01 UTC

The patch in  attachment 182191 [details]  restores 3 finger clickpad functionality for me as well. Thanks!

Comment 4 Dmitry Torokhov 2015-07-13 19:17:21 UTC

Fixed with dbf3c370862d73fcd2c74ca55e254bb02143238d