Bug 10033

Summary: mips yosemite_defconfig compile error
Product: Platform Specific/Hardware Reporter: Adrian Bunk (bunk)
Component: MIPSAssignee: ralf
Severity: normal CC: clameter, gorcunov
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.25-rc2 Subsystem:
Regression: Yes Bisected commit-id:
Bug Depends on:    
Bug Blocks: 9832    
Attachments: Patch to test

Description Adrian Bunk 2008-02-17 16:45:31 UTC
Subject         : mips yosemite_defconfig compile error
Submitter       : Adrian Bunk <bunk@kernel.org>
References      : http://lkml.org/lkml/2008/2/17/383
Caused-By       : Christoph Lameter <clameter@sgi.com>
                  commit 9e2779fa281cfda13ac060753d674bbcaa23367e
Comment 1 Cyrill Gorcunov 2008-03-09 05:28:23 UTC
Adiran, could you try the patch attached?
Comment 2 Cyrill Gorcunov 2008-03-09 05:29:23 UTC
Created attachment 15187 [details]
Patch to test
Comment 3 Cyrill Gorcunov 2008-03-09 09:11:54 UTC
Oops, s/Adiran/Adrian/, sorry :(
Comment 4 Adrian Bunk 2008-03-09 17:31:41 UTC
I can confirm your patch fixes the compilation.

Whether it's correct Ralf has to say.
Comment 5 Cyrill Gorcunov 2008-03-11 12:12:58 UTC
Btw, I think that 'include' from the patch I posted has to be there regardless of this bug. Look, we have in pgtable_32.h


but PKMAP_BASE is defined in highmem.h so Christoph's patch just reveal this
problem. gcc was successfuly compiling MIPS before this patch 'cause of its intelligence - deffered macros exposure I think.
Comment 6 Adrian Bunk 2008-03-14 00:59:50 UTC
fixed by commit 2ac7401d11370b7a8e3a1c74aac03a021fd61048