An ACPI callback for PCI set power state --- 2.5-root/drivers/acpi/bus.c | 8 +++++++- 2.5-root/drivers/pci/pci-acpi.c | 19 +++++++++++++++++++ 2.5-root/drivers/pci/pci.c | 11 +++++++++-- 2.5-root/drivers/pci/pci.h | 1 + 4 files changed, 36 insertions(+), 3 deletions(-) diff -puN drivers/acpi/bus.c~acpi-pci-set-power-state-callback drivers/acpi/bus.c --- 2.5/drivers/acpi/bus.c~acpi-pci-set-power-state-callback 2005-03-03 17:20:56.190568384 +0800 +++ 2.5-root/drivers/acpi/bus.c 2005-03-03 17:20:56.198567168 +0800 @@ -212,6 +212,12 @@ acpi_bus_set_power ( ACPI_DEBUG_PRINT((ACPI_DB_WARN, "Device is not power manageable\n")); return_VALUE(-ENODEV); } + /* + * Get device's current power state if it's unknown + * This means device power state isn't initialized or previous setting failed + */ + if (device->power.state == ACPI_STATE_UNKNOWN) + acpi_bus_get_power(device->handle, &device->power.state); if (state == device->power.state) { ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device is already at D%d\n", state)); return_VALUE(0); @@ -231,7 +237,7 @@ acpi_bus_set_power ( * On transitions to a high-powered state we first apply power (via * power resources) then evalute _PSx. Conversly for transitions to * a lower-powered state. - */ + */ if (state < device->power.state) { if (device->power.flags.power_resources) { result = acpi_power_transition(device, state); diff -puN drivers/pci/pci-acpi.c~acpi-pci-set-power-state-callback drivers/pci/pci-acpi.c --- 2.5/drivers/pci/pci-acpi.c~acpi-pci-set-power-state-callback 2005-03-03 17:20:56.192568080 +0800 +++ 2.5-root/drivers/pci/pci-acpi.c 2005-03-03 17:28:22.516716496 +0800 @@ -227,6 +227,24 @@ static int acpi_pci_choose_state(struct return -ENODEV; } +static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) +{ + acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev); + static int state_conv[] = { + [0] = 0, + [1] = 1, + [2] = 2, + [3] = 3, + [4] = 3 + }; + int acpi_state = state_conv[(int __force) state]; + + if (!handle) + return -ENODEV; + return acpi_bus_set_power(handle, acpi_state); +} + + /* ACPI bus type */ static int pci_acpi_find_device(struct device *dev, acpi_handle *handle) { @@ -274,6 +292,7 @@ static int __init pci_acpi_init(void) if (ret) return 0; platform_pci_choose_state = acpi_pci_choose_state; + platform_pci_set_power_state = acpi_pci_set_power_state; return 0; } arch_initcall(pci_acpi_init); diff -puN drivers/pci/pci.c~acpi-pci-set-power-state-callback drivers/pci/pci.c --- 2.5/drivers/pci/pci.c~acpi-pci-set-power-state-callback 2005-03-03 17:20:56.193567928 +0800 +++ 2.5-root/drivers/pci/pci.c 2005-03-03 17:20:56.199567016 +0800 @@ -240,7 +240,7 @@ pci_find_parent_resource(const struct pc * -EIO if device does not support PCI PM. * 0 if we can successfully change the power state. */ - +int (*platform_pci_set_power_state)(struct pci_dev *dev, pci_power_t t) = NULL; int pci_set_power_state(struct pci_dev *dev, pci_power_t state) { @@ -304,8 +304,15 @@ pci_set_power_state(struct pci_dev *dev, msleep(10); else if (state == PCI_D2 || dev->current_state == PCI_D2) udelay(200); - dev->current_state = state; + /* + * Give firmware a chance to be called, such as ACPI _PRx, _PSx + * Firmware method after natice method ? + */ + if (platform_pci_set_power_state) + platform_pci_set_power_state(dev, state); + + dev->current_state = state; return 0; } diff -puN drivers/pci/pci.h~acpi-pci-set-power-state-callback drivers/pci/pci.h --- 2.5/drivers/pci/pci.h~acpi-pci-set-power-state-callback 2005-03-03 17:20:56.195567624 +0800 +++ 2.5-root/drivers/pci/pci.h 2005-03-03 17:20:56.199567016 +0800 @@ -13,6 +13,7 @@ extern int pci_bus_alloc_resource(struct void *alignf_data); /* Firmware callbacks */ extern int (*platform_pci_choose_state)(struct pci_dev *dev, pm_message_t state); +extern int (*platform_pci_set_power_state)(struct pci_dev *dev, pci_power_t state); /* PCI /proc functions */ #ifdef CONFIG_PROC_FS _